From: Tejas Upadhyay <tejas.upadhyay@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: himal.prasad.ghimiray@intel.com, matthew.brost@intel.com,
Tejas Upadhyay <tejas.upadhyay@intel.com>
Subject: [V4] drm/xe: Skip clearing purged page-table BOs
Date: Wed, 9 Sep 2026 16:46:21 +0530 [thread overview]
Message-ID: <20260909111620.1276402-2-tejas.upadhyay@intel.com> (raw)
VRAM page offlining can clear a page-table BO's vmap before VM teardown
calls xe_pt_clear(). Check for a purged BO under its dma-resv lock before
writing to the mapping.
v4(Sashiko):
- dont leave svm notifier lock early
v3(Sashiko):
- Validate NULL vmap
v2(Sashiko):
- Fix lock ordering
Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
drivers/gpu/drm/xe/xe_pt.c | 6 ++++--
drivers/gpu/drm/xe/xe_vm.c | 4 ++++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index 7fb2fe1f826c..4b351dbf6572 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -236,9 +236,11 @@ void xe_pt_destroy(struct xe_pt *pt, u32 flags, struct llist_head *deferred)
*/
void xe_pt_clear(struct xe_device *xe, struct xe_pt *pt)
{
- struct iosys_map *map = &pt->bo->vmap;
+ struct xe_bo *bo = pt->bo;
- xe_map_memset(xe, map, 0, 0, SZ_4K);
+ xe_bo_assert_held(bo);
+ if (!iosys_map_is_null(&bo->vmap))
+ xe_map_memset(xe, &bo->vmap, 0, 0, SZ_4K);
}
/**
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 9e71567b27cc..efa5ff6cc823 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -1876,6 +1876,8 @@ static void xe_vm_close(struct xe_vm *vm)
bound = drm_dev_enter(&xe->drm, &idx);
down_write(&vm->lock);
+ xe_vm_lock(vm, false);
+
if (xe_vm_in_fault_mode(vm))
xe_svm_notifier_lock(vm);
@@ -1903,6 +1905,8 @@ static void xe_vm_close(struct xe_vm *vm)
if (xe_vm_in_fault_mode(vm))
xe_svm_notifier_unlock(vm);
+
+ xe_vm_unlock(vm);
up_write(&vm->lock);
if (bound)
--
2.52.0
next reply other threads:[~2026-09-09 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 11:16 Tejas Upadhyay [this message]
2026-09-09 12:06 ` ✗ CI.KUnit: failure for drm/xe: Skip clearing purged page-table BOs (rev4) Patchwork
2026-09-10 5:00 ` [V4] drm/xe: Skip clearing purged page-table BOs Matthew Brost
2026-09-10 5:45 ` ✓ CI.KUnit: success for drm/xe: Skip clearing purged page-table BOs (rev5) Patchwork
2026-09-10 6:31 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-10 14:19 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909111620.1276402-2-tejas.upadhyay@intel.com \
--to=tejas.upadhyay@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox