From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AA55C88E4F for ; Wed, 9 Sep 2026 15:48:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 013D810F1F9; Wed, 9 Sep 2026 15:48:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="NEnbmfkG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A290410F1DD for ; Wed, 9 Sep 2026 15:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788968879; x=1820504879; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=cBLkstfZV7FeSnmOp5Vv8t6GcefvtRBwmlxcw1AND1k=; b=NEnbmfkG4AGZTVosXuRhY//apmBVZassTK1EMyv3lxRqWcSHE5Y9ghk8 LcugnX8v4/P82UVIfv3EHqzRjWKACZ0Z4gdNN0uBzZVIAZEYcg8TUPHxj +gmqO4bAvipAiWxMXU98jSOe/RdHDj8VjOCuLelZqcX7gMQ+Ik2l1nGA+ We3qam73VF695evyAoNd0kDHzy3sLmq9bBQNpw4/Q3jNm4YI9m9trgdYE qORznMwUH5g6Zv9OWYJEHW5QvNul4aPsqX0rkDDO8hRmyaKe59rtdQR/j peJ51A9q4SOfAdxzR5foDW75oJtUIEmISSuYTNnboL7YP7+CUARm1yLVv Q==; X-CSE-ConnectionGUID: H5OD6Nc0QHe7IP/pGZGd2Q== X-CSE-MsgGUID: zPXSi6FBQDOudoz0myx83g== X-IronPort-AV: E=McAfee;i="6800,10657,11900"; a="93091828" X-IronPort-AV: E=Sophos;i="6.25,270,1779174000"; d="scan'208";a="93091828" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2026 08:47:58 -0700 X-CSE-ConnectionGUID: AP9j4V6YQ9iJPKuXiYeBRw== X-CSE-MsgGUID: mFgQv48cStWRgdjQ2gL4Cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,270,1779174000"; d="scan'208";a="268102514" Received: from mjruhl-vm.amr.corp.intel.com ([10.11.186.166]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2026 08:47:57 -0700 From: "Michael J. Ruhl" To: platform-driver-x86@vger.kernel.org, intel-xe@lists.freedesktop.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com, anoop.c.vijay@intel.com, badal.nilawar@intel.com, matthew.d.roper@intel.com, james.ausmus@intel.com, karthik.poosa@intel.com Subject: [PATCH v7 08/20] drm/xe/vsec: Use correct pm state get Date: Wed, 9 Sep 2026 08:47:47 -0700 Message-ID: <20260909154739.1515514-30-michael.j.ruhl@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909154739.1515514-22-michael.j.ruhl@intel.com> References: <20260909154739.1515514-22-michael.j.ruhl@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Crashlog needs to be collected at all times. The current pm check assumes telemetry only. Update read path to enable device for crashlog instances. Include check of the WATCHER CAP_TYPE for completeness. WATCHER is a possible type and needs to be accounted for, but is not supported. Signed-off-by: Michael J. Ruhl Fixes: 2c402a801c19 ("platform/x86/intel/pmt: support BMG crashlog") --- drivers/gpu/drm/xe/xe_vsec.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c index dd7723ba6c1c..468a221378fa 100644 --- a/drivers/gpu/drm/xe/xe_vsec.c +++ b/drivers/gpu/drm/xe/xe_vsec.c @@ -145,6 +145,7 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse { struct xe_device *xe = kdev_to_xe_device(dev); void __iomem *telem_addr = xe->mmio.regs + BMG_TELEMETRY_OFFSET; + u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid); u32 mem_region; u32 offset; int ret; @@ -158,9 +159,18 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse telem_addr += offset + user_offset; - /* indicate that we are not at an appropriate power level */ - if (!xe_pm_runtime_get_if_active(xe)) - return -ENODATA; + /* Always allow crashlog. Telemetry, only when powered */ + switch (cap_type) { + case CRASHLOG: + xe_pm_runtime_get(xe); + break; + case TELEMETRY: + if (!xe_pm_runtime_get_if_active(xe)) + return -ENODATA; + break; + case WATCHER: + return -EINVAL; + } mutex_lock(&xe->pmt.lock); -- 2.43.0