Re: [PATCH v4 5/7] drm/xe/uc: Report DMA failure using SIGID

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] xe: missing conversion of DMA failure message to xe_log_err() in uc_fw_xfer()
--

commit 519565d5579d72f99be56f54099a18eadbbceb69
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

drm/xe/uc: Report DMA failure using SIGID

Convert the uC DMA failure error to use the xe_log_err() helper.

> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index a8e6f18cc9b4a..21e2c1be08842 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
[ ... ]
> @@ -927,9 +932,11 @@ int xe_uc_fw_upload(struct xe_uc_fw *uc_fw, u32 offset, u32 dma_flags)
>  	return 0;
>  
>  fail:
> -	drm_err(&xe->drm, "Failed to load %s firmware %s (%d)\n",
> -		xe_uc_fw_type_repr(uc_fw->type), uc_fw->path,
> -		err);
> +	if (uc_fw->type == XE_UC_FW_TYPE_GUC)
> +		xe_log_err(gt, GUC, err, "Failed to load firmware %s\n", uc_fw->path);
> +	else
> +		xe_log_err(gt, HUC, err, "Failed to load firmware %s\n", uc_fw->path);
> +

[Severity: Medium]
Does this commit match its description? The commit message explicitly claims
to "Convert the uC DMA failure error to use the xe_log_err() helper."

While it did convert the generic firmware load failure message here in
xe_uc_fw_upload(), it entirely missed the actual DMA-specific error message
in uc_fw_xfer():

	if (ret)
		drm_err(&xe->drm, "DMA for %s fw failed, DMA_CTRL=%u\n",
			xe_uc_fw_type_repr(uc_fw->type), dma_ctrl);

If the uC firmware DMA transfer fails (e.g., timeout in xe_mmio_wait32), the
error is still logged using the old drm_err() format without the intended
SIGID logging.

>  	xe_uc_fw_change_status(uc_fw, XE_UC_FIRMWARE_LOAD_FAIL);
>  	return err;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917235923.1521112-9-umesh.nerlige.ramappa@intel.com?part=5