Re: [PATCH] drm/i915/dp: Disable DC5/6 before AUX programming

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/i915/dp: missing 'if' keyword before HAS_LT_PHY() causing build error
--

commit 50d9f2e05d7a2031877229580c7c2591f8281933
Author: Suraj Kandpal <suraj.kandpal@intel.com>

drm/i915/dp: Disable DC5/6 before AUX programming

This commit disables DC5/6 before AUX programming for platforms with LT PHY.
It ensures that step 4 of the AUX programming sequence is honored since the
LT PHY powers down the PHY.

> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 3cb07b0a901cf..350dac72c9961 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -286,6 +287,9 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
>  
>  	aux_wakeref = intel_display_power_get(display, aux_domain);
>  
> +	(HAS_LT_PHY(display))
> +		dc_off_wakeref = intel_display_power_get(display, POWER_DOMAIN_DC_OFF);
> +

[Severity: Low]
Is there a missing 'if' keyword here in intel_dp_aux_xfer()? This appears to
introduce a syntax error by having the expression (HAS_LT_PHY(display))
adjacent to the assignment without a control flow statement, which will cause
a build failure.

>  	/*
>  	 * The PPS state needs to be locked for:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918060426.1162123-1-suraj.kandpal@intel.com?part=1