From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F114C982E2 for ; Fri, 18 Sep 2026 13:18:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5027B10F3A6; Fri, 18 Sep 2026 13:18:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GuH3A2hr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5796A10F384 for ; Fri, 18 Sep 2026 13:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789737486; x=1821273486; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=MGQAlYiLpONZ0Ryb8RIVrBejnl/f0iDutSCPEzjDkR4=; b=GuH3A2hrwusJE9xv1LPM0G3GnOQKHLurNFgqALFt7U+jf/FZ1wm02Mj3 HgCxKGJRl4Vm4UB8QfleRqghJ96EfpjvOV1SZYfnmdOTe6r2mEHtSX3HU H56RCwNgc1JwbkTPlh/qbYlPx5y7NUYgcFN/8pe17HtTszkxpDFajy7kT 69mWXPW3tGmdqMoEbnWt1eTUQjP2ne7vWcumydZjK0vflc6AInvQ1D2U1 P8bVgn18E0w9QJTHG8ePzDZjqt1ix+xUuFPkcBTA158a3KykdRd4M9yGv wRBnvi+5ril0U8AscSnP5seKGtOmG4O6r5cDkfx4Zb9hetpl/FMSIjvA2 g==; X-CSE-ConnectionGUID: xQyBLU6jQGqA1wLMxfR9dw== X-CSE-MsgGUID: RH6hj3g5Ssq7kAd5aweI3w== X-IronPort-AV: E=McAfee;i="6800,10657,11908"; a="89378242" X-IronPort-AV: E=Sophos;i="6.27,109,1787036400"; d="scan'208";a="89378242" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2026 06:18:03 -0700 X-CSE-ConnectionGUID: +b12gVjtSFW6xpE0cCZ25A== X-CSE-MsgGUID: V6HnOJyQSUG+pd9sLWfaLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,109,1787036400"; d="scan'208";a="270095329" Received: from mjruhl-vm.amr.corp.intel.com ([10.11.186.166]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2026 06:18:02 -0700 From: "Michael J. Ruhl" To: platform-driver-x86@vger.kernel.org, intel-xe@lists.freedesktop.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com, anoop.c.vijay@intel.com, badal.nilawar@intel.com, matthew.d.roper@intel.com, james.ausmus@intel.com, karthik.poosa@intel.com Subject: [PATCH v10 08/20] drm/xe/vsec: Use correct pm state get Date: Fri, 18 Sep 2026 06:17:59 -0700 Message-ID: <20260918131751.2408883-30-michael.j.ruhl@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918131751.2408883-22-michael.j.ruhl@intel.com> References: <20260918131751.2408883-22-michael.j.ruhl@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Crashlog needs to be collected at all times. The current pm check assumes telemetry only. Update read path to enable device for crashlog instances. Include check of the WATCHER CAP_TYPE for completeness. WATCHER is a possible type and needs to be accounted for, but is not supported. Reviewed-by: Rodrigo Vivi Fixes: 2c402a801c19 ("platform/x86/intel/pmt: support BMG crashlog") Signed-off-by: Michael J. Ruhl --- drivers/gpu/drm/xe/xe_vsec.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c index 1b88ac1d2448..1cb9a78ee0ef 100644 --- a/drivers/gpu/drm/xe/xe_vsec.c +++ b/drivers/gpu/drm/xe/xe_vsec.c @@ -145,6 +145,7 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse { struct xe_device *xe = kdev_to_xe_device(dev); void __iomem *telem_addr = xe->mmio.regs + BMG_TELEMETRY_OFFSET; + u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid); u32 mem_region; u32 offset; int ret; @@ -157,9 +158,18 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse telem_addr += offset + user_offset; - /* indicate that we are not at an appropriate power level */ - if (!xe_pm_runtime_get_if_active(xe)) - return -ENODATA; + /* Always allow crashlog. Telemetry, only when powered */ + switch (cap_type) { + case CRASHLOG: + xe_pm_runtime_get(xe); + break; + case TELEMETRY: + if (!xe_pm_runtime_get_if_active(xe)) + return -ENODATA; + break; + case WATCHER: + return -EINVAL; + } scoped_guard(mutex, &xe->pmt.lock) { /* set SoC re-mapper index register based on GUID memory region */ -- 2.43.0