From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44FE9C982E1 for ; Fri, 18 Sep 2026 13:18:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3E4310F380; Fri, 18 Sep 2026 13:18:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WtZZ+IMF"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id E02E310F380 for ; Fri, 18 Sep 2026 13:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789737487; x=1821273487; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=LPGG504LJ3vrcENFvlBo/VSFE0LKRYZg7u6iUu7Y6Hs=; b=WtZZ+IMFA3D78FqIlKNJ/RYiQER6EuJo8pautrF0SsZsRuQ19Cignqm9 toXfId1inUepINgosYFe282HC2nEyTH2wpMMCPQVOJrXvg1lMhBsPU20Y 8sm6LCPzGGjmsXHoo81UafvX1zST+k9I5mNq+s+QkHP+HzmNCqZdbm1bf d7DAQmNWnchmLbBmfd5tW82dzcMz2bfPWxAJDsRNpBj4k2/bvrOWqpnJG Tlt8MH8Fazu1mzd1l9abiyff52hJ7WIrKSlpZN95mRKIzrwuAeUNRk0KP gfhqYRLt5ZM0oDnBRfkZcBpojFA0gY9n08B27Hc5Uo+1UN+ANykEEzob+ Q==; X-CSE-ConnectionGUID: nBQL3+X3SWGZgo4/k2jpZg== X-CSE-MsgGUID: bKqCVZgYRb2IcscuAYYTMQ== X-IronPort-AV: E=McAfee;i="6800,10657,11908"; a="89378260" X-IronPort-AV: E=Sophos;i="6.27,109,1787036400"; d="scan'208";a="89378260" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2026 06:18:03 -0700 X-CSE-ConnectionGUID: qF2s6mKuSkK+olOtFocycA== X-CSE-MsgGUID: uixn2awpRjeHHM/lMlVZOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,109,1787036400"; d="scan'208";a="270095342" Received: from mjruhl-vm.amr.corp.intel.com ([10.11.186.166]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2026 06:18:02 -0700 From: "Michael J. Ruhl" To: platform-driver-x86@vger.kernel.org, intel-xe@lists.freedesktop.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com, anoop.c.vijay@intel.com, badal.nilawar@intel.com, matthew.d.roper@intel.com, james.ausmus@intel.com, karthik.poosa@intel.com Subject: [PATCH v10 12/20] drm/xe/vsec: Update VSEC probe order Date: Fri, 18 Sep 2026 06:18:03 -0700 Message-ID: <20260918131751.2408883-34-michael.j.ruhl@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260918131751.2408883-22-michael.j.ruhl@intel.com> References: <20260918131751.2408883-22-michael.j.ruhl@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Both debugfs and hwmon access the PMT data area before PMT is initialized. Hardwired offset usage allows this to work by accident. Upcoming changes will break this usage. Re-order the probe steps to initialize VSEC before the other features are initialized. Reviewed-by: Rodrigo Vivi Signed-off-by: Michael J. Ruhl --- drivers/gpu/drm/xe/xe_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index 205cb4e7f9e8..3ec950606e67 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -1053,6 +1053,8 @@ int xe_device_probe(struct xe_device *xe) if (err) goto err_unregister_display; + xe_vsec_init(xe); + xe_debugfs_register(xe); err = xe_hwmon_register(xe); @@ -1066,8 +1068,6 @@ int xe_device_probe(struct xe_device *xe) for_each_gt(gt, xe, id) xe_gt_sanitize_freq(gt); - xe_vsec_init(xe); - err = xe_sriov_init_late(xe); if (err) goto err_unregister_display; -- 2.43.0