Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Michal Wajdeczko" <michal.wajdeczko@intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Tales A . Mendonça" <talesam@gmail.com>
Subject: [PATCH] drm/xe: Add and use TLBINVAL component
Date: Tue, 22 Sep 2026 19:19:11 +0200	[thread overview]
Message-ID: <20260922171911.500-1-michal.wajdeczko@intel.com> (raw)

Replace the existing TLB invalidation error message with a new one
based on the xe_log_err() macro and use the dedicated TLBINVAL log
component.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Tales A. Mendonça <talesam@gmail.com>
---
 drivers/gpu/drm/xe/abi/xe_log_abi.h | 1 +
 drivers/gpu/drm/xe/xe_tlb_inval.c   | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/abi/xe_log_abi.h b/drivers/gpu/drm/xe/abi/xe_log_abi.h
index 526aadf85fe9..adb3c2128251 100644
--- a/drivers/gpu/drm/xe/abi/xe_log_abi.h
+++ b/drivers/gpu/drm/xe/abi/xe_log_abi.h
@@ -145,6 +145,7 @@ enum xe_log_location_bits {
 	define(DRIVER, 5, WA, SW, "Workarounds")				\
 	define(DRIVER, 6, PAGEFAULT, MEM_FAULT, "Page Fault")			\
 	define(DRIVER, 7, GUCSUBMIT, GT_TDR, "GuC Submission")			\
+	define(DRIVER, 8, TLBINVAL, GT_TDR, "TLB Invalidation")			\
 	/* */									\
 	define(DRIVER_HARDWARE, 1, REGS, IO_BUS, "Registers")			\
 	define(DRIVER_HARDWARE, 2, GGTT, IO_BUS, "Global GTT")			\
diff --git a/drivers/gpu/drm/xe/xe_tlb_inval.c b/drivers/gpu/drm/xe/xe_tlb_inval.c
index dd1030de9ab6..da629d410829 100644
--- a/drivers/gpu/drm/xe/xe_tlb_inval.c
+++ b/drivers/gpu/drm/xe/xe_tlb_inval.c
@@ -11,6 +11,7 @@
 #include "xe_gt_types.h"
 #include "xe_guc_ct.h"
 #include "xe_guc_tlb_inval.h"
+#include "xe_log.h"
 #include "xe_mmio.h"
 #include "xe_pm.h"
 #include "xe_tlb_inval.h"
@@ -86,9 +87,8 @@ static void xe_tlb_inval_fence_timeout(struct work_struct *work)
 			break;
 
 		trace_xe_tlb_inval_fence_timeout(xe, fence);
-		drm_err(&xe->drm,
-			"TLB invalidation fence timeout, seqno=%d recv=%d",
-			fence->seqno, tlb_inval->seqno_recv);
+		xe_log_err(xe, TLBINVAL, -ETIME, "fence timeout, seqno=%d recv=%d",
+			   fence->seqno, tlb_inval->seqno_recv);
 
 		fence->base.error = -ETIME;
 		xe_tlb_inval_fence_signal(fence);
-- 
2.47.1


             reply	other threads:[~2026-09-22 17:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 17:19 Michal Wajdeczko [this message]
2026-09-22 18:58 ` ✓ CI.KUnit: success for drm/xe: Add and use TLBINVAL component Patchwork
2026-09-22 19:22 ` [PATCH] " Summers, Stuart
2026-09-23 16:39   ` Michal Wajdeczko
2026-09-23 17:49     ` Summers, Stuart
2026-09-22 21:05 ` ✗ Xe.CI.BAT: failure for " Patchwork
2026-09-23  8:59 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922171911.500-1-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=talesam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox