From: Austin Hu <austin.hu@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, maarten.lankhorst@linux.intel.com,
vinod.govindapillai@intel.com, huchao426@gmail.com
Subject: [PATCH v4 0/3] drm/i915/fbc: Dirty rectangle bounding and CFB
Date: Fri, 25 Sep 2026 10:36:55 -0700 [thread overview]
Message-ID: <20260925173658.1042048-1-austin.hu@intel.com> (raw)
This series updates Intel FBC dirty rectangle handling and refactors plane
update checks:
1. Moves intel_fbc_can_flip_nuke() higher up in intel_fbc.c to avoid a
forward declaration in subsequent FBC checks. (No functional change)
2. Clamps FBC dirty rectangle bounds to valid surface limits [y_offset,
y_end] and adds logging for out-of-bounds coordinates, including
handling for 180-degree plane rotation.
3. Tracks plane state attribute changes during atomic commits. When FBC
Dirty Rectangle mode is active, partial updates only apply to surface
address changes (PLANE_SURF). Modifications to any other plane state
parameters require fetching full-plane pixel data from memory to
re-compress and update the entire CFB in stolen memory. Once fully
re-compressed, subsequent atomic commits can resume selective dirty
rectangle updates.
v3 -> v4 changes:
- Rebased onto latest drm-tip.
v2 -> v3 changes:
- Split function reordering into a separate standalone commit (v3 1/3) to
avoid mixing movement and functional changes, per maintainer feedback.
- Rebased onto latest drm-tip.
v1 -> v2 changes:
- Reused intel_fbc_can_flip_nuke() for plane update state checks as
suggested.
- Added plane Y-coordinate plane view checking (color_plane[0].y)
alongside X.
Austin Hu (2):
drm/i915/display/fbc: Move intel_fbc_can_flip_nuke() higher up
drm/i915/fbc: nuke CFB if Plane setting (except for surf addr) changes
Charlton Lin (1):
drm/i915/fbc: fbc_dirty_rect restrictions and logging
drivers/gpu/drm/i915/display/intel_fbc.c | 192 +++++++++++++++++------
1 file changed, 141 insertions(+), 51 deletions(-)
--
2.34.1
next reply other threads:[~2026-09-25 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 17:36 Austin Hu [this message]
2026-09-25 17:36 ` [PATCH v4 1/3] drm/i915/display/fbc: Move intel_fbc_can_flip_nuke() higher up Austin Hu
2026-09-25 17:36 ` [PATCH v4 2/3] drm/i915/fbc: fbc_dirty_rect restrictions and logging Austin Hu
2026-09-25 17:52 ` sashiko-bot
2026-09-25 17:36 ` [PATCH v4 3/3] drm/i915/fbc: nuke CFB if Plane setting (except for surf addr) changes Austin Hu
2026-09-25 17:55 ` sashiko-bot
2026-09-25 19:00 ` ✓ CI.KUnit: success for drm/i915/fbc: Dirty rectangle bounding and CFB Patchwork
2026-09-25 19:41 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-26 4:54 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925173658.1042048-1-austin.hu@intel.com \
--to=austin.hu@intel.com \
--cc=huchao426@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox