From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A257ACA5FA1 for ; Mon, 28 Sep 2026 09:24:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C1A010E905; Mon, 28 Sep 2026 09:24:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WuBsPkj5"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B00D10E840 for ; Mon, 28 Sep 2026 09:24:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790587448; x=1822123448; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=55vIJkDrk3uhiQfLkl3mGz9jnqeuC8cnGy9tDQEH5p0=; b=WuBsPkj5YuevuvHYrBIMpK7TjtBFYqZMTEGWyUcd6Akk5h7vajgYErLA y/m+GZBtLbD75t7puDoxPQqyk3iws/KfJCDAGcvcRm0tEkavJp2eq4Lj+ EdNrOssQZEdhYKvkY2KX+DDTA+qLHZ1Y4LUHXoFg9vs49zPBe1ly++1kG uo6bHv06iCrtykjigaFkrBmOt5CNh2pl/fG7QDZRX7JpFFRac1AKrWcaY velkDoLaFHZQCHJ5Grko16TEWbPu9pM5qmIDjJ+lNXvLL//QJgniAc7xv 7HPjGp3lW+crMiOWt7YhKk+x4FVg7Esm6eLhM6kzXqwUPoB2Zzg5Ei7ZM g==; X-CSE-ConnectionGUID: jyxm47kGSFKMGvoy+0jPkg== X-CSE-MsgGUID: dOu2QQ7WQNWLzQCaQ1/qBQ== X-IronPort-AV: E=McAfee;i="6800,10657,11918"; a="78845477" X-IronPort-AV: E=Sophos;i="6.27,128,1787036400"; d="scan'208";a="78845477" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2026 02:22:20 -0700 X-CSE-ConnectionGUID: FU5aAaZASp+vDeyx6nFIjQ== X-CSE-MsgGUID: PJrgDlRRRimmiUrVvOA9Cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,128,1787036400"; d="scan'208";a="283078031" Received: from dbhadane-mobl1.iind.intel.com ([10.190.239.58]) by fmviesa005.fm.intel.com with ESMTP; 28 Sep 2026 02:21:25 -0700 From: Dnyaneshwar Bhadane To: intel-xe@lists.freedesktop.org Cc: michal.wajdeczko@intel.com, mallesh.koujalagi@intel.com, Dnyaneshwar Bhadane Subject: [PATCH v4 06/12] drm/xe/reg_sr: Report save-restore errors using structured xe_log API Date: Mon, 28 Sep 2026 14:51:08 +0530 Message-ID: <20260928092114.1610203-7-dnyaneshwar.bhadane@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260928092114.1610203-1-dnyaneshwar.bhadane@intel.com> References: <20260928092114.1610203-1-dnyaneshwar.bhadane@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Replace xe_gt_notice() and xe_gt_err() calls with xe_log_info() and xe_log_err() using the REGS and RTP component tag for register save-restore operations: - Failed to add register to save-restore list - Force-wake timeout during SR apply Signed-off-by: Dnyaneshwar Bhadane --- v2: - Drop error type from logging explicitly (Mallesh). v3: - Drop config mismatch log (Michal) - Replace RTP instead of REG_SR (Michal) --- --- drivers/gpu/drm/xe/xe_reg_sr.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_reg_sr.c b/drivers/gpu/drm/xe/xe_reg_sr.c index e328f5072557..eab84a528d12 100644 --- a/drivers/gpu/drm/xe/xe_reg_sr.c +++ b/drivers/gpu/drm/xe/xe_reg_sr.c @@ -21,6 +21,7 @@ #include "xe_gt_printk.h" #include "xe_gt_types.h" #include "xe_hw_engine_types.h" +#include "xe_log.h" #include "xe_lrc.h" #include "xe_mmio.h" #include "xe_rtp_types.h" @@ -87,15 +88,15 @@ static struct xe_reg sanitize_mcr(struct xe_reg_sr *sr, if (is_mcr && !reg.mcr) { reg.mcr = 1; - xe_gt_notice(gt, "xe_reg_sr_entry using non-MCR register for address 0x%x, forcing MCR\n", - reg.addr); + xe_log_info(gt, RTP, "xe_reg_sr_entry using non-MCR register for address 0x%x, forcing MCR\n", + reg.addr); reg_sr_inc_error(sr); } if (!is_mcr && reg.mcr) { reg.mcr = 0; - xe_gt_notice(gt, "xe_reg_sr_entry using MCR register for address 0x%x, forcing non-MCR\n", - reg.addr); + xe_log_info(gt, RTP, "xe_reg_sr_entry using MCR register for address 0x%x, forcing non-MCR\n", + reg.addr); reg_sr_inc_error(sr); } @@ -219,7 +220,7 @@ void xe_reg_sr_apply_mmio(struct xe_reg_sr *sr, struct xe_gt *gt) CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FORCEWAKE_ALL); if (!xe_force_wake_ref_has_domain(fw_ref.domains, XE_FORCEWAKE_ALL)) { - xe_gt_err(gt, "Failed to apply, err=-ETIMEDOUT\n"); + xe_log_err(gt, REGS, -ETIMEDOUT, "Failed to apply\n"); return; } -- 2.54.0