From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20059CA5FF0 for ; Mon, 5 Oct 2026 23:52:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB78A10E1AE; Mon, 5 Oct 2026 23:52:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D/wgO1Nb"; dkim-atps=neutral Received: from mail-dl2-f43.google.com (mail-dl2-f43.google.com [74.125.229.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 693E710E0AD for ; Sat, 3 Oct 2026 19:45:56 +0000 (UTC) Received: by mail-dl2-f43.google.com with SMTP id a92af1059eb24-1431a73fa1eso73207c88.0 for ; Sat, 03 Oct 2026 12:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791056755; x=1791661555; darn=lists.freedesktop.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ISE+mo7r1uUwttxvds437VY6sRXQ56bmLHvCs31sIMg=; b=D/wgO1Nb4Skfse6GPaEDtj1hjVqiVHC7pJ0royTAFEBTKs67tDwV7ZVxwlRPbU2o8H 6X0r1tAapIOlrDzh2fC/n08TMOJHxupZFe14RaQZMOrXTFqjVLz28DqhZfEaeXgYjvps +x3wCLqAin8LGlhuM6e0VPmagFD0lyALsEn1cDzrZ0HnpYOdexO8a6dyzpudWndKl6Y9 94LE8WKe0abR/uQgZPkBo06LekaWUBS+2pPh1eF5jp5pQ8bwwXhgt/tigQrNO2956rUn on5DpzzGWbrw0hOAftWOM8IBblGEfDOHcrGEwyEzRpJt+SzTVJLWjYUNyeIzu3JzlYni CerQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791056755; x=1791661555; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ISE+mo7r1uUwttxvds437VY6sRXQ56bmLHvCs31sIMg=; b=YUdPwqGodvRm5og0hNkhxJMBiM8VMU6AnTOC8S4PZwEfJsqNfIcpjO13DpNjjVV60l FriFLEj5vwL9IKwayJJuLU6KjyyXKNX//gKRdSQf3ypMBl+5B0AmbzWKX1WML9Itp31g 8e+VHCGaAJpEWKE32lD81tqHQuSHO5v9Kzdq76VjVMkbUEUuV68n5j7u2Lcg+hdAOBps tH8eDnzcQfr6d+JM3WRcbQ1veJS9gRQmdZPfdlwQ8fG687tXX2DDYIU2twCfs2lGQfyb 7+Fkz89zLY/3+PPrE7PzCzO+TYpLiGb+NQNGe0zLjNEzHppIQxXMRbztfGKjkSeSdow1 qv5g== X-Gm-Message-State: AFuF++np4bprWEy61JuwZ07/mYP2vWgdktsI+mnuwiS2/K3ZwdFAYYLS /eiPo35J7u7+XOuJijJ0dxp1xdEysA4eGPxKPK+/QOH2celFuuJJqIp/ X-Gm-Gg: AYBFou3kXa+delQWYtHaLyrsgDERIcRhGDD+mjHubjL2LtPdRKZh0UOE5OhvmRnSMK2 1jAKmRPhXa30cBYT7NTfsLi7r3CyVy6SvsfX7SsCLK6/NznxOPmcu80fRb1Mr7Zv2UFh85girgi DuARWK3g7swB9UKp9p9UUepBwh/k5pDuMBCCaWFmH+8RstZjaepfDYbdwZMv+SQ2HwVhdpjDM0a Nvqh9kvzeG4kg3nwYEpMYyCnqSgH6WQFHKjCglKbAFsoUbSSfZ6619FiWiemK9+CIEvaoWvCh+C mwKRN1g62nliqrx4JtpUAoTXPkcGqre36iMFAHnluEu3JSdbMxLTtpcqC0aIH5pG3UsKuycsJj9 qJu6Ltk45gXTRKefCIxkfCVRwDhDZFM7i4CXH6aOtZIaomSCz2oJ7iwGCTjzNDAy25hTHL5m0hq oDF+ZbzyEv2abOY0clADxhvFePrrvFNLdwUCYCrPWBNf2TZNqukzbNczLNPjDH3h232ZIfYOSOU tr/SwY5S5+o3E18G103zhz3FodTUmER5KclerNMSO17mMmYjV6rfQOPsJ01Uj0nG+h0POHGsPYT /dGuNzgB+gv3yv99pv8= X-Received: by 2002:a05:7022:6896:b0:147:d430:7322 with SMTP id a92af1059eb24-14f5a646964mr15623345c88.1.1791056755448; Sat, 03 Oct 2026 12:45:55 -0700 (PDT) Received: from cachyos-aura ([45.112.148.98]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-34f14f660f1sm17840932eec.13.2026.10.03.12.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2026 12:45:54 -0700 (PDT) From: Navon John Lukose To: =?UTF-8?q?Tales=20A=2E=20Mendon=C3=A7a?= Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, Matt Roper Subject: Re: [PATCH v1 2/4] drm/xe/mcr: Sanitize steering semaphore on GT resume Date: Sun, 4 Oct 2026 01:15:48 +0530 Message-ID: <20261003194548.14603-1-navonjohnlukose@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20260722004654.744249-3-talesam@gmail.com> References: <20260722004654.744249-1-talesam@gmail.com> <20260722004654.744249-3-talesam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 05 Oct 2026 23:52:45 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 21 Jul 2026 21:46:52 -0300, Tales A. Mendonça wrote: > Port that to xe: release the steering semaphore at the start of > xe_gt_resume(), before the first MCR access performed by > do_gt_restart(). Tested on an ARL-H 7d51 (Lenovo Yoga Pro 7 14IAH10). Without this patch, 7.2.8 hits the drm_WARN_ON_ONCE in mcr_lock() on the first s2idle resume of every boot, lid open or closed. With this patch on the same 7.2.8 build, without 1/4, the first resume no longer warns. Later resumes can't show the _ONCE WARN anyway, but a debug read of STEER_SEMAPHORE just before the release found GT1's semaphore held on both resumes of that boot and GT0's free, so the release is what fixes it. xe_gt_resume() already holds XE_FORCEWAKE_ALL at that point, so the forcewake in 1/4 isn't needed for this WARN. Tested-by: Navon John Lukose