Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Kumar, Sachin" <sachin.kumar@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com, matthew.brost@intel.com, "Kumar,
	Sachin" <sachin.kumar@intel.com>,
	Kumar@freedesktop.org
Subject: [PATCH] drm/xe/uc: Add missing HuC firmware entry for Alderlake-N
Date: Mon,  5 Oct 2026 13:45:49 +0530	[thread overview]
Message-ID: <20261005081549.1594153-1-sachin.kumar@intel.com> (raw)

ALDERLAKE_N is listed in XE_GUC_FIRMWARE_DEFS but was missing from
XE_HUC_FIRMWARE_DEFS, so uc_fw_auto_select() never finds a HuC blob
for this platform. xe_huc_init() then silently treats HuC as
XE_UC_FIRMWARE_NOT_SUPPORTED and returns early with no log output,
so the gap is invisible in dmesg.

Media encode that depend on HuC (e.g. VP9 VDEnc BRC/header
probability update) assume HuC is available and still program
HuC-dependent HCP/VDEnc commands for the VDBOX engine. With HuC
firmware never loaded/authenticated, the first such command stalls
the only VCS engine on this single-VDBOX GT1 part, which shows up as:

xe 0000:00:02.0: [drm] Tile0: GT0: Engine memory CAT error: class=vcs ...
xe 0000:00:02.0: [drm] *ERROR* Tile0: GT0: GuC engine reset request failed

reproducing on every run, on the very first VP9 keyframe, at both
1080p and 4K. H264 encode is unaffected since this driver's AVC VDEnc
path does not depend on HuC. ADL-P/ADL-S/RKL/TGL are unaffected since
they already have a HuC table entry.

Note i915 never hit this: i915 has no distinct ALDERLAKE_N platform
at the GT/firmware level (ADL-N is only a display subplatform of
ALDERLAKE_P there), so it inherits TIGERLAKE's HuC blob automatically.
xe gives ALDERLAKE_N its own top-level platform enum, so it needs its
own explicit table row.

Fix by adding ALDERLAKE_N to XE_HUC_FIRMWARE_DEFS, reusing the same
"tgl" HuC blob already used by ALDERLAKE_P/ALDERLAKE_S/ROCKETLAKE/
TIGERLAKE, which share the identical Gen12/TGL-LP media IP block.

Fixes: 500f90620cce ("drm/xe/adln: Enable ADL-N")

Signed-off-by: Kumar, Sachin <sachin.kumar@intel.com>
---
 drivers/gpu/drm/xe/xe_uc_fw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
index a8e6f18cc9b4..80f657ada0ac 100644
--- a/drivers/gpu/drm/xe/xe_uc_fw.c
+++ b/drivers/gpu/drm/xe/xe_uc_fw.c
@@ -134,6 +134,7 @@ struct fw_blobs_by_type {
 	fw_def(LUNARLAKE,	GT_TYPE_ANY,	no_ver(xe,	huc,		lnl))		\
 	fw_def(METEORLAKE,	GT_TYPE_ANY,	no_ver(i915,	huc_gsc,	mtl))		\
 	fw_def(DG1,		GT_TYPE_ANY,	no_ver(i915,	huc,		dg1))		\
+	fw_def(ALDERLAKE_N,	GT_TYPE_ANY,	no_ver(i915,	huc,		tgl))		\
 	fw_def(ALDERLAKE_P,	GT_TYPE_ANY,	no_ver(i915,	huc,		tgl))		\
 	fw_def(ALDERLAKE_S,	GT_TYPE_ANY,	no_ver(i915,	huc,		tgl))		\
 	fw_def(ROCKETLAKE,	GT_TYPE_ANY,	no_ver(i915,	huc,		tgl))		\
-- 
2.43.0


             reply	other threads:[~2026-10-05  8:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05  8:15 Kumar, Sachin [this message]
2026-10-05  8:32 ` ✓ CI.KUnit: success for drm/xe/uc: Add missing HuC firmware entry for Alderlake-N Patchwork
2026-10-05  9:23 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-05 11:59 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005081549.1594153-1-sachin.kumar@intel.com \
    --to=sachin.kumar@intel.com \
    --cc=Kumar@freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox