From: Daniel Charles <daniel.charles@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: x.wang@intel.com, jia.yao@intel.com, jonathan.cavitt@intel.com,
matthew.brost@intel.com,
Daniel Charles <daniel.charles@intel.com>
Subject: [PATCH v2 0/3] FD close cleanup for XE
Date: Tue, 13 Oct 2026 13:15:05 -0700 [thread overview]
Message-ID: <20261013201508.514480-1-daniel.charles@intel.com> (raw)
This series adds the suggested logic to synchronously wait for the queue
kill to complete on FD close. This is needed to avoid a race condition
where the scheduler may still be processing messages for a queue that
has been closed, which can lead to errors.
This series includes a rebase of patch
fe73d8e1cdfac drm/xe: Disable scheduling early on FD close to avoid CAT error cascade
v2:
- Bound the wait with a timeout, GT reset on timeout (Sashiko, Matt B)
- Drop the flush_work() loop (Matt B)
- Use xe_assert() for the killed-queue check (Matt B)
- Merge the put loop into the kill_sync loop (Matt B)
Daniel Charles (1):
drm/xe: Synchronously wait for queue kill on FD close
Matthew Brost (2):
drm/xe: Read scheduler message opcode under lock
drm/xe: Disable scheduling early on FD close to avoid CAT error
cascade
drivers/gpu/drm/xe/xe_device.c | 5 ++
drivers/gpu/drm/xe/xe_exec_queue.c | 13 ++++
drivers/gpu/drm/xe/xe_exec_queue.h | 1 +
drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 +
drivers/gpu/drm/xe/xe_gpu_scheduler.c | 13 +++-
drivers/gpu/drm/xe/xe_gpu_scheduler_types.h | 2 +-
drivers/gpu/drm/xe/xe_guc_exec_queue_types.h | 2 +-
drivers/gpu/drm/xe/xe_guc_submit.c | 79 ++++++++++++++++++--
8 files changed, 104 insertions(+), 13 deletions(-)
--
2.43.0
next reply other threads:[~2026-10-13 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 20:15 Daniel Charles [this message]
2026-10-13 20:15 ` [PATCH v2 1/3] drm/xe: Read scheduler message opcode under lock Daniel Charles
2026-10-13 20:32 ` sashiko-bot
2026-10-13 20:15 ` [PATCH v2 2/3] drm/xe: Disable scheduling early on FD close to avoid CAT error cascade Daniel Charles
2026-10-13 20:15 ` [PATCH v2 3/3] drm/xe: Synchronously wait for queue kill on FD close Daniel Charles
2026-10-13 21:03 ` sashiko-bot
2026-10-13 20:40 ` ✗ CI.checkpatch: warning for FD close cleanup for XE (rev2) Patchwork
2026-10-13 20:43 ` ✓ CI.KUnit: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013201508.514480-1-daniel.charles@intel.com \
--to=daniel.charles@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jia.yao@intel.com \
--cc=jonathan.cavitt@intel.com \
--cc=matthew.brost@intel.com \
--cc=x.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox