From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>,
Tejas Upadhyay <tejas.upadhyay@intel.com>
Subject: [PATCH 1/2] drm/xe/pat: initialise pat.valid everywhere
Date: Thu, 15 Oct 2026 10:55:18 +0100 [thread overview]
Message-ID: <20261015095516.403932-5-matthew.auld@intel.com> (raw)
In-Reply-To: <20261015095516.403932-4-matthew.auld@intel.com>
We were only doing this for xe2+. However, having a central way
to determine if any index is reserved/valid will be useful later.
Currently we abuse checking coh_mode, which is a bit of a hack and can
be confusing.
Assisted-by: LLM
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
drivers/gpu/drm/xe/xe_pat.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
index 3dfcd364ac67..d1ba2325d9e2 100644
--- a/drivers/gpu/drm/xe/xe_pat.c
+++ b/drivers/gpu/drm/xe/xe_pat.c
@@ -94,29 +94,29 @@ struct xe_pat_ops {
};
static const struct xe_pat_table_entry xelp_pat_table[] = {
- [0] = { XELP_PAT_WB, XE_COH_1WAY },
- [1] = { XELP_PAT_WC, XE_COH_NONE },
- [2] = { XELP_PAT_WT, XE_COH_NONE },
- [3] = { XELP_PAT_UC, XE_COH_NONE },
+ [0] = { XELP_PAT_WB, XE_COH_1WAY, 1 },
+ [1] = { XELP_PAT_WC, XE_COH_NONE, 1 },
+ [2] = { XELP_PAT_WT, XE_COH_NONE, 1 },
+ [3] = { XELP_PAT_UC, XE_COH_NONE, 1 },
};
static const struct xe_pat_table_entry xehpc_pat_table[] = {
- [0] = { XELP_PAT_UC, XE_COH_NONE },
- [1] = { XELP_PAT_WC, XE_COH_NONE },
- [2] = { XELP_PAT_WT, XE_COH_NONE },
- [3] = { XELP_PAT_WB, XE_COH_1WAY },
- [4] = { XEHPC_PAT_CLOS(1) | XELP_PAT_WT, XE_COH_NONE },
- [5] = { XEHPC_PAT_CLOS(1) | XELP_PAT_WB, XE_COH_1WAY },
- [6] = { XEHPC_PAT_CLOS(2) | XELP_PAT_WT, XE_COH_NONE },
- [7] = { XEHPC_PAT_CLOS(2) | XELP_PAT_WB, XE_COH_1WAY },
+ [0] = { XELP_PAT_UC, XE_COH_NONE, 1 },
+ [1] = { XELP_PAT_WC, XE_COH_NONE, 1 },
+ [2] = { XELP_PAT_WT, XE_COH_NONE, 1 },
+ [3] = { XELP_PAT_WB, XE_COH_1WAY, 1 },
+ [4] = { XEHPC_PAT_CLOS(1) | XELP_PAT_WT, XE_COH_NONE, 1 },
+ [5] = { XEHPC_PAT_CLOS(1) | XELP_PAT_WB, XE_COH_1WAY, 1 },
+ [6] = { XEHPC_PAT_CLOS(2) | XELP_PAT_WT, XE_COH_NONE, 1 },
+ [7] = { XEHPC_PAT_CLOS(2) | XELP_PAT_WB, XE_COH_1WAY, 1 },
};
static const struct xe_pat_table_entry xelpg_pat_table[] = {
- [0] = { XELPG_PAT_0_WB, XE_COH_NONE },
- [1] = { XELPG_PAT_1_WT, XE_COH_NONE },
- [2] = { XELPG_PAT_3_UC, XE_COH_NONE },
- [3] = { XELPG_PAT_0_WB | XELPG_2_COH_1W, XE_COH_1WAY },
- [4] = { XELPG_PAT_0_WB | XELPG_3_COH_2W, XE_COH_2WAY },
+ [0] = { XELPG_PAT_0_WB, XE_COH_NONE, 1 },
+ [1] = { XELPG_PAT_1_WT, XE_COH_NONE, 1 },
+ [2] = { XELPG_PAT_3_UC, XE_COH_NONE, 1 },
+ [3] = { XELPG_PAT_0_WB | XELPG_2_COH_1W, XE_COH_1WAY, 1 },
+ [4] = { XELPG_PAT_0_WB | XELPG_3_COH_2W, XE_COH_2WAY, 1 },
};
/*
--
2.56.0
next prev parent reply other threads:[~2026-10-15 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 9:55 [PATCH 0/2] Improve hw reserved PAT checking Matthew Auld
2026-10-15 9:55 ` Matthew Auld [this message]
2026-10-15 13:29 ` [PATCH 1/2] drm/xe/pat: initialise pat.valid everywhere Upadhyay, Tejas
2026-10-15 9:55 ` [PATCH 2/2] drm/xe: revamp hw reserved PAT index checking Matthew Auld
2026-10-15 10:05 ` sashiko-bot
2026-10-15 10:16 ` Matthew Auld
2026-10-15 13:28 ` Upadhyay, Tejas
2026-10-15 10:03 ` ✓ CI.KUnit: success for Improve hw reserved PAT checking Patchwork
2026-10-15 16:49 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-15 22:42 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015095516.403932-5-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=tejas.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox