From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BCED606A336 for ; Thu, 19 Nov 2026 00:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=LyeyFeRW Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3488210FB85; Thu, 19 Nov 2026 00:09:48 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id D526910E2DD for ; Thu, 19 Nov 2026 00:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795046982; x=1826582982; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+y2scQ8FroZZociBVKzE6wdKbrJcbtA/ioWD1uCRSvk=; b=LyeyFeRWn9yOr0f5qeD8lbrbrx64c9xk5VWi62Bp8MyAgiDQt/w5ijCd ylJJn96PPOubOsO8nSYKNFdM2VMjTnFU2pmFFo3d9Tj7msoIenJwg1+yW TFj5I3BBErByz7tWK+9B9M0294nyK3qatDp5IBcVYIXJsjNp71uswnR1J RIT/eq2UWXnM9/Z6W6kUXyFBvd8KlPdG7PWMMne9NkQdD1+SAC8Rw+FI1 Fh5i6BQmLPZ/bFJdIMJgUunQTvHuqfH/oz2ssyiEEI9mmpvoUMMowklmw IhfHEfbTkGgJERxdavnlkb4HFC3CseJByroRX69uK/layUTW4MpcS18Rk A==; X-CSE-ConnectionGUID: AOlNLsxRTky3Sjob1qy2uA== X-CSE-MsgGUID: +K7JK/9sTimNvUHGwx0w7A== X-IronPort-AV: E=McAfee;i="6800,10657,11970"; a="3768593" X-IronPort-AV: E=Sophos;i="6.27,220,1787036400"; d="scan'208";a="3768593" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 16:09:41 -0800 X-CSE-ConnectionGUID: /1B72owqTKCdyKnJ4Q2yFg== X-CSE-MsgGUID: nmCMOpl9TQim2IGI332hiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,220,1787036400"; d="scan'208";a="10641156" Received: from danielcm-desk1.jf.intel.com ([10.24.81.120]) by fmviesa009.fm.intel.com with ESMTP; 18 Nov 2026 16:09:41 -0800 From: Daniel Charles To: intel-xe@lists.freedesktop.org Cc: x.wang@intel.com, jia.yao@intel.com, matthew.brost@intel.com, jonathan.cavitt@intel.com, Daniel Charles Subject: [PATCH v5 0/4] FD close cleanup for XE Date: Wed, 18 Nov 2026 16:04:42 -0800 Message-ID: <20261119000446.696147-1-daniel.charles@intel.com> X-Mailer: git-send-email 2.43.0 X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Intel-xe" X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On FD close, serialized TDR cleanup can lag behind VM teardown. GuC may continue scheduling contexts while their page tables are being torn down, leading to CAT errors and repeated engine resets. This series keeps the early scheduling disable outside the serialized TDR path and makes FD close wait before releasing queue references. FD close first kills all queues, then waits for each queue before dropping its reference. Changes since v4: - Patch 1 is unchanged. - Patch 2 adds per-queue scheduling-state waitqueues as a standalone prerequisite. SCHED_DONE wakes waiters on the affected queue after updating its state, without waking unrelated CT waiters. - Patch 3 restricts early group DISABLE to the primary's own KILL. It also allows pending disable on a killed queue in run_job and avoids issuing a second DISABLE from TDR if KILL already disabled scheduling. - Patch 4 requires a KILL acknowledgement before accepting a disabled scheduling state, so FD close cannot finish the wait before KILL runs. Multi-queue members wait for their primary's acknowledgement and scheduling state on its per-queue waitqueue, replacing the shared kill_wq from v4. v4: https://patchwork.freedesktop.org/series/175996/#rev4 Daniel Charles (2): drm/xe: Notify scheduling-state waiters per exec queue drm/xe: Synchronously wait for queue kill on FD close Matthew Brost (2): drm/xe: Read scheduler message opcode under lock drm/xe: Disable scheduling early on FD close to avoid CAT error cascade drivers/gpu/drm/xe/xe_device.c | 5 + drivers/gpu/drm/xe/xe_exec_queue.c | 13 ++ drivers/gpu/drm/xe/xe_exec_queue.h | 1 + drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 + drivers/gpu/drm/xe/xe_gpu_scheduler.c | 13 +- drivers/gpu/drm/xe/xe_gpu_scheduler_types.h | 2 +- drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 1 + drivers/gpu/drm/xe/xe_guc_exec_queue_types.h | 10 +- drivers/gpu/drm/xe/xe_guc_submit.c | 180 +++++++++++++++++-- drivers/gpu/drm/xe/xe_guc_submit.h | 1 + 10 files changed, 206 insertions(+), 22 deletions(-) -- 2.43.0