From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C6C8C98304 for ; Thu, 24 Sep 2026 00:14:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B355510E38B; Thu, 24 Sep 2026 00:14:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="U9/5ZkgP"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5828010E500 for ; Thu, 24 Sep 2026 00:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790208880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Arg2o/O+mZYGRcJkQWOkHlb3811XT5pVkK165f7ivAA=; b=U9/5ZkgPbYCtN1+4ge0FDjV/sz2P0mJ9Fj0/+93rjfMFXBVyZeacynftnPyfEq88s+mPFo jbuagEaUA+u85+dNI6cghYynYUTH34G9hdY7/mXnv22IPg4mwC2xgq2uE+AmjCF8WTffXu dHpl1mtFqEUq2u5hpvv2q7uDpS+8S6E= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-dero4FuhO3WeAwnpEJzrmA-1; Wed, 23 Sep 2026 20:14:39 -0400 X-MC-Unique: dero4FuhO3WeAwnpEJzrmA-1 X-Mimecast-MFC-AGG-ID: dero4FuhO3WeAwnpEJzrmA_1790208877 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-3a208b764f1so6331651fa.1 for ; Wed, 23 Sep 2026 17:14:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790208877; x=1790813677; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Arg2o/O+mZYGRcJkQWOkHlb3811XT5pVkK165f7ivAA=; b=cn4FKqTgwRN58YZJyk/V+WuEJ1GMN43xfvS+oaLELSHcnmU28xX1GYvaMfpjl1BVvi 6F9X3DHyGkEREeoPDQoSkYWKjMEQhoxOk8NH7ysr6kju2rhSgcfK1UqCimIHBMxPavYG M50mAO1GyE1jyle9CcfY+NbOgUJIqf4ml4F+UFSpS2ZvdjUE6xFamCitN4pqZeIVj0pb 0xtO0Tsyi7bTSewQatuNaQPuN3x8EEL/YL9M/IYn7n6Vob4qaIpqpqmWt+/OLieScT3V Wtl3odfr8l8efOESM0ELPUszwZ82zUJu8roGvokgkXeGOdQZ1pFVvmfsJpWYbu3KW6da +FNg== X-Forwarded-Encrypted: i=1; AKwUvBzO8vH+rIzjpcOv3ypudD4JiOBZbQs5YzButKiMRhpAY1+kwOBb6Sx66ZqWQCJFHes8uXfqT2sifg==@lists.freedesktop.org X-Gm-Message-State: AFuF++md+9O53ZwtXnIJL0/sihefcZXs8SbddvSq9wHzgDgzQ3P/MtFW TuPbciqwIbzS7CK+Xrww3PoeprqAecj5n7omYK+ShgaElrPTawI1Hl1I7j6/L/VnjXbqhRWdTaT drDd7nzEJOHToGxPg3KuWNGZDnglgKo4sbf7F5v6j+uP0AxchsTDPziLKKQ8SkBR34Io= X-Gm-Gg: AYBFou2UaH+EHaZOIzSltf1MmCodUS+h4f4VneYTxC4OGdmQ9Y809LoeF6HaMm9zOLn z6S8aK6oBQwABFGPD/gTnhTG5NsDKHfOz54BrkGw/CSSaQq2LibDkAFUOPXRtpfS92ShSsW6Huy FT63t27IO1iIFZse6T6jDk98cD6fWk/LTSPIhBrWWGt1TgTgOm2gxCbI5XQlYf98wYMNllaXClX evKvjjbUd7FTc8xkT/uQJ7pNG2VlK7UlefSZX8Cv9OD2dJ42rea1yF9cxBta0gH5l/lxA1L05d6 8ozdwP45Z2RfT8ZMT9mnGftrCjJr0m20MqczaZPcav7rGRHgMX+RU4iyz40W43z167fwHJoNDUE fhSa3RYUlMf7wc/B+E/l5kEpr8bRGlz8= X-Received: by 2002:a05:651c:15c4:20b0:3a3:7680:67f9 with SMTP id 38308e7fff4ca-3a63c2edc6amr1104531fa.24.1790208877414; Wed, 23 Sep 2026 17:14:37 -0700 (PDT) X-Received: by 2002:a05:651c:15c4:20b0:3a3:7680:67f9 with SMTP id 38308e7fff4ca-3a63c2edc6amr1104501fa.24.1790208876835; Wed, 23 Sep 2026 17:14:36 -0700 (PDT) Received: from [192.168.1.86] (89-27-86-246.bb.dnainternet.fi. [89.27.86.246]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a63bdbc5dfsm2340611fa.5.2026.09.23.17.14.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2026 17:14:36 -0700 (PDT) Message-ID: <205181b9-9677-4fcb-873c-732a503fabd9@redhat.com> Date: Thu, 24 Sep 2026 03:14:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/12] [PATCH v14 00/12] migrate on fault for device pages To: Jason Gunthorpe , Andrew Morton Cc: linux-mm@kvack.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Hildenbrand , Leon Romanovsky , Alistair Popple , Balbir Singh , Zi Yan , Matthew Brost , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko References: <20260922053421.4092027-1-mpenttil@redhat.com> <20260922192726.90dec3c4c77b8c9063dbf218@linux-foundation.org> <5b1d0fa6-d183-446e-bc52-56e0afd3f398@redhat.com> <20260923141936.d1f9e5b85355f0bdc6a6ecd2@linux-foundation.org> <20260923232402.GI2545495@nvidia.com> From: =?UTF-8?Q?Mika_Penttil=C3=A4?= In-Reply-To: <20260923232402.GI2545495@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Qc1SV_dmEUzvlq4OHQhDOy6Vwy4vghx3Jm_7sg-JSa0_1790208877 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 9/24/26 02:24, Jason Gunthorpe wrote: > On Wed, Sep 23, 2026 at 02:19:36PM -0700, Andrew Morton wrote: >> On Wed, 23 Sep 2026 08:29:34 +0300 Mika Penttilä wrote: >> >>>>> migration). It is also tricky to code correctly. One page table walk >>>>> could costs over 1000 cpu cycles on X86-64, which is a significant hit. >>>>> >>>>> We should be able to walk the page table once, faulting >>>>> pages in as required and replacing them with migration entries if >>>>> requested. >>>> Sounds sensible. >>>> >>>>> Tested in X86-64 VM with HMM test device, passing the selftests. >>>>> For performance, the migrate throughput tests from the selftests >>>>> show similar numbers (within error margin) as unmodified kernel. >>>> But no performance benefits are demonstrated? >>> There are no performance regressions for current tests. >>> Real benefits come if want to do migrate on fault. >>> For migrate on fault today missing pages are collected as not-present and >>> the caller has to fault them and re-run migrate_vma_setup(); folding >>> HMM_PFN_REQ_FAULT into the collecting walk removes that extra >>> fault+retry round-trip, dropping two page table walks. Page table walks >>> are not cheap. Not to mention simplified implementation for driver. >>> Also, the vma looked up as part of the walk is readily available for >>> migration, eliminating the need for explicit vma lookup - one more >>> performance benefit. Net effect two saved page table walks and >>> one vma lookup. >> It certainly sounds that this series will result in performance >> improvements, but have those improvements been quantified? >> >>> This series also addresses the vanished/reborn page table while >>> collecting problem which can crash current implementation. >> Oh. I didn't get that message from the v14 changelogs, and crashes in >> the current implementation are not what we want. In fact, addressing >> those is more important than speeding things up. > Yeah, what is this about? > > The series still has lots of sashiko remarks, are they legit? Some of them are legit some not. This was actually the first time sashiko managed to apply the series. I will address all the remarks in v15 soon. > > Jason --Mika >