Re: [PATCH] drm/{i915,xe}: driver agnostic drm to display pointer chase

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 26 Sep 2025, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Fri, Sep 26, 2025 at 02:10:32PM +0300, Jani Nikula wrote:
>>diff --git a/drivers/gpu/drm/i915/display/intel_display_conversion.c b/drivers/gpu/drm/i915/display/intel_display_conversion.c
>>index d56065f22655..9a47aa38cf82 100644
>>--- a/drivers/gpu/drm/i915/display/intel_display_conversion.c
>>+++ b/drivers/gpu/drm/i915/display/intel_display_conversion.c
>>@@ -1,15 +1,21 @@
>> // SPDX-License-Identifier: MIT
>> /* Copyright © 2024 Intel Corporation */
>>
>>-#include "i915_drv.h"
>>-#include "intel_display_conversion.h"
>>+#include <drm/intel/display_member.h>
>>
>>-static struct intel_display *__i915_to_display(struct drm_i915_private *i915)
>>-{
>>-	return i915->display;
>>-}
>>+#include "intel_display_conversion.h"
>>
>> struct intel_display *__drm_to_display(struct drm_device *drm)
>
> it seems like this could be inline in drm/intel/display_member.h
>
> Although it doesn't seem we have many calls to convert from drm to
> intel_display, so lgtm as is.

We actually do, lots and lots, via to_intel_display().

I thought about inlining, but decided to leave that for follow-up.

> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Thanks,
Jani.



-- 
Jani Nikula, Intel