Re: [82/86] drm/i915: Move custom hotplug code into separate callback

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 20.08.24 um 12:39 schrieb Sui Jingfeng:
>
>
> Besides, a lot of DRM driver instances has the DMA/2D acceleration 
> hardware, promote it
> into drm_driver structure may has the potential to utilize hardware 
> acceleration. Drivers
> will more easily to have custom implementation. I'm not 100% sure if 
> it will only be used
> by i915 in the future.

The correct place to do acceleration would be in the blit helpers in 
drm_format_helper.c. But no one bothered so far. For fbdev-only 
acceleration, DRM drivers could have custom fb_ops for accelerated 
drawing, copying, etc. Few cared and almost all removed that code at 
some point. The latest consent was that the complexity of the 
implementation outweights the performance gains. Even the few devs who 
actually asked for it didn't bother in the end.

Best regards
Thomas

>
> Best regards,
> Sui
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)