Re: [RFC PATCH v4 3/5] drm/xe: use xe_ras_log_wedged macro in xe_device_declare_wedged

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 06-07-2026 02:06 pm, Tauro, Riana wrote:
>
> On 30-06-2026 17:25, Mallesh Koujalagi wrote:
>> Replace the open-coded drm_err() call with xe_ras_log_wedged()
>> macro so that wedge events are reported through the unified
>> RAS/SIG logging path with a consistent format, CPER severity,
>> and errno.
>>
>> Signed-off-by: Mallesh Koujalagi<mallesh.koujalagi@intel.com>
>> ---
>> v2:
>> - Rebase.
>>
>> v3:
>> - Update message in xe_ras_log_wedged().
>>
>> v4:
>> - Replace XE_RAS_WEDGED to xe_ras_log_wedged. (Dnyaneshwar)
>> ---
>>   drivers/gpu/drm/xe/xe_device.c | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device.c 
>> b/drivers/gpu/drm/xe/xe_device.c
>> index b6e49309a99f..7538ac7c7dfb 100644
>> --- a/drivers/gpu/drm/xe/xe_device.c
>> +++ b/drivers/gpu/drm/xe/xe_device.c
>> @@ -62,6 +62,7 @@
>>   #include "xe_pxp.h"
>>   #include "xe_query.h"
>>   #include "xe_ras.h"
>> +#include "xe_ras_log.h"
>>   #include "xe_shrinker.h"
>>   #include "xe_soc_remapper.h"
>>   #include "xe_survivability_mode.h"
>> @@ -1428,12 +1429,12 @@ void xe_device_declare_wedged(struct 
>> xe_device *xe)
>>       if (!atomic_xchg(&xe->wedged.flag, 1)) {
>>           xe->needs_flr_on_fini = true;
>>           xe_pm_runtime_get_noresume(xe);
>> -        drm_err(&xe->drm,
>> -            "CRITICAL: Xe has declared device %s as wedged.\n"
>> -            "IOCTLs and executions are blocked.\n"
>> -            "For recovery procedure, refer 
>> tohttps://docs.kernel.org/gpu/drm-uapi.html#device-wedging\n"
>> -            "Please file a _new_ bug report 
>> athttps://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n",
>> -            dev_name(xe->drm.dev));
>> +        xe_ras_log_wedged(xe, -EIO,
>
> Error code is changed for wedged.
> Please take a look at this patch [PATCH v2 1/2] drm/xe/guc: 
> distinguish wedged from recoverable cancellation - Sk Anirban 
> <https://lore.kernel.org/intel-xe/20260624194618.2793571-5-sk.anirban@intel.com/>
>
Those patches are called 
after  xe_device_declare_wedged()-->xe_gt_declare_wedged()-->xe_uc_declare_wedged(), 
I need to take a look.

Thanks,

-/Mallesh

> Thanks
> Riana
>
>> +                  "CRITICAL: Xe has declared device %s as wedged.\n"
>> +                  "IOCTLs and executions are blocked.\n"
>> +                  "For recovery procedure, refer 
>> tohttps://docs.kernel.org/gpu/drm-uapi.html#device-wedging\n"
>> +                  "Please file a _new_ bug report 
>> athttps://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n",
>> +                  dev_name(xe->drm.dev));
>>       }
>>         for_each_gt(gt, xe, id)