From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9791BE7717F for ; Tue, 10 Dec 2024 18:07:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6352D10E2D4; Tue, 10 Dec 2024 18:07:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Z+JABr+V"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7938F10E16C for ; Tue, 10 Dec 2024 18:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733854032; x=1765390032; h=message-id:date:subject:to:references:from:in-reply-to: mime-version; bh=canPMlmwjLgfpHhr7rtACopjoyXiNzeTE1f5bsRo5Po=; b=Z+JABr+VX/1uQSJ0n4eK5OFg3SXzn120PE0+9QIhNfofF187yQEt7JNF SddJ6RzHquMfQ6LYXq34Qs9Ojqc168GxZGlEPhoAFTIfgLcsx62FolJ0o ANl3+lIixXuZZ8NpmSWOfSlsebw2AkHLBc+FumJ3S7dybuibsfHITqY5T i3yRTIZBmusAkr864Fb2DcWU7yr1FDGO4+Jj16O9wBxCVj5blXi8e+Uk6 eDq60aAGZe0gA6CNkkPCIFKUJoVWQD5l3IalUivXNxAQZMrtRXUFzOTa6 0nIHbVj1C8BlkkN8XNoWAUIzbWYvXHqPDrvdHkmagHxlLpm7hoV2DZMJP w==; X-CSE-ConnectionGUID: pWo/1vZbQle+g71Xp5WeJQ== X-CSE-MsgGUID: imSNMhNxS7+V/sPacwY/6g== X-IronPort-AV: E=McAfee;i="6700,10204,11282"; a="37046187" X-IronPort-AV: E=Sophos;i="6.12,223,1728975600"; d="scan'208,217";a="37046187" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2024 10:07:02 -0800 X-CSE-ConnectionGUID: 0DmlFXVCSqu6EfVy7/E9yw== X-CSE-MsgGUID: j35uiloITIWWABPRQGCOqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,223,1728975600"; d="scan'208,217";a="95686129" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Dec 2024 10:07:03 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Dec 2024 10:07:01 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 10 Dec 2024 10:07:01 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 10 Dec 2024 10:06:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VHaIRpUBr2R1UHq1Ki/FR5JZlxywrqv5MrfYg1YD2acjQAjg9gLGTjkdx3bKjp3dOj5wzUNilL6uxo5gafv9V/ABHkBm9hW39uE2TsT0nlk9Prxpjc27bnoLcVvPtucutgOXnjoxNAJSMD/PBJvEpy9lxDNEv5AL0CaMr2CXpB4ZhKGehbOH06348aMRjBsaF/KDCEGPMlc+ePRNaL78T230NUj6+pfbVrDkBuAtm97DMQ6n/+X7mfNQ13uNKXmOy/xHTgP278TomYSluTMSN6kf20Uw44IQ2Sk6FOgn8jLgLXXoiFyuSXVaHIRVqQezHIdDk0DX4VAk+3LgsMHd6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=COE9spd5XBUjROkfYceGFU557rtwrlSSoML5ZWBMkxk=; b=rsjYh52QtwHPuOX2DcZH/ZSNV/CwZwoG1Nmu2g4tg2vxSctkCMuP+XN5BuKS2flCcKeRWIiTvyvOkEl4UvErhyufQqjoMhvEC3Cq50BFUTZEE2pBX7wEQaM53zJYSB8Xt531ypBXtKpwRxqbFHksKX1z7N+JfPl6B9gPL92db8QuQjW96ik3QWgdE6Cf5SMoBJvTnqmp1ELdZw016f0iCSNYQKzwbNA76+n6SvwC+h852X+Y1ByS4zrG5xAoB8d4Kk+QP1MHhYy76TggAvs6nD1pNn1n9Cdq4r02urIs3fzTSdWMerMv2dKNZNp7xe6TAYR0chuJcBuYhvgGi74R/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SA1PR11MB7014.namprd11.prod.outlook.com (2603:10b6:806:2b9::15) by DM4PR11MB7399.namprd11.prod.outlook.com (2603:10b6:8:101::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.19; Tue, 10 Dec 2024 18:06:35 +0000 Received: from SA1PR11MB7014.namprd11.prod.outlook.com ([fe80::e707:2d60:2891:a02]) by SA1PR11MB7014.namprd11.prod.outlook.com ([fe80::e707:2d60:2891:a02%6]) with mapi id 15.20.8230.016; Tue, 10 Dec 2024 18:06:35 +0000 Content-Type: multipart/alternative; boundary="------------18baOScAE8unAmEfm8VJvYS0" Message-ID: <250aef2c-1a9c-4c2f-8aec-6c2b075ca323@intel.com> Date: Tue, 10 Dec 2024 20:06:30 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] drm/xe: Defer irq init until after xe_display_init_noaccel To: Maarten Lankhorst , References: <20241210083111.230484-1-dev@lankhorst.se> <20241210083111.230484-5-dev@lankhorst.se> Content-Language: en-US From: "Levi, Ilia" In-Reply-To: <20241210083111.230484-5-dev@lankhorst.se> X-ClientProxiedBy: TLZP290CA0001.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:9::14) To SA1PR11MB7014.namprd11.prod.outlook.com (2603:10b6:806:2b9::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB7014:EE_|DM4PR11MB7399:EE_ X-MS-Office365-Filtering-Correlation-Id: 931f6f0b-e5a8-4280-d578-08dd19456295 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|8096899003|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MTRrRTdvV0NlTE1ZbHlJN2svRHpuMnJTT1o2M0I0UThQY29XMzR6TDZVZXpz?= =?utf-8?B?QU1EM1grSGFDQnY2L2tzU1MwQzhmaVdyek0zU05nblloelhQTzdBWVJoUm9O?= =?utf-8?B?cm9HWWhzcFNwVjBNNERNamhBVjluUHNLN0VETElid3Z5L1ZpRmcwb3dxYTZq?= =?utf-8?B?cU5Vd3ZsR1BUbE9aQzhFa1k2c3dUdWxvcE0wdzF6aEJ5MmtDOTBNd1BBcDdG?= =?utf-8?B?a0wycld3TkthaUdDWVpWQ3c2cno4bWdGelphN1NtcGlXQnpQNmNXZzN0NjdY?= =?utf-8?B?c1ZDQm9tS2JHOHhLazUrOStERmxZY3kzc0NnVkFQUEdIZjBKY0l2R0Zuekk4?= =?utf-8?B?T2pQTE1ZaGtveFlwQTc5NXZGQ1ZxTzJNeDRhTjh1Vlp0NSs0dlc0anlyWkJh?= =?utf-8?B?M1FQS2lLN3BYamRDMElIWXRSMC9CakhJZ21GZWVKSW95VzNoSWljRmdDRUNq?= =?utf-8?B?ZTROMkdnNjRmUmsvWTVJdGF0YVAxZDV5NDJaYXV6NlpQSS9zS0YxT0k1WG5N?= =?utf-8?B?Z2NxWFN0VENtaDJCT1Fid2poNXpldkNtNFF6Z3FycGVib2R1eWRLcnBLdm5D?= =?utf-8?B?TnVtY1BKL2d0S0xLb1U5OGM5RmwxRFViWHVURFJRRHNEQzhmcmlIbzRYVnNp?= =?utf-8?B?YU1xZllDZXIxVGszYVBuSmlxRWtjSTFXMjRCbGkxQlBRU2hnbzNuWmdQdTQ2?= =?utf-8?B?QWtPRlc3cjVEa1NOaCs2aFFPaGwrRU1hbG9ERFNlWlBBZHVJd05odEQ5enhw?= =?utf-8?B?ZS9qTVFkYlRqSFVFek9IT00zM0c3SEpiQVRXSDdJSVhIQmxKcmxqelBHL3Qx?= =?utf-8?B?Y2ZTMkRmUk5qWmc0SlRWUGplMUZtTlRUMk1TcU1paGw4b2hxYjFjRy9PSGdo?= =?utf-8?B?bUpHV2gzNXNhTTdjU2YwSlYyUlFya2N1bExxQmd2bWlvUUtuQUlrWEdPbzJz?= =?utf-8?B?NkZHMjNrVEczbkUzaFVrTDc2ck53cUN0VnFPZ1QrN1o5SWpiS2FuNHhiZ1Fw?= =?utf-8?B?UHM3MEwrT0pzN2JVTFoxVVR4U1NSdkQ2SVBaM0lKZjBYejNRcFZGY1dDZmNP?= =?utf-8?B?aVg0UytUYld1YnFlOWIwYVcwbnVTcVNHd21TNXZ3SzNDT0YreDNYbCtlckYz?= =?utf-8?B?ZEtSRDBkTnU1WE5MQlNST0JGcm9VOUFHYW9hVFArV2RSVFNydXpkZlVhL2l3?= =?utf-8?B?cmdkc2ZEdzNYR1FRWk5xSWdBRDQ2WHU1dnVtSU91dHc4SFc1RDA5UitPTWF3?= =?utf-8?B?clowWmlWQnp4dE05cjBsS0dtanJ3cU5pVDN5SVExZFUxS1dWQ2xrSHhla1lB?= =?utf-8?B?cXdHanZmSXRNcHVTOEd6UjJPU003SDRMYVdRQjAxL214UXl4NkRFVEtoam5N?= =?utf-8?B?MXNGakhNTDZmd2dEb0FMRUg2ZFRGSEx6Wk1tT3NVUHo4Z052UTN3ZmJsbjMw?= =?utf-8?B?OXNKd0ZMb3l1MFpyTU5Razd5Zi9SMkFrakxDb3dJaWhaeGhvY0dQNDFodUEx?= =?utf-8?B?c0VSYWZCY1NmZVAzemZWOHJGN2p3U3NOZ21KOUFVRlM1WjdWUUcyejF3bGpX?= =?utf-8?B?MEpLTmtMczBIc0JuM3YwR3NtM2JDSzlHWFdzbWE2dUNSRXQwbzR4dXBNbUpE?= =?utf-8?B?UEh1aXgzRVJOYnF0UytyQng1QlF6K3dlSzJoUEJoS2NNU2hrWno5YXZDYkFO?= =?utf-8?B?alhKaStjOE5yTzkwejAzZGFva1h2ZURZMlFSY3VSREE1dnJzR3RKWGlNMVZu?= =?utf-8?B?RDJlZzNiVUd5eFltWnV2MlM2TEdmY21xdEQyZVRENnZkbjlNQytFU3hQK1RQ?= =?utf-8?B?ZWUzMFdROXd3SEpsRTNCZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR11MB7014.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(8096899003)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUQ0UjRlbERnZ0pLbzhaWDlRQWhqRFZMMTR0cFdpQXNHM2pCOVJNajRNUnl6?= =?utf-8?B?MHdJbGNiZXJTaDN6Wjkwei9aclFqRExPK0VDa1hVQ3hYQnhhcWFnc1gxVVcz?= =?utf-8?B?bEVmT1ZTZjNxUFV4dTkvc2xBajRlNGk1bXJLTlNjRmtLdlVXcllKUHRHdmh1?= =?utf-8?B?SFZoNHdwTEZOd29QVFBQejlpL0dWSzU5RU5MREVJYnJrcDZ4dkFaRVkybEVT?= =?utf-8?B?Nkc2N2N0Y0RyaUV5SHVXTTR6bjZwWFlacEgxYkFtcXZ3TGRodFRmTDlVb2xE?= =?utf-8?B?eWF4UU9SdjFYQjVRdHdYYXhKK0wxY0JJTmtzTjNoZTFkZkNENkphRWM3Q0Fh?= =?utf-8?B?VmlmeGs5UmVIdFpkOHNIY3BaUjVUYk9QVUZTRUFYR0krRkxzK0haVTI0L3ZB?= =?utf-8?B?OFZWcnFHT0JIUkRBQTFRWk5qR3JoU0hYZld4RE5HYUNnL2tmQTZYdFB0SFZ6?= =?utf-8?B?ZVFoc3Y3Zm5TSGdKczZmclc5MzBkeExVL1owTEVvWnBRcEsvcHEwbmlPNjA2?= =?utf-8?B?YWxObmhjRGtNaXBxbWNYR3gxN0ZWMlhjdjhMM2M5VTVHcXZoMEw2TEcrRTFO?= =?utf-8?B?NHVSYXM5RXRtUUorQU5JOUtVVGpuZXRVeEtWRU9aNnZVOG13Ni9wTlRhc3Fo?= =?utf-8?B?c0R3S0pKSUQrejd0SjdncWZuODExYW9KTFZMUHhRM25UdUFrMlZjVVZydjRT?= =?utf-8?B?cTlnblFLZktUd3BKM3hvMmhMSUQ3TVdEQUZJeEtqT0RETzBVUkxTRTFPWERj?= =?utf-8?B?QXJFUlE5NXZROXlyL0k4dlBjVDRwbGZ3YW9pbEFMN2FpNGxvVHJzeFFmZk0z?= =?utf-8?B?eW9wQUdSblVtU09yZU1ZZXEzTDhWRjlEbmNpRHlRdEFqS0xvTk1KQWt0dEpH?= =?utf-8?B?YWZPRk5RMC9WaTdaTjFDNDBybW8zT2xBdE0zaldTRUt3N3dMSzJjNmhwRGs2?= =?utf-8?B?d0NmenpMQldLQVEzaXZ1Zy83UFJSaWxZdkQxSzhwNHg5M2UxY2JYWDRxdlVk?= =?utf-8?B?Q2xqUzJVazlJZFhlRHAxMlM2RGlyeGRPZTVBSUsvNHMxMFlybWVVcngvcFgw?= =?utf-8?B?ejZHcG9zZk0zN1hIOUt0cVhOYkt0djRLY2Vad28vYklQa003cGtLNzJTMkl4?= =?utf-8?B?bVdyS1J1eEgvVnVmVUVNdUljeE8rSStuMXExVWovd0lidWV5ZzNZMjZzemU4?= =?utf-8?B?QnhQQy96TUxEWGNhNkhlZ1NBZ0Z4VEJja2tWWHVHcnFhY2lCYUNsOXphUEpR?= =?utf-8?B?emI5K0FhTmlpU0VvY21sNzlacUgzUGZaeU1YQUYrOVlqTUZ3UDJZQTgzY3NO?= =?utf-8?B?aWlLNnp5amVxT2xxSlBhdzlBV0RSZ2h0Y3BXMnpnWG1kZ1JERFIyQTVLM0pz?= =?utf-8?B?OHgraTVUZ2U1TVNPM21LbytORFF0SzQ0S3U0aDcxdXRQVE1taG5YL0JKdlkv?= =?utf-8?B?K0pnWmZWSU1nRE1CV28zUEJqR21yS3pWTXdXazRuZjUwZzJBQUs0UmpLTC9X?= =?utf-8?B?THZ4WEtYSlh6eWNiQ0ZWb0FZcGd2UWRzL0NWRHhlbzhoQXpFQlI0Q0JicVMy?= =?utf-8?B?UlFxK2FqdlNOZ3Q4UCsyR0ZWMzhPTVV5M2d0UlJLMXJnenFlQ0xoUy94b1NM?= =?utf-8?B?Zml2aVFET3g4cmhlbW15YVViU0lzUCs3dElnNy9oMWIvTTV0L2U5V2dXWlMv?= =?utf-8?B?ZmhwNXRmUFA5RGNBY2wzWUdHbEIzVFVZZnR4Zmc0RkErRWJjc2I1V0VjQURr?= =?utf-8?B?MklaUDBWKzUyTk9NRHZIS2F0R2FQaHhNNXIrNlUrQ0gvZ1dMMk5ybHFKWVFO?= =?utf-8?B?ZGJGdXpXUWZsTlhpVm9SVlN6UVdROS90STM0L1ZJRGs4SWp5RmhEZEg0bnVR?= =?utf-8?B?ODdTREJza3liWE4wU0RwTTNrMTVJeXd1djBnblppcXk1YjVJa2lDaVhQOEFs?= =?utf-8?B?NHpOazE2TE1NOW1OS3pKSGtJbkdJUSsxWkZGR1JKTlcwUTlhc1BtSENBV09C?= =?utf-8?B?WHhuVUkvdDQ4SkRWTGE4RkJ2OG9GQ3IrU0V3QkcxaDd6L0U1WkJEZTdqeEQz?= =?utf-8?B?WlM1cWp4RHY0ZW9VQS9xb2YvckxqSDNOVGJXVGxrazg2SXp2T25iclY5K21X?= =?utf-8?Q?rh3piYB/f3raecsKpX09w5yzR?= X-MS-Exchange-CrossTenant-Network-Message-Id: 931f6f0b-e5a8-4280-d578-08dd19456295 X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB7014.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2024 18:06:35.6652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oU5Jt+q1HgL6RHF33LPmJLCZjobg9+6W1mLrxcZCGsxZD8jTDYwbrzihTOvZLyEBaFwdCYqKsIIPfmjqjtOmtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7399 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" --------------18baOScAE8unAmEfm8VJvYS0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On 10/12/2024 10:31, Maarten Lankhorst wrote: > We want to merge xe_display_init_noirq and xe_display_init_noaccel, > by not enabling interrupts in between, this should be safe to do. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/xe/xe_device.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Ilia Levi > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index c1b4601a14779..fbec176ee64ad 100644 > --- a/drivers/gpu/drm/xe/xe_device.c > +++ b/drivers/gpu/drm/xe/xe_device.c > @@ -701,10 +701,6 @@ int xe_device_probe(struct xe_device *xe) > if (err) > return err; > > - err = xe_irq_install(xe); > - if (err) > - goto err; > - > err = probe_has_flat_ccs(xe); > if (err) > goto err; > @@ -738,6 +734,10 @@ int xe_device_probe(struct xe_device *xe) > goto err; > } > > + err = xe_irq_install(xe); > + if (err) > + goto err; > + > for_each_gt(gt, xe, id) { > last_gt = id; > --------------18baOScAE8unAmEfm8VJvYS0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit
On 10/12/2024 10:31, Maarten Lankhorst wrote:
We want to merge xe_display_init_noirq and xe_display_init_noaccel,
by not enabling interrupts in between, this should be safe to do.

Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/xe_device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Ilia Levi <ilia.levi@intel.com>
 
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index c1b4601a14779..fbec176ee64ad 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -701,10 +701,6 @@ int xe_device_probe(struct xe_device *xe)
 	if (err)
 		return err;
 
-	err = xe_irq_install(xe);
-	if (err)
-		goto err;
-
 	err = probe_has_flat_ccs(xe);
 	if (err)
 		goto err;
@@ -738,6 +734,10 @@ int xe_device_probe(struct xe_device *xe)
 			goto err;
 	}
 
+	err = xe_irq_install(xe);
+	if (err)
+		goto err;
+
 	for_each_gt(gt, xe, id) {
 		last_gt = id;


--------------18baOScAE8unAmEfm8VJvYS0--