Re: [PATCH 15/24] drm/vblank: pass vblank to store_vblank()

[Thomas Zimmermann <tzimmermann@suse.de>]

Am 10.11.25 um 17:17 schrieb Jani Nikula:
> Use the vblank pointer instead of a dev, pipe pair to simplify code.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/drm_vblank.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> index 93ad785cbc32..86919b1c0c2c 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -188,11 +188,11 @@ drm_crtc_vblank_crtc(struct drm_crtc *crtc)
>   }
>   EXPORT_SYMBOL(drm_crtc_vblank_crtc);
>   
> -static void store_vblank(struct drm_device *dev, unsigned int pipe,
> +static void store_vblank(struct drm_vblank_crtc *vblank,
>   			 u32 vblank_count_inc,
>   			 ktime_t t_vblank, u32 last)
>   {
> -	struct drm_vblank_crtc *vblank = drm_vblank_crtc(dev, pipe);
> +	struct drm_device *dev = vblank->dev;
>   
>   	assert_spin_locked(&dev->vblank_time_lock);
>   
> @@ -277,7 +277,7 @@ static void drm_reset_vblank_timestamp(struct drm_vblank_crtc *vblank)
>   	 * +1 to make sure user will never see the same
>   	 * vblank counter value before and after a modeset
>   	 */
> -	store_vblank(dev, pipe, 1, t_vblank, cur_vblank);
> +	store_vblank(vblank, 1, t_vblank, cur_vblank);
>   
>   	spin_unlock(&dev->vblank_time_lock);
>   }
> @@ -384,7 +384,7 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,
>   	if (!rc && !in_vblank_irq)
>   		t_vblank = 0;
>   
> -	store_vblank(dev, pipe, diff, t_vblank, cur_vblank);
> +	store_vblank(vblank, diff, t_vblank, cur_vblank);
>   }
>   
>   u64 drm_vblank_count(struct drm_vblank_crtc *vblank)

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)