Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Summers, Stuart" <stuart.summers@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"Brost,  Matthew" <matthew.brost@intel.com>
Subject: Re: [PATCH] drm/xe: Move page fault init after topology init
Date: Fri, 11 Jul 2025 15:08:55 +0000	[thread overview]
Message-ID: <25add0bffd0a1a561aef4e32074c93b73ef6fd01.camel@intel.com> (raw)
In-Reply-To: <20250710191208.1040215-1-matthew.brost@intel.com>

On Thu, 2025-07-10 at 12:12 -0700, Matthew Brost wrote:
> We need the topology to determine GT page fault queue size, move page
> fault init after topology init.
> 
> Cc: stable@vger.kernel.org
> Fixes: 3338e4f90c14 ("drm/xe: Use topology to determine page fault
> queue size")
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Yep, good catch and thanks!

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_gt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index d397df056e4c..af03e19ef9be 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -628,15 +628,15 @@ int xe_gt_init(struct xe_gt *gt)
>         if (err)
>                 return err;
>  
> -       err = xe_gt_pagefault_init(gt);
> +       err = xe_gt_sysfs_init(gt);
>         if (err)
>                 return err;
>  
> -       err = xe_gt_sysfs_init(gt);
> +       err = gt_init_with_gt_forcewake(gt);
>         if (err)
>                 return err;
>  
> -       err = gt_init_with_gt_forcewake(gt);
> +       err = xe_gt_pagefault_init(gt);
>         if (err)
>                 return err;
>  


  parent reply	other threads:[~2025-07-11 15:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 19:12 [PATCH] drm/xe: Move page fault init after topology init Matthew Brost
2025-07-10 19:17 ` ✓ CI.KUnit: success for " Patchwork
2025-07-10 19:20 ` [PATCH] " Cavitt, Jonathan
2025-07-10 19:54 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-07-11  1:36 ` ✓ Xe.CI.Full: " Patchwork
2025-07-11 15:08 ` Summers, Stuart [this message]
2025-07-11 16:25   ` [PATCH] " Matthew Brost
2025-07-11 16:29     ` Summers, Stuart
2025-07-11 16:50       ` Summers, Stuart
2025-07-11 16:58         ` Matthew Brost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25add0bffd0a1a561aef4e32074c93b73ef6fd01.camel@intel.com \
    --to=stuart.summers@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox