Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: <intel-xe@lists.freedesktop.org>, <linux-hwmon@vger.kernel.org>
Cc: linux@roeck-us.net
Subject: Re: [Intel-xe] [PATCH v4 1/6] drm/xe: Add XE_MISSING_CASE macro
Date: Wed, 6 Sep 2023 16:43:37 +0530	[thread overview]
Message-ID: <25e2f0ea-48f5-7fe0-4b7a-1e8d91b6eced@intel.com> (raw)
In-Reply-To: <20230904182258.2291881-2-badal.nilawar@intel.com>

Hi Andi

On 04-09-2023 23:52, Badal Nilawar wrote:
> Add XE_MISSING_CASE macro to handle missing switch case
> 
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_macros.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_macros.h b/drivers/gpu/drm/xe/xe_macros.h
> index daf56c846d03..21ba859d5f80 100644
> --- a/drivers/gpu/drm/xe/xe_macros.h
> +++ b/drivers/gpu/drm/xe/xe_macros.h
> @@ -15,4 +15,7 @@
>   			    "Ioctl argument check failed at %s:%d: %s", \
>   			    __FILE__, __LINE__, #cond), 1))
>   
> +#define XE_MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
> +				__stringify(x), (long)(x))
You suggested to reuse MISSING_CASE from i915 but I couldn't find common 
place to move it so defined new macro.

Regards,
Badal
> +
>   #endif

  reply	other threads:[~2023-09-06 11:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 18:22 [Intel-xe] [PATCH v4 0/6] Add HWMON support for DGFX Badal Nilawar
2023-09-04 18:22 ` [Intel-xe] [PATCH v4 1/6] drm/xe: Add XE_MISSING_CASE macro Badal Nilawar
2023-09-06 11:13   ` Nilawar, Badal [this message]
2023-09-20 13:46   ` Ghimiray, Himal Prasad
2023-09-04 18:22 ` [Intel-xe] [PATCH v4 2/6] drm/xe/hwmon: Expose power attributes Badal Nilawar
2023-09-06 10:23   ` Riana Tauro
2023-09-06 10:58     ` Nilawar, Badal
2023-09-04 18:22 ` [Intel-xe] [PATCH v4 3/6] drm/xe/hwmon: Expose card reactive critical power Badal Nilawar
2023-09-06 14:45   ` Riana Tauro
2023-09-04 18:22 ` [Intel-xe] [PATCH v4 4/6] drm/xe/hwmon: Expose input voltage attribute Badal Nilawar
2023-09-08  6:56   ` Riana Tauro
2023-09-04 18:22 ` [Intel-xe] [PATCH v4 5/6] drm/xe/hwmon: Expose hwmon energy attribute Badal Nilawar
2023-09-07  5:24   ` Riana Tauro
2023-09-04 18:22 ` [Intel-xe] [PATCH v4 6/6] drm/xe/hwmon: Expose power1_max_interval Badal Nilawar
2023-09-04 18:41 ` [Intel-xe] ✓ CI.Patch_applied: success for Add HWMON support for DGFX (rev4) Patchwork
2023-09-04 18:42 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-04 18:43 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-04 18:50 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-04 18:50 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-04 18:50 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-04 19:23 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25e2f0ea-48f5-7fe0-4b7a-1e8d91b6eced@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox