Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe: use drm based debugging instead of dev
Date: Mon, 12 Feb 2024 16:21:46 +0100	[thread overview]
Message-ID: <26e8d3c2ef45e64dc07f568222e709ac64ad6b35.camel@linux.intel.com> (raw)
In-Reply-To: <20240212145757.645094-1-jani.nikula@intel.com>

On Mon, 2024-02-12 at 16:57 +0200, Jani Nikula wrote:
> Prefer drm_dbg() over dev_dbg().
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/xe_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_irq.c
> b/drivers/gpu/drm/xe/xe_irq.c
> index 17b3affdb6a0..2f5d179e0d00 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -442,7 +442,7 @@ static irqreturn_t dg1_irq_handler(int irq, void
> *arg)
>  		 * irq as device is inaccessible.
>  		 */
>  		if (master_ctl == REG_GENMASK(31, 0)) {
> -			dev_dbg(tile_to_xe(tile)->drm.dev,
> +			drm_dbg(&tile_to_xe(tile)->drm,
>  				"Ignore this IRQ as device might be
> in DPC containment.\n");
>  			return IRQ_HANDLED;
>  		}


  reply	other threads:[~2024-02-12 15:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 14:57 [PATCH] drm/xe: use drm based debugging instead of dev Jani Nikula
2024-02-12 15:21 ` Thomas Hellström [this message]
2024-02-12 19:30   ` Jani Nikula
2024-02-12 17:25 ` ✓ CI.Patch_applied: success for " Patchwork
2024-02-12 17:25 ` ✓ CI.checkpatch: " Patchwork
2024-02-12 17:26 ` ✓ CI.KUnit: " Patchwork
2024-02-12 17:36 ` ✓ CI.Build: " Patchwork
2024-02-12 17:37 ` ✓ CI.Hooks: " Patchwork
2024-02-12 17:38 ` ✓ CI.checksparse: " Patchwork
2024-02-12 18:15 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26e8d3c2ef45e64dc07f568222e709ac64ad6b35.camel@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox