From: Jani Nikula <jani.nikula@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 1/5] drm/xe/debugfs: Update xe_gt_topology_dump signature
Date: Tue, 30 Sep 2025 11:45:11 +0300 [thread overview]
Message-ID: <275ae979fdbefb5e6f4fbc00bf183eb0b7d336c1@intel.com> (raw)
In-Reply-To: <20250923211613.193347-2-michal.wajdeczko@intel.com>
On Tue, 23 Sep 2025, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> +/**
> + * xe_gt_topology_dump() - Dump GT topology into a drm printer.
> + * @gt: the &xe_gt
> + * @p: the &drm_printer
> + *
> + * Return: always 0.
> + */
> +int xe_gt_topology_dump(struct xe_gt *gt, struct drm_printer *p)
What benefit do the formatted kernel-doc give us? IMO it's just
boilerplate with pretty much everything being obvious from the function
name and parameters. And the functions aren't significant enough to be
made part of the Sphinx build either.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-09-30 8:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 21:16 [PATCH 0/5] drm/xe/debugfs: Avoid use of wrapper functions Michal Wajdeczko
2025-09-23 21:16 ` [PATCH 1/5] drm/xe/debugfs: Update xe_gt_topology_dump signature Michal Wajdeczko
2025-09-29 23:25 ` Rodrigo Vivi
2025-09-30 8:45 ` Jani Nikula [this message]
2025-09-30 10:17 ` Michal Wajdeczko
2025-09-30 11:43 ` Jani Nikula
2025-09-30 17:23 ` Raag Jadav
2025-09-30 17:46 ` Michal Wajdeczko
2025-10-01 15:35 ` Rodrigo Vivi
2025-09-23 21:16 ` [PATCH 2/5] drm/xe/debugfs: Update xe_wa_dump signature Michal Wajdeczko
2025-09-29 23:25 ` Rodrigo Vivi
2025-09-23 21:16 ` [PATCH 3/5] drm/xe/debugfs: Update xe_tuning_dump signature Michal Wajdeczko
2025-09-29 23:26 ` Rodrigo Vivi
2025-09-23 21:16 ` [PATCH 4/5] drm/xe/debugfs: Update xe_mocs_dump signature Michal Wajdeczko
2025-09-29 23:26 ` Rodrigo Vivi
2025-09-23 21:16 ` [PATCH 5/5] drm/xe/debugfs: Update xe_pat_dump signature Michal Wajdeczko
2025-09-29 23:27 ` Rodrigo Vivi
2025-09-23 21:23 ` ✓ CI.KUnit: success for drm/xe/debugfs: Avoid use of wrapper functions Patchwork
2025-09-23 22:22 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-24 2:07 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-30 8:15 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=275ae979fdbefb5e6f4fbc00bf183eb0b7d336c1@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox