From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75F4ECF8864 for ; Thu, 20 Nov 2025 15:30:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3AE0310E776; Thu, 20 Nov 2025 15:30:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="cML21o/1"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3EC5510E776 for ; Thu, 20 Nov 2025 15:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763652620; x=1795188620; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=71aEn0iGnq12dt4LTom+vdHSW0rpKT+ialpLKxcov/M=; b=cML21o/1syiPyx5Wnszw6AKfzksvD7mCb5CbrVIqsVVfkjqguMJYJVoo t0gos2K7cbBzOYCfq5bi8shv8SgcaHPsGn1jihLLf849DI9TX7oIFg4Jg hGwQI3WXM7EFezOkowhTOM/DAKkIhoiYarBGnaKLoQqL+MNPR3gSrqw+g fzly3R8D5Ap8OdJx/VpRGwr0zMIHVTRN4J6ctpiDrj3rq5lGRlbk7Gtks 5WpuWJKWiGE/0+MuOMxTn3JZYl48GFL+3lbV7T6hCVmzDR3nnOljShksB gxx10erKhEZvJw+WGUKTng2QCdg9PuZ8vFUD9kJrJvdQ12HJZHVf5IdKE Q==; X-CSE-ConnectionGUID: 6FrcSDxmT4qDknzg6MBNBw== X-CSE-MsgGUID: /zmqpC+BTQys1idqCdaKoA== X-IronPort-AV: E=McAfee;i="6800,10657,11619"; a="88379076" X-IronPort-AV: E=Sophos;i="6.20,213,1758610800"; d="scan'208,217";a="88379076" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2025 07:30:19 -0800 X-CSE-ConnectionGUID: zgnnw0oiRJqxZIvCt/OFpg== X-CSE-MsgGUID: nRKkRgZlSim/Skf6GlpuCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,213,1758610800"; d="scan'208,217";a="191819735" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2025 07:30:16 -0800 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.27; Thu, 20 Nov 2025 07:30:15 -0800 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.27 via Frontend Transport; Thu, 20 Nov 2025 07:30:15 -0800 Received: from BN1PR04CU002.outbound.protection.outlook.com (52.101.56.28) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.27; Thu, 20 Nov 2025 07:30:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XgfcHB50hAQaDp8H1piDkUfANLKavmYQcPCbR9mGg3xJd0fifJ03JfBKcMAVYUBBkY364aJnKU1FsCjAnvdDAh1HRDGC5hCdAxt587Uwuz3gFxURJ53COMqaT08Tp4Ka0VqLgs0Kdrol4xMPoEZBw4LqXqiRVjhXDjR34jaBOsjVRuA10pc2V2fQltoV2tShXWpu2klZc2bUREkkFWWZ5iXaFoV4L99wRmrly5pgqHDiZGM7MyVPihGOC2YtAf85Pg3SN2uNRF8l8U9AeGse6bx4O+vhtj60gVSDwzOI2pf14iSx5D1oXbogjhWY+jhQ6qdR25vVavGG28M550dFHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nWcEQh+te14tdDkVcI2Ndj2LOpRNMz0Fv0BRCGANv14=; b=PaxXi4pmrxxR0QbFzg4/PVJyCYsh70+RuZyy4GUeJImcU9Nv+GYpzVqwbqii3SiG5a5y6lHxcUqgk14ief3crRLryVBk4YpFxAMkCo8+w4koZbPaCp2sxpswW/F0o1kjvKLU0QYXc5wdU+R0SfXlSHQtMl3ApfimUUDXAgkJ+AjG2UfmHtWO3KP3qQzjQGLRhGL9no63E8zDidG/bBW7IRDA1rO3tKhAlBS2xnod4zE7ijtSjXbKchsCcRk/Kp8TzcMC1gCnmMTXbBNj96l1UJ/mv8LoqLHE1/sOii0dm4vNC88QO4BsHgT0rHT+FC7GvD6ENrzAOGxtSc7Aok+cHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6096.namprd11.prod.outlook.com (2603:10b6:8:af::16) by SA3PR11MB9510.namprd11.prod.outlook.com (2603:10b6:806:47e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Thu, 20 Nov 2025 15:30:10 +0000 Received: from DM4PR11MB6096.namprd11.prod.outlook.com ([fe80::f3b4:61a8:7022:df18]) by DM4PR11MB6096.namprd11.prod.outlook.com ([fe80::f3b4:61a8:7022:df18%7]) with mapi id 15.20.9320.013; Thu, 20 Nov 2025 15:30:10 +0000 Content-Type: multipart/alternative; boundary="------------0Uj1YJZv5L4JQIe4z9qh5gAd" Message-ID: <27bd7b68-078d-4c4a-9b4a-72d30356e212@intel.com> Date: Thu, 20 Nov 2025 21:00:03 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] drm/xe/migrate: fix job lock assert To: Matthew Auld , CC: =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Matthew Brost References: <20251120132727.575986-4-matthew.auld@intel.com> <20251120132727.575986-6-matthew.auld@intel.com> Content-Language: en-US From: "Yadav, Arvind" In-Reply-To: <20251120132727.575986-6-matthew.auld@intel.com> X-ClientProxiedBy: MA0PR01CA0084.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:ae::18) To DM4PR11MB6096.namprd11.prod.outlook.com (2603:10b6:8:af::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6096:EE_|SA3PR11MB9510:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a01d197-20dc-4bc3-beee-08de2849b0c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cHlENXFpZ0VNVzJiT1RId2JKMkVpNHFxOUpkNlZPRzh4K0tpS0k5dW9OR1hX?= =?utf-8?B?SEhmdndHT2RDcGdQN0VyZm1sSlpDMkIwWkF4WVN1V3htMC9GUVp5bEZsTDl0?= =?utf-8?B?WTErc3E1d1B0eTdXcm5WbTVkMXIvK3NwdHBYckF2bXRhR0pkK0crZW03L3pl?= =?utf-8?B?NjZzVmJ5NHdFMEFWNFhLMDlDeVU4aGszWE0yK2VaN3JkTjRJT3pCdUlodWJ0?= =?utf-8?B?MnlzS01mK1pGdzBSU1Q1MktuazFsdVNFMmtjem9XU2tJa0Y0M0pRU21OMmtN?= =?utf-8?B?WCtjdnZUc1ZuVURzOWVxQWNKNElFK0g1bHdwZitHMWI1c2E0QUJnSzlHcVhJ?= =?utf-8?B?VGVUc1lNK2x5WkpheXlsL3BTYmdkalRwMjc1S2hnMy8xZk8vUEtwY0oxNHNm?= =?utf-8?B?QVVma29vWTJVNnJZZFdUQlNlbDVtM0NUKytLbnlBTmlpVEN1VFpQSGNDZkps?= =?utf-8?B?MFJoeGpLamJTTGpHeHcrdzNYN1V3dGZiUlFpV3BtaC92M1paSGE2NEc5dFpr?= =?utf-8?B?MmpyRXZuMGVqbUVZWEpMNHl5TmxVUUNLYjc3SS85WlJvMHVvQUdGUERXbm52?= =?utf-8?B?ZVRMcHpqY1Z1ZmxSUzJsalgxWC95cDhlcVFWNVdXOUxXSjdRS2JKbEJaVEJR?= =?utf-8?B?RmZiMWNLSCs5MUk3Zm1GQk8vVGYvNzVxTmppWmJtbTJsK1l5V2VVZzNFeDFh?= =?utf-8?B?QWhVckJkZzZCMG45U0cxeUgxOFNnZEVtenZqbnp3M3J6aThvb2EzSU13NGVj?= =?utf-8?B?UWUwd1lwTSt6Y0Fia21RVUFuWGlVVkVadDFDd0xwOG5XZEdMWmt1QXI5L0FQ?= =?utf-8?B?L1M5Tk56TytYM1VxYjAvVFltaGRrWVZ0bmNTdEFFU3V1M1JJZ085bmtLOU41?= =?utf-8?B?Vlp6YXVEeEJ6cDNCTGcvUVBEU0RidHdXUjBhK05kZ3lQR2IrRU1qVk1LVDhr?= =?utf-8?B?bEo3WnBHUE1iOGdzd1QvdjcveWRUMnJJbk5Uc2huVStMZUZSQmpIRWlQZkl1?= =?utf-8?B?OXJCZkhKRmp1RFFYMk8yb1pFT2NCZE5TQTc0cEdiZXJZZ09vMUlCSTJsZ0lH?= =?utf-8?B?L2ZWYUw3ZWI5SEJUUGxKSXRKUVcrRnEzRWV3SVlBenBrOGhiQmZidmdXaE51?= =?utf-8?B?cXFydG10SmQ5VERkUXVBb3hhTGIwclFXbWlWQjJhaXBHSDFsUytUSWFVc2k5?= =?utf-8?B?YVpGaGJQb0ZldkFaUmRXYjFyWUpSeTlldHJnYVh1ZkVTRDVuVjFYWDdEUGlp?= =?utf-8?B?aWNFWXN5TFBSMnBuU1Z4anU1QVdha3pxbW5JdXJZVy8xeC9wVjI4Q1lBYmF1?= =?utf-8?B?R3l0YmdNZXExM281d3MyZUVrTjFjTy9QeVZIZStiTEl5K3M5VENXUmVYbExL?= =?utf-8?B?QWcyTXVTUXRBZk1zNVpxc04yd1FHMzhOYTQ4OXJMNHFzVVFHaytTNFpwK0t6?= =?utf-8?B?MW9MSFpFc0psUnBwV2JTNkM4clhrQVhUbzUxUkxNUjI4NkY3RDlrSFF1bG1v?= =?utf-8?B?T09zRDZncHhaZHRiek4xYURCVVgxS0VjbnIyR095elRkWWUxSkV6cm5rZXN0?= =?utf-8?B?ZzRaZkJwM2laNDN2Um1JaVkzR2g4VTg2NWdsVFlHa0V4UjdML0dQeU9uLzUv?= =?utf-8?B?WHUvQnZIdlBhd0pQZWUvcU5oMzhmZXNzNlYzaHo0ZXlJYnVEMVAwWlZnWlBE?= =?utf-8?B?OXlLZzlCLzVMWTNLaUE5dk5ZR3BiL3ZtbFNtMjN3cUc5anFBanREMDA2dVdr?= =?utf-8?B?ZENlTmZSVTRFN1NtZkNwVUZzK0NhVk0rWHRXVTFlWk53OVkrYzJyYXpuMnpp?= =?utf-8?B?KzJJdkdnMHZnL2FrYnlrSWZFYVdIZDArZWNiMklhU2pIUENLMFp0ZU1oWU5W?= =?utf-8?B?YTZHOFBobnBZQjJLNjZlTGxaTm9Rb2xwOEVhSkVaUDdML2llWllPVEN5VHI5?= =?utf-8?Q?eCL+sJ8F1oy/mR2HGeRCir4Aei59x/Fo?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6096.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVhmdkVQa01jK1c5REZpZ2E1UjdwME9YMk9kOUZyQ20wVm1jc21BaGQyT2VU?= =?utf-8?B?MFV6aWtUVmZobWVldzcwYmptbDZkOU53Unh1Y0w4T3dYbVlhR0IvQTNpOGp0?= =?utf-8?B?amVmdVBaU1gyUjNJNVRudWtiZUNmNDlVZmpxQ1JoTG5GNVExM0U3MzhmM2ZT?= =?utf-8?B?a25TTDZuOWJDNUVnU3BtMm80SzJ1M3REK2lORlpiQ0JPekV6elg0Unp0dXVr?= =?utf-8?B?eERmZ1ZvL0xXV1BZWkg5RlRoc2FNaDBwR2hmb0lBckpyTGdpanFGOVpUNmVS?= =?utf-8?B?WTMwVXZ5YjN4eFp6blZGVnRHc09STXVRdmExU1Zsa2J4K2VsZlhTSTBHUllE?= =?utf-8?B?MGlGcE1YOVZ3ZmhwVEl2c2VtU2hKTEIyN0l0OVBlRDNMYTVKZzJDS28zdmdu?= =?utf-8?B?VzVuQ04zdmNCNkpGQm93bTZLbnpUSnpTWlFBMjhzdTRKL0FMRkpCVjluaGRO?= =?utf-8?B?RWVXdk84cDJrR1RaRFc1RXNQcWdSVWE1T0dEVG1HUGs3WHJKZlBVcGNQYnFx?= =?utf-8?B?bUpncjRDNXhyTzh1d21WdTB4bFZTWUllNjN3bzJBQjNSbVRMRmVOczd5cHJo?= =?utf-8?B?NVZITjJwblgvclFJMmZ6N3I2cDBwMlJHMno5blUxa3pXQXhaU0l2S3Zicm1D?= =?utf-8?B?TU1TM2g3WWxsWEZ2SWhVK0FTTkpyeGlOZkdVaWFFQVBMeUdvUUw1dWRoeHk2?= =?utf-8?B?NTNvUkZMVUl5cHVtRUk3N0lsMUxCSkxaRXVnLytNVVozaHZOczUySHR1Rlc5?= =?utf-8?B?T09zY1ovVzIxcGNtRXBZVSsrQmZLYStuSHN3SXpFVW1zZjFzQUNxanUxMG1O?= =?utf-8?B?ZnZjNXdXL0dLT2VQa3lNNkFrK3NZOTVJNWpLb2UwQkRXUDcxblBiSE9sbUQy?= =?utf-8?B?VERsMVlMd1RTaVNWaDl5emlDWW5jRFplNmY1c0d2R2dDeTJQRUtmN1BJaUtI?= =?utf-8?B?SzZHUVRvY2czcXZxZkJzVytWVkdnZDYvL2VFbWEvWUhSRHJqMzFOa2s5c0JX?= =?utf-8?B?TVhORjI5V3VuRDVGVnB3UFJvUUhoUUE3RjgrUXVlN3JjYmJicE01SFlDV0dl?= =?utf-8?B?cWRkWjlKa3FQVlFQNWRZSmxDNEhpckFFMzR3Nm9hZzNmRnlSV0VnVzNyYVlP?= =?utf-8?B?MEpLWVUweTdWc05ERGprZFc5aFhCSGRIZ204MW1rNzBXZm9BUm9Eak5SSjZ0?= =?utf-8?B?aU8rYWJ0UWY2aVRBalJmVkdsSjkybmR4aHJOT3h3cW1yYndSeUNSSGFpQy80?= =?utf-8?B?aWpLK08xVTFUWHFCdGNJbmorWDcyeTBFb2NlMDNFSGRyek8vMkFTUzZNU09k?= =?utf-8?B?SU54WjY4V0tZOWlYY243MFhBSDdsKy9vQW56bC9oRzJIeWxrbDVqdEEvUkVL?= =?utf-8?B?VjBYQTBYaW5FZDRVcWtLRzdRN2lCU0c0blpwZitBRzlzOUFreVBjd2dCcWZI?= =?utf-8?B?Sk90TElVaG53dFVNL0JiVjZRMVdyY3B1VE9GWjlGVWtQWFdiZ0EvZG9rN2w3?= =?utf-8?B?OEsyZWlZbTQ1Q1VucWtGdVF3R3lLR1ducDZJZEt5bVNBeGFjZGlBQW5KSDdq?= =?utf-8?B?K2Z5bnMzQjVzSnp1NmhvRjd6MWVtTDIxS2NleGJLZGZTL2hYb0FPa1RHaXEw?= =?utf-8?B?YUxWbGtXTUcxVGlBRC9ucGZIUXRDdmE4QlZLOVNJRDVKZkowVWtCUUI3dTFE?= =?utf-8?B?MFhJK1FhNWRjdzRwTm4rbFUzWkEzNmFuOEptdmVkbU5TMFNEUjFxYU5uQnpM?= =?utf-8?B?NmMzNGE1THdENlpoZ0FqNi80MTFidHZRTkhnWnlYQU1ZS2pXNFh6TW5pSFVm?= =?utf-8?B?NFJ4VDZvK2YzZDdtV0ZTRXBNTU1GUDk4K2hWc1cyZGR6OGxOeXBXMlR5ZGhr?= =?utf-8?B?aW1GV1MwdWIxOHN2OThNcXhXd3NuZXB1MHc4ek54RFV0TEplcGxCOURDUE0y?= =?utf-8?B?MmZpdFNiOFkxOG4zMmMwRHIxRWc2Zm1ESmpHSGhoRzBNMjQxUVJLV1MwOTFH?= =?utf-8?B?eU51Sld4dDVxckRKWXo4RXRFSGQ5Nityd0JuNm55NWVqQU96OVpvc2hLUlVL?= =?utf-8?B?bC9hTFYvMVdPcGQ3ekR0UWNCRnkrUUtSbjZQVkgwTE16OEtTQ01WY2VvSHV2?= =?utf-8?Q?8nB8fboTuO1xxWsUAhVGgjMN0?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7a01d197-20dc-4bc3-beee-08de2849b0c6 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6096.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 15:30:10.1209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DzfOWXvDfOiuOfmZ/8d4ZMKpqZj8yLDQWRbmCcfEw5rSrS4WvG/kcfOT10IJvmt2D1/xeZlNiEfvRIGLL5L0UQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB9510 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" --------------0Uj1YJZv5L4JQIe4z9qh5gAd Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Looks good to me. Reviewed-by: Arvind Yadav On 20-11-2025 18:57, Matthew Auld wrote: > We are meant to be checking the user vm for the bind queue, but actually > we are checking the migrate vm. For various reasons this is not > currently firing but this will likely change in the future. > > Now that we have the user_vm attached to the bind queue, we can fix this > by directly checking that here. > > Fixes: dba89840a920 ("drm/xe: Add GT TLB invalidation jobs") > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Matthew Brost > Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/xe/xe_migrate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c > index f3b66b55acfb..2ed8ee32b5cf 100644 > --- a/drivers/gpu/drm/xe/xe_migrate.c > +++ b/drivers/gpu/drm/xe/xe_migrate.c > @@ -2481,7 +2481,7 @@ void xe_migrate_job_lock(struct xe_migrate *m, struct xe_exec_queue *q) > if (is_migrate) > mutex_lock(&m->job_mutex); > else > - xe_vm_assert_held(q->vm); /* User queues VM's should be locked */ > + xe_vm_assert_held(q->user_vm); /* User queues VM's should be locked */ > } > > /** > @@ -2499,7 +2499,7 @@ void xe_migrate_job_unlock(struct xe_migrate *m, struct xe_exec_queue *q) > if (is_migrate) > mutex_unlock(&m->job_mutex); > else > - xe_vm_assert_held(q->vm); /* User queues VM's should be locked */ > + xe_vm_assert_held(q->user_vm); /* User queues VM's should be locked */ > } > > #if IS_ENABLED(CONFIG_PROVE_LOCKING) --------------0Uj1YJZv5L4JQIe4z9qh5gAd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit

Looks good to me. 
Reviewed-by: Arvind Yadav <arvind.yadav@intel.com>

On 20-11-2025 18:57, Matthew Auld wrote:
We are meant to be checking the user vm for the bind queue, but actually
we are checking the migrate vm. For various reasons this is not
currently firing but this will likely change in the future.

Now that we have the user_vm attached to the bind queue, we can fix this
by directly checking that here.

Fixes: dba89840a920 ("drm/xe: Add GT TLB invalidation jobs")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_migrate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c
index f3b66b55acfb..2ed8ee32b5cf 100644
--- a/drivers/gpu/drm/xe/xe_migrate.c
+++ b/drivers/gpu/drm/xe/xe_migrate.c
@@ -2481,7 +2481,7 @@ void xe_migrate_job_lock(struct xe_migrate *m, struct xe_exec_queue *q)
 	if (is_migrate)
 		mutex_lock(&m->job_mutex);
 	else
-		xe_vm_assert_held(q->vm);	/* User queues VM's should be locked */
+		xe_vm_assert_held(q->user_vm);	/* User queues VM's should be locked */
 }
 
 /**
@@ -2499,7 +2499,7 @@ void xe_migrate_job_unlock(struct xe_migrate *m, struct xe_exec_queue *q)
 	if (is_migrate)
 		mutex_unlock(&m->job_mutex);
 	else
-		xe_vm_assert_held(q->vm);	/* User queues VM's should be locked */
+		xe_vm_assert_held(q->user_vm);	/* User queues VM's should be locked */
 }
 
 #if IS_ENABLED(CONFIG_PROVE_LOCKING)
--------------0Uj1YJZv5L4JQIe4z9qh5gAd--