Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/xe: Nuke EXEC_QUEUE_FLAG_PERSISTENT
Date: Thu, 7 Mar 2024 11:54:17 +0100	[thread overview]
Message-ID: <29091195-93fd-43c4-a2be-f90e4dd174f0@linux.intel.com> (raw)
In-Reply-To: <20240304140514.24768-4-jose.souza@intel.com>

For patch 2 with the errno inversion fixed, and 1 and 4:

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

On 2024-03-04 15:05, José Roberto de Souza wrote:
> This is a left over of commit f1a9abc0cf31 ("drm/xe/uapi: Remove support for persistent exec_queues").
> 
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_exec_queue_types.h | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> index 62b3d9d1d7cdd..9cc689f50db00 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
> +++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> @@ -76,14 +76,12 @@ struct xe_exec_queue {
>   #define EXEC_QUEUE_FLAG_KERNEL			BIT(1)
>   /* kernel engine only destroyed at driver unload */
>   #define EXEC_QUEUE_FLAG_PERMANENT		BIT(2)
> -/* queue keeps running pending jobs after destroy ioctl */
> -#define EXEC_QUEUE_FLAG_PERSISTENT		BIT(3)
>   /* for VM jobs. Caller needs to hold rpm ref when creating queue with this flag */
> -#define EXEC_QUEUE_FLAG_VM			BIT(4)
> +#define EXEC_QUEUE_FLAG_VM			BIT(3)
>   /* child of VM queue for multi-tile VM jobs */
> -#define EXEC_QUEUE_FLAG_BIND_ENGINE_CHILD	BIT(5)
> +#define EXEC_QUEUE_FLAG_BIND_ENGINE_CHILD	BIT(4)
>   /* kernel exec_queue only, set priority to highest level */
> -#define EXEC_QUEUE_FLAG_HIGH_PRIORITY		BIT(6)
> +#define EXEC_QUEUE_FLAG_HIGH_PRIORITY		BIT(5)
>   
>   	/**
>   	 * @flags: flags for this exec queue, should statically setup aside from ban

  reply	other threads:[~2024-03-07 10:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 14:05 [PATCH 1/4] drm/xe: Make devcoredump VM error state print consistent José Roberto de Souza
2024-03-04 14:05 ` [PATCH 2/4] drm/xe/devcoredump: Print errno if VM snapshot was not captured José Roberto de Souza
2024-03-07 10:50   ` Maarten Lankhorst
2024-03-04 14:05 ` [PATCH 3/4] drm/xe/devcoredump: Lock snap_mutex earlier José Roberto de Souza
2024-03-07 10:53   ` Maarten Lankhorst
2024-03-04 14:05 ` [PATCH 4/4] drm/xe: Nuke EXEC_QUEUE_FLAG_PERSISTENT José Roberto de Souza
2024-03-07 10:54   ` Maarten Lankhorst [this message]
2024-03-05  5:35 ` ✓ CI.Patch_applied: success for series starting with [1/4] drm/xe: Make devcoredump VM error state print consistent (rev2) Patchwork
2024-03-05  5:35 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-05  5:36 ` ✓ CI.KUnit: success " Patchwork
2024-03-05  5:47 ` ✓ CI.Build: " Patchwork
2024-03-05  5:47 ` ✓ CI.Hooks: " Patchwork
2024-03-05  5:49 ` ✓ CI.checksparse: " Patchwork
2024-03-05  6:09 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29091195-93fd-43c4-a2be-f90e4dd174f0@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox