From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23260C3DA63 for ; Thu, 18 Jul 2024 17:52:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5EA9892ED; Thu, 18 Jul 2024 17:52:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="b/9yY4Re"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C296892ED for ; Thu, 18 Jul 2024 17:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721325135; x=1752861135; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=U2o6OMthXbnyjhOEv1YER+qTrAant+nmqrNdKHnNkus=; b=b/9yY4ReGljcyczuzM87PDQJyUGyJe1i2p+kpLYBAHUEiCSLPxzYBSRH iUw1oIc2Ii0SyE4Wzu2e/1ThVth2esTAyjxYrrQHKo0nURzceZqaaNIPu TMKnxLHYbU/4YAVJ2AT1StraBpHF2hawZsN4WsK2TggbH0aJbA7/nS4Hj cnC7Q4Fh1HQRgfsU0NIkdigakplIGk3IB+QMMLOSB/9mLzBkcdpM55Fg8 gP+8KUEbsESYdDahh/3E8J94/ID+UP6f3CE2XuhWiDoqAsB7TFG1GMHe1 aVXQziTjEudutOF6XbNN1qymHY2b7AxqTFcuE9rcCskKLmPLlXFudAE7G g==; X-CSE-ConnectionGUID: LMnZHUyvTDSNi/nsYwCjCw== X-CSE-MsgGUID: 6xoBd6g1RtusNRfuGW5OPw== X-IronPort-AV: E=McAfee;i="6700,10204,11137"; a="18755908" X-IronPort-AV: E=Sophos;i="6.09,218,1716274800"; d="scan'208";a="18755908" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2024 10:52:14 -0700 X-CSE-ConnectionGUID: PTvDcMX8Saufa39Qf8M/vA== X-CSE-MsgGUID: CSPweXpMTl2ALQLSDlkQlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,218,1716274800"; d="scan'208";a="50806167" Received: from dhhellew-desk2.ger.corp.intel.com.ger.corp.intel.com (HELO [10.245.244.251]) ([10.245.244.251]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2024 10:52:13 -0700 Message-ID: <2945f2f0-0d3e-4b6c-ae0f-30ce3c053f81@intel.com> Date: Thu, 18 Jul 2024 18:52:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] drm/xe: Build PM into GuC CT layer To: Matthew Brost , intel-xe@lists.freedesktop.org Cc: nirmoy.das@intel.com, rodrigo.vivi@intel.com References: <20240718173445.1490455-1-matthew.brost@intel.com> <20240718173445.1490455-2-matthew.brost@intel.com> Content-Language: en-GB From: Matthew Auld In-Reply-To: <20240718173445.1490455-2-matthew.brost@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 18/07/2024 18:34, Matthew Brost wrote: > Take PM ref when any G2H are outstanding, drop when none are > outstanding. > > To safely ensure we have PM ref when in the GuC CT layer, a PM ref needs > to be held when scheduler messages are pending too. > > v2: > - Add outer PM protections to xe_file_close (CI) > v3: > - Only take PM ref 0->1 and drop on 1->0 (Matthew Auld) > > Cc: Matthew Auld > Cc: Rodrigo Vivi > Cc: Nirmoy Das > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/xe/xe_device.c | 4 ++++ > drivers/gpu/drm/xe/xe_guc_ct.c | 8 +++++++- > drivers/gpu/drm/xe/xe_guc_submit.c | 4 ++++ > 3 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index 06cebaffb451..b68ab474e1a0 100644 > --- a/drivers/gpu/drm/xe/xe_device.c > +++ b/drivers/gpu/drm/xe/xe_device.c > @@ -101,6 +101,8 @@ static void xe_file_close(struct drm_device *dev, struct drm_file *file) > struct xe_exec_queue *q; > unsigned long idx; > > + xe_pm_runtime_get(xe); > + > /* > * No need for exec_queue.lock here as there is no contention for it > * when FD is closing as IOCTLs presumably can't be modifying the > @@ -126,6 +128,8 @@ static void xe_file_close(struct drm_device *dev, struct drm_file *file) > > xe_drm_client_put(xef->client); > kfree(xef); > + > + xe_pm_runtime_put(xe); > } > > static const struct drm_ioctl_desc xe_ioctls[] = { > diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c > index 7d2e937da1d8..e1d179fb7f43 100644 > --- a/drivers/gpu/drm/xe/xe_guc_ct.c > +++ b/drivers/gpu/drm/xe/xe_guc_ct.c > @@ -327,6 +327,8 @@ static void xe_guc_ct_set_state(struct xe_guc_ct *ct, > xe_gt_assert(ct_to_gt(ct), ct->g2h_outstanding == 0 || > state == XE_GUC_CT_STATE_STOPPED); > > + if (ct->g2h_outstanding) > + xe_pm_runtime_put(ct_to_xe(ct)); > ct->g2h_outstanding = 0; > ct->state = state; > > @@ -499,6 +501,9 @@ static void __g2h_reserve_space(struct xe_guc_ct *ct, u32 g2h_len, u32 num_g2h) > if (g2h_len) { So we can also have guc messages for which we don't expect a response (g2h_len=0)? How do we track those? Or maybe guc itself will take care to process them as we suspend it? Anyway, Reviewed-by: Matthew Auld > lockdep_assert_held(&ct->fast_lock); > > + if (!ct->g2h_outstanding) > + xe_pm_runtime_get_noresume(ct_to_xe(ct)); > + > ct->ctbs.g2h.info.space -= g2h_len; > ct->g2h_outstanding += num_g2h; > } > @@ -511,7 +516,8 @@ static void __g2h_release_space(struct xe_guc_ct *ct, u32 g2h_len) > ct->ctbs.g2h.info.size - ct->ctbs.g2h.info.resv_space); > > ct->ctbs.g2h.info.space += g2h_len; > - --ct->g2h_outstanding; > + if (!--ct->g2h_outstanding) > + xe_pm_runtime_put(ct_to_xe(ct)); > } > > static void g2h_release_space(struct xe_guc_ct *ct, u32 g2h_len) > diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c > index 860405527115..993d0344dc88 100644 > --- a/drivers/gpu/drm/xe/xe_guc_submit.c > +++ b/drivers/gpu/drm/xe/xe_guc_submit.c > @@ -1402,6 +1402,8 @@ static void guc_exec_queue_process_msg(struct xe_sched_msg *msg) > default: > XE_WARN_ON("Unknown message type"); > } > + > + xe_pm_runtime_put(guc_to_xe(exec_queue_to_guc(msg->private_data))); > } > > static const struct drm_sched_backend_ops drm_sched_ops = { > @@ -1492,6 +1494,8 @@ static void guc_exec_queue_kill(struct xe_exec_queue *q) > static void guc_exec_queue_add_msg(struct xe_exec_queue *q, struct xe_sched_msg *msg, > u32 opcode) > { > + xe_pm_runtime_get_noresume(guc_to_xe(exec_queue_to_guc(q))); > + > INIT_LIST_HEAD(&msg->link); > msg->opcode = opcode; > msg->private_data = q;