From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A44EC531DF for ; Fri, 16 Aug 2024 14:02:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E14B10E797; Fri, 16 Aug 2024 14:02:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sntech.de header.i=@sntech.de header.b="vwlhcw/j"; dkim-atps=neutral X-Greylist: delayed 1678 seconds by postgrey-1.36 at gabe; Fri, 16 Aug 2024 14:02:32 UTC Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id E29C410E7A0; Fri, 16 Aug 2024 14:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6APiPsl1dk8hQTUQIp5bKhxGcpS03CWAMAQchIn+9+A=; b=vwlhcw/j12UiyS4tp3lQKpH1A3 KHBdt7G5yTSG50550RFm+BIulA4G2eFh/eA/vcFBbBwmlq+2Kx9Qdl/YsMiR1BkFFvHRDN/kg5YYd lBb79ICOHR91T9X/LaVainI0wouXePAU8MpMvozCBFlZK7NZGME5qiLS4fPxEqQSQvEMoDlLruzbq cwv4U4c1/FlatNReWkKBlNZqfWIGLPEVUbnPXRC+rxwYo3yMULGkA/MZCYdzVWM/OpP2NN6ZmWtNU ZqdtR+PBY72bBd7QcG7NdqUESP49CYleEC6NEWkfr22DJTEOYsWkm1nqiTHOSinq/YLJN8BePuPxc jRqRLz0A==; Received: from i53875a9f.versanet.de ([83.135.90.159] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sex67-0002U1-4U; Fri, 16 Aug 2024 15:34:31 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com, javierm@redhat.com, Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Thomas Zimmermann , Sandy Huang , Andy Yan Subject: Re: [PATCH 38/86] drm/rockchip: Run DRM default client setup Date: Fri, 16 Aug 2024 15:34:29 +0200 Message-ID: <2949271.e9J7NaK4W3@diego> In-Reply-To: <20240816125408.310253-39-tzimmermann@suse.de> References: <20240816125408.310253-1-tzimmermann@suse.de> <20240816125408.310253-39-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Am Freitag, 16. August 2024, 14:23:04 CEST schrieb Thomas Zimmermann: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. >=20 > Signed-off-by: Thomas Zimmermann > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: Andy Yan I've looked up the whole patchseries and while I can't say overly much about the core changes, at least for the Rockchip driver, things look like they'll stay the same even after those changes are applied, so Acked-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/dr= m/rockchip/rockchip_drm_drv.c > index 44d769d9234d..83ea6cc8cd21 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -17,6 +17,7 @@ > #include > =20 > #include > +#include > #include > #include > #include > @@ -191,7 +192,7 @@ static int rockchip_drm_bind(struct device *dev) > if (ret) > goto err_kms_helper_poll_fini; > =20 > - drm_fbdev_dma_setup(drm_dev, 0); > + drm_client_setup(drm_dev, NULL); > =20 > return 0; > err_kms_helper_poll_fini: > @@ -226,6 +227,7 @@ static const struct drm_driver rockchip_drm_driver = =3D { > .driver_features =3D DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC, > .dumb_create =3D rockchip_gem_dumb_create, > .gem_prime_import_sg_table =3D rockchip_gem_prime_import_sg_table, > + DRM_FBDEV_DMA_DRIVER_OPS, > .fops =3D &rockchip_drm_driver_fops, > .name =3D DRIVER_NAME, > .desc =3D DRIVER_DESC, >=20