Re: [PATCH 1/6] drm/tests/drm_buddy: fix 32b build

[Matthew Auld <matthew.auld@intel.com>]

Hi,

On 26/02/2024 10:38, Geert Uytterhoeven wrote:
> Hi Matthew,
> 
> On Mon, Feb 26, 2024 at 10:58 AM Matthew Auld <matthew.auld@intel.com> wrote:
>> On 19/02/2024 12:24, Matthew Auld wrote:
>>> On 19/02/2024 10:48, Matthew Auld wrote:
>>>> On 19/02/2024 10:30, Christian König wrote:
>>>>> Am 19.02.24 um 11:28 schrieb Matthew Auld:
>>>>>> On 19/02/2024 09:53, Christian König wrote:
>>>>>>> Am 19.02.24 um 10:42 schrieb Matthew Auld:
>>>>>>>> On 15/02/2024 17:44, Matthew Auld wrote:
>>>>>>>>> Doesn't seem to compile on 32b, presumably due to u64 mod/division.
>>>>>>>>> Simplest is to just switch over to u32 here. Also make print
>>>>>>>>> modifiers
>>>>>>>>> consistent with that.
>>>>>>>>>
>>>>>>>>> Fixes: a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous
>>>>>>>>> test")
>>>>>>>>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>>>>>>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>>>>>>>> Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
>>>>>>>>> Cc: Christian König <christian.koenig@amd.com>
>>>>>>>>> Cc: Maxime Ripard <mripard@redhat.com>
>>>>>>>>
>>>>>>>> Any chance someone can push just this single patch here, since it
>>>>>>>> fixes 32b build? It already has an r-b from Arun.
>>>>>>>
>>>>>>> Already working on this. Just give me a few more minutes.
>>>>>>
>>>>>> Thanks.
>>>>>
>>>>> No, problem. I would have pushed this earlier, but my build server
>>>>> doesn't want to work any more. Looks like the SSD has passed its
>>>>> warranty :(
>>>>>
>>>>> Should I push the other three patches to drm-misc-fixes as well? I
>>>>> currently can't even build test them.
>>>>
>>>> Need to send a v2 for that. One minor change in the test just to be
>>>> consistent with using u32. Thanks.
>>>
>>> Sent v2. If you could push that when you get a chance. Thanks.
>>>
>>> https://patchwork.freedesktop.org/series/130075/
>>
>> Gentle ping on merging v2.
> 
> Your v1 and a fix from Linus already made it upstream:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/gpu/drm/tests?h=v6.8-rc6

Ah, right. I meant v2 for the remaining drm_buddy patches in this series:
https://patchwork.freedesktop.org/series/130075/

> 
> Gr{oetje,eeting}s,
> 
>                          Geert
>