Re: CI.checkpatch: warning for drm/xe: Expose number of dss per group and helpers

["Summers, Stuart" <stuart.summers@intel.com>]

On Mon, 2024-01-29 at 22:37 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/xe: Expose number of dss per group and helpers
> URL   : https://patchwork.freedesktop.org/series/129283/
> State : warning
> 
> == Summary ==
> 
> + KERNEL=/kernel
> + git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
> Cloning into 'mt'...
> warning: redirecting to
> https://gitlab.freedesktop.org/drm/maintainer-tools.git/
> + git -C mt rev-list -n1 origin/master
> 35591fb8b4d5305b37ce31483f85ac0956eaa536
> + cd /kernel
> + git config --global --add safe.directory /kernel
> + git log -n1
> commit 9f286800a5b3e23be808e8961f282ad855819293
> Author: Zhanjun Dong <zhanjun.dong@intel.com>
> Date:   Mon Jan 29 14:34:03 2024 -0800
> 
>     drm/xe: Expose number of dss per group and helpers
>     
>     Expose helper for dss per group, features like GuC register
>     capture will need this info to prepare buffer required.
>     
>     Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> + /mt/dim checkpatch f4c0dac89bd3cd02a1afe5e7a91ed4bf8de4afc6 drm-
> intel
> 9f286800a drm/xe: Expose number of dss per group and helpers
> -:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ss_' - possible
> side-effects?
> #97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
> +#define for_each_ss_steering(ss_, gt_, group_, instance_) \
> +       for (ss_ = 0, xe_gt_get_ss_steering(gt_, 0, &group_,
> &instance_); \
> +            ss_ < XE_MAX_DSS_FUSE_BITS; \
> +            ss_++, xe_gt_get_ss_steering(gt_, ss_, &group_,
> &instance_)) \
> +               for_each_if(_HAS_SS(gt_, group_, instance_))
> 
> -:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt_' - possible
> side-effects?
> #97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
> +#define for_each_ss_steering(ss_, gt_, group_, instance_) \
> +       for (ss_ = 0, xe_gt_get_ss_steering(gt_, 0, &group_,
> &instance_); \
> +            ss_ < XE_MAX_DSS_FUSE_BITS; \
> +            ss_++, xe_gt_get_ss_steering(gt_, ss_, &group_,
> &instance_)) \
> +               for_each_if(_HAS_SS(gt_, group_, instance_))
> 
> -:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'group_' - possible
> side-effects?
> #97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
> +#define for_each_ss_steering(ss_, gt_, group_, instance_) \
> +       for (ss_ = 0, xe_gt_get_ss_steering(gt_, 0, &group_,
> &instance_); \
> +            ss_ < XE_MAX_DSS_FUSE_BITS; \
> +            ss_++, xe_gt_get_ss_steering(gt_, ss_, &group_,
> &instance_)) \
> +               for_each_if(_HAS_SS(gt_, group_, instance_))

Were you planning on addressing the checkpatch concerns here?

-Stuart

> 
> -:97: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'group_' may be
> better as '(group_)' to avoid precedence issues
> #97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
> +#define for_each_ss_steering(ss_, gt_, group_, instance_) \
> +       for (ss_ = 0, xe_gt_get_ss_steering(gt_, 0, &group_,
> &instance_); \
> +            ss_ < XE_MAX_DSS_FUSE_BITS; \
> +            ss_++, xe_gt_get_ss_steering(gt_, ss_, &group_,
> &instance_)) \
> +               for_each_if(_HAS_SS(gt_, group_, instance_))
> 
> -:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'instance_' -
> possible side-effects?
> #97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
> +#define for_each_ss_steering(ss_, gt_, group_, instance_) \
> +       for (ss_ = 0, xe_gt_get_ss_steering(gt_, 0, &group_,
> &instance_); \
> +            ss_ < XE_MAX_DSS_FUSE_BITS; \
> +            ss_++, xe_gt_get_ss_steering(gt_, ss_, &group_,
> &instance_)) \
> +               for_each_if(_HAS_SS(gt_, group_, instance_))
> 
> -:97: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'instance_' may be
> better as '(instance_)' to avoid precedence issues
> #97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
> +#define for_each_ss_steering(ss_, gt_, group_, instance_) \
> +       for (ss_ = 0, xe_gt_get_ss_steering(gt_, 0, &group_,
> &instance_); \
> +            ss_ < XE_MAX_DSS_FUSE_BITS; \
> +            ss_++, xe_gt_get_ss_steering(gt_, ss_, &group_,
> &instance_)) \
> +               for_each_if(_HAS_SS(gt_, group_, instance_))
> 
> total: 0 errors, 0 warnings, 6 checks, 99 lines checked
> 
>