Re: [PATCH 1/2] drm/i915/dmc: Remove invalid PIPEDMC interrupt bits

Dibin Moolakadan Subrahmanian
2026-03-12T12:24:37Z

On 12-03-2026 08:40, Kandpal, Suraj wrote:
>> Subject: [PATCH 1/2] drm/i915/dmc: Remove invalid PIPEDMC interrupt bits
>>
>> On display version 35+ PIPEDMC_ATS_FAULT and PIPEDMC_GTT_FAULT
>> interrupt bits are no longer defined.
>>
>> Update the interrupt mask to drop these.
>>
> Add the Bspec link for register in commit message
> so that reviewer can verify this if required in this case.
>
> Bspec: 70296

I will add Bspec number.

Regards,
Dibin

> Otherwise LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
>
>> Signed-off-by: Dibin Moolakadan Subrahmanian
>> <dibin.moolakadan.subrahmanian@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dmc.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
>> b/drivers/gpu/drm/i915/display/intel_dmc.c
>> index c3b411259a0c..38b284a0db82 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>> @@ -509,6 +509,9 @@ static void pipedmc_clock_gating_wa(struct
>> intel_display *display, bool enable)
>>
>> static u32 pipedmc_interrupt_mask(struct intel_display *display) {
>> + if (DISPLAY_VER(display) >= 35)
>> + return PIPEDMC_FLIPQ_PROG_DONE;
>> +
>> /*
>> * FIXME PIPEDMC_ERROR not enabled for now due to LNL pipe B
>> * triggering it during the first DC state transition. Figure
>> --
>> 2.43.0