Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Filipchuk <julia.filipchuk@intel.com>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 1/3] drm/xe/gsc: Make GSC FW load optional for newer platforms
Date: Fri, 9 Jan 2026 07:52:40 -0800	[thread overview]
Message-ID: <2d9aa2eb-bc17-4717-8189-f14049c8126d@intel.com> (raw)
In-Reply-To: <20260108011340.2562349-6-daniele.ceraolospurio@intel.com>

On 1/7/2026 5:13 PM, Daniele Ceraolo Spurio wrote:
> diff --git a/drivers/gpu/drm/xe/xe_gsc.c b/drivers/gpu/drm/xe/xe_gsc.c
> index a3157b0fe791..8ad27c884f68 100644
> --- a/drivers/gpu/drm/xe/xe_gsc.c
> +++ b/drivers/gpu/drm/xe/xe_gsc.c
> @@ -414,15 +414,16 @@ int xe_gsc_init(struct xe_gsc *gsc)
>  	}
>  
>  	/*
> -	 * Some platforms can have GuC but not GSC. That would cause
> -	 * xe_uc_fw_init(gsc) to return a "not supported" failure code and abort
> -	 * all firmware loading. So check for GSC being enabled before
> -	 * propagating the failure back up. That way the higher level will keep
> -	 * going and load GuC as appropriate.
> +	 * Starting from BMG the GSC is no longer needed for MC6 entry, so the
> +	 * only missing features if the FW is lacking would be the content
> +	 * protection ones. This is acceptable, si we allow the driver load to
correct 'si' to be 'since'.


With minor change to documentation. (Can be rolled into next patch).
Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>




  parent reply	other threads:[~2026-01-09 15:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08  1:13 [PATCH 0/3] Enable GSC loading and PXP for PTL Daniele Ceraolo Spurio
2026-01-08  1:13 ` [PATCH 1/3] drm/xe/gsc: Make GSC FW load optional for newer platforms Daniele Ceraolo Spurio
2026-01-08 14:35   ` Rodrigo Vivi
2026-01-08 16:36     ` Daniele Ceraolo Spurio
2026-01-08 20:27       ` Rodrigo Vivi
2026-01-09 15:52   ` Julia Filipchuk [this message]
2026-01-08  1:13 ` [PATCH 2/3] drm/xe/ptl: Define GSC for PTL Daniele Ceraolo Spurio
2026-01-09 15:41   ` Julia Filipchuk
2026-01-08  1:13 ` [PATCH 3/3] drm/xe/ptl: Enable PXP " Daniele Ceraolo Spurio
2026-01-08 14:35   ` Rodrigo Vivi
2026-01-08  1:20 ` ✓ CI.KUnit: success for Enable GSC loading and " Patchwork
2026-01-08  1:53 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-08  3:23 ` ✗ Xe.CI.Full: failure " Patchwork
2026-01-08 14:36 ` [PATCH 0/3] " Rodrigo Vivi
2026-01-12 18:03   ` Daniele Ceraolo Spurio
2026-01-10  0:28 ` ✓ CI.KUnit: success for Enable GSC loading and PXP for PTL (rev2) Patchwork
2026-01-10  1:01 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-10  6:49 ` ✗ Xe.CI.Full: failure " Patchwork
2026-01-10 22:10 ` ✓ CI.KUnit: success for Enable GSC loading and PXP for PTL (rev3) Patchwork
2026-01-10 22:53 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-10 23:50 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d9aa2eb-bc17-4717-8189-f14049c8126d@intel.com \
    --to=julia.filipchuk@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox