Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: "Piotr Piórkowski" <piotr.piorkowski@intel.com>
Subject: Re: [PATCH] drm/xe/pf: Use correct function to check LMEM provisioning
Date: Thu, 19 Dec 2024 08:54:43 +0530	[thread overview]
Message-ID: <2e682477-0d3c-4d39-a307-c5e90e0e1b71@intel.com> (raw)
In-Reply-To: <20241216223253.819-1-michal.wajdeczko@intel.com>



On 17-12-2024 04:02, Michal Wajdeczko wrote:
> There is a typo in function call and instead of VF LMEM we were
> looking at VF GGTT provisioning. Fix that.
> 
> Fixes: 234670cea9a2 ("drm/xe/pf: Skip fair VFs provisioning if already provisioned")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> index 65082f12f1a8..bd621df3ab91 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> @@ -2120,7 +2120,7 @@ static int pf_validate_vf_config(struct xe_gt *gt, unsigned int vfid)
>   	valid_any = valid_any || (valid_ggtt && is_primary);
>   
>   	if (IS_DGFX(xe)) {
> -		bool valid_lmem = pf_get_vf_config_ggtt(primary_gt, vfid);
> +		bool valid_lmem = pf_get_vf_config_lmem(primary_gt, vfid);

Looks Good.
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   
>   		valid_any = valid_any || (valid_lmem && is_primary);
>   		valid_all = valid_all && valid_lmem;


      parent reply	other threads:[~2024-12-19  3:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 22:32 [PATCH] drm/xe/pf: Use correct function to check LMEM provisioning Michal Wajdeczko
2024-12-17  1:05 ` ✓ CI.Patch_applied: success for " Patchwork
2024-12-17  1:05 ` ✓ CI.checkpatch: " Patchwork
2024-12-17  1:06 ` ✓ CI.KUnit: " Patchwork
2024-12-17  1:24 ` ✓ CI.Build: " Patchwork
2024-12-17  1:26 ` ✓ CI.Hooks: " Patchwork
2024-12-17  1:28 ` ✓ CI.checksparse: " Patchwork
2024-12-17  1:57 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-17  8:45 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-19 23:08   ` Michal Wajdeczko
2024-12-19  3:24 ` Ghimiray, Himal Prasad [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e682477-0d3c-4d39-a307-c5e90e0e1b71@intel.com \
    --to=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=piotr.piorkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox