Re: [PATCH 2/2] drm/atomic: Add affected colorops with affected planes

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 2/24/2026 2:07 AM, Shankar, Uma wrote:
>> Subject: [PATCH 2/2] drm/atomic: Add affected colorops with affected planes
>>
>> When drm_atomic_add_affected_planes() adds a plane to the atomic state, the
>> associated colorops are not guaranteed to be included.
>> This can leave colorop state out of the transaction when planes are pulled in
>> implicitly (eg. during modeset or internal commits).
>>
>> Also add affected colorops when adding affected planes to keep plane and color
>> pipeline state consistent within the atomic transaction.
> Even though colorop is an object in itself but practically it doesn't have any existence without
> the plane. So to add to state along with plane seems logical. Also its good to handle this in
> drm core than individual drivers.
> 
> The change looks good to me.
> Reviewed-by: Uma Shankar<uma.shankar@intel.com>

Thank you, Uma, for the review.

I have sent another version of the patch where the colorops are added 
only when pipeline is enabled. This avoids flooding of following logs 
when pipeline is disabled.


  [drm:drm_atomic_get_colorop_state] Added [COLOROP:288:1] 
ffff88810db07240 state to ffff88810e040800

Let me know if this looks good for you.

==
Chaitanya