From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Kahola, Mika" <mika.kahola@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/psr: Take the selective fetch area from pipe_src
Date: Thu, 24 Sep 2026 09:45:55 +0000 [thread overview]
Message-ID: <3004b9170f6165076cf9b2b024d6ad32853db56d.camel@intel.com> (raw)
In-Reply-To: <20260923115941.746934-3-mika.kahola@intel.com>
On Wed, 2026-09-23 at 11:59 +0000, Mika Kahola wrote:
> The adjusted mode spans all the joined pipes, so it is the wrong
> reference for a per-pipe area. pipe_src is this pipe's own share.
>
> No functional change, the two are the same without a joiner.
>
> Assisted-by: Copilot:claude-opus-5
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 76260ceb49cb..c1994da38567 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -2912,8 +2912,8 @@ int intel_psr2_sel_fetch_update(struct
> intel_atomic_state *state,
> struct drm_rect display_area = {
> .x1 = 0,
> .y1 = 0,
> - .x2 = crtc_state->hw.adjusted_mode.crtc_hdisplay,
> - .y2 = crtc_state->hw.adjusted_mode.crtc_vdisplay,
> + .x2 = drm_rect_width(&crtc_state->pipe_src),
> + .y2 = drm_rect_height(&crtc_state->pipe_src),
I think you should rather use crtc_state->hw.pipe_mode? Altought
selective update is not supported with pipe scaling.
BR,
Jouni Högander
> };
> bool full_update = false, su_area_changed;
> int i, ret;
next prev parent reply other threads:[~2026-09-24 9:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 11:59 [PATCH 0/5] drm/i915/psr: Panel Replay and PSR2 with the joiner Mika Kahola
2026-09-23 11:59 ` [PATCH] drm/i915/psr: Track all joined pipes for frontbuffer tracking Mika Kahola
2026-09-24 13:02 ` Hogander, Jouni
2026-09-25 7:17 ` Kahola, Mika
2026-09-23 11:59 ` [PATCH] drm/i915/psr: Take the selective fetch area from pipe_src Mika Kahola
2026-09-24 9:45 ` Hogander, Jouni [this message]
2026-09-25 7:00 ` Kahola, Mika
2026-09-23 11:59 ` [PATCH] drm/i915/psr: Merge the selective fetch area across joined pipes Mika Kahola
2026-10-07 10:25 ` Hogander, Jouni
2026-10-09 6:50 ` Kahola, Mika
2026-09-23 11:59 ` [PATCH] drm/i915/psr: Allow Panel Replay and PSR2 with joiner Mika Kahola
2026-09-25 11:06 ` Hogander, Jouni
2026-09-25 12:32 ` Kahola, Mika
2026-09-23 11:59 ` [PATCH] drm/i915/display: Allow forcing the joiner on eDP Mika Kahola
2026-09-25 11:08 ` Hogander, Jouni
2026-09-23 12:08 ` ✓ CI.KUnit: success for " Patchwork
2026-09-23 12:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-24 2:10 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3004b9170f6165076cf9b2b024d6ad32853db56d.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox