From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29759EBFD16 for ; Mon, 13 Apr 2026 08:37:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA34910E37E; Mon, 13 Apr 2026 08:37:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GHclG8bz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07D8810E37C; Mon, 13 Apr 2026 08:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776069444; x=1807605444; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=tVd6/jZRpDKnAI/YHvPhglhntFfBMbgkfsb1Rs7zDKQ=; b=GHclG8bzBRLvA4M2at9YQoiV3eHljH2sJwfngCZo16eT4ef3P0GkCs5v 9zBWIh838okBivmfRZsbBBa4u0nY7kOilwYqKG20JINxcCth8QsDAHr3A LFhF8NwraLdCJyyioK9SXadY0QNsXX+cA1GjTN48k4OUJe3M2lwndCJyD XbFp/Qh5stV6livFGOGW5gqNG5iCrggGXa3U5qH7tId6YpUOT+ukpvSdR BwWIuU4B7Qdih7+qSb705XKFZhaecm+OMwnNca1cLWhxG4Q+RkY8xBLBG U/QqJFlFHiDQswBuelmoyncI5JxuQWoomrh9XqINNcw7xt6IrzK8In659 Q==; X-CSE-ConnectionGUID: xkIzwVy1RcehlavIGGtf/A== X-CSE-MsgGUID: ELaOupLkRiOPOM5PyfL6Mw== X-IronPort-AV: E=McAfee;i="6800,10657,11757"; a="77017256" X-IronPort-AV: E=Sophos;i="6.23,176,1770624000"; d="scan'208";a="77017256" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 01:37:24 -0700 X-CSE-ConnectionGUID: u420NTGmSYi1FkYrBDXE9Q== X-CSE-MsgGUID: E0fXxDEUSBe3uNFVV76wag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,176,1770624000"; d="scan'208";a="229644519" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.182]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 01:37:22 -0700 From: Jani Nikula To: Ankit Nautiyal , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: ville.syrjala@linux.intel.com, arun.r.murthy@intel.com, Ankit Nautiyal Subject: Re: [PATCH 08/12] drm/i915/display: Add HAS_CMN_SDP_TL macro In-Reply-To: <20260413035349.1730312-9-ankit.k.nautiyal@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260413035349.1730312-1-ankit.k.nautiyal@intel.com> <20260413035349.1730312-9-ankit.k.nautiyal@intel.com> Date: Mon, 13 Apr 2026 11:37:19 +0300 Message-ID: <302ca6518ca69410026fade5f37e245a2884b031@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 13 Apr 2026, Ankit Nautiyal wrote: > Add a helper macro to detect CMN SDP TL support on platforms with display > version 35 and above. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_display_device.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h > index 9338ea087e92..36a8a956f54a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_device.h > +++ b/drivers/gpu/drm/i915/display/intel_display_device.h > @@ -154,6 +154,7 @@ struct intel_display_platforms { > #define HAS_CASF(__display) (DISPLAY_VER(__display) >= 20) > #define HAS_CDCLK_CRAWL(__display) (DISPLAY_INFO(__display)->has_cdclk_crawl) > #define HAS_CDCLK_SQUASH(__display) (DISPLAY_INFO(__display)->has_cdclk_squash) > +#define HAS_CMN_SDP_TL(__display) (DISPLAY_VER(__display) >= 35) Even if the register is called CMN, we can actually use the word COMMON here. > #define HAS_CMRR(__display) (DISPLAY_VER(__display) >= 20) > #define HAS_CMTG(__display) (!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13) > #define HAS_CUR_FBC(__display) (!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13)) -- Jani Nikula, Intel