From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACA23C5B572 for ; Thu, 13 Aug 2026 13:33:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67A2410F337; Thu, 13 Aug 2026 13:33:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DUV61yfQ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51A1A10F337 for ; Thu, 13 Aug 2026 13:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786628023; x=1818164023; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=epH6vFa0HkpwsFzIOrNL7TeqbXaFxi/DrpmSi//FGI4=; b=DUV61yfQtfdgxlo9/dpEK+DEjEhjnq324dIg4YF/fwQv7R3DI7wJ/cCf r4Q2Gs00+WtMCD5IlkD0mruahZrkbfnK+cPddu6xnLNmHjHq8zWT6MU+p X1syUZORpuJtnzgwwJSnTFHKWdW4g0KQM3t25dCfuESnE5DX+uZ7FuCyT vkh0GXhvOsovBaDRKmAGDv//5Big9PwOUOGHhrkb3jRKpYEf7iQmeE7WR jemcQAgcl9PHrd/dEwKGtyXLCQjcQ/w04RaJkuS4jUPCjie4zJNDcJlmP lQSBK9qhCccabykj8qBEm8lnmMphSEmnFkTjsfvtHEsnL5G01V3vj8MqF A==; X-CSE-ConnectionGUID: Zw12MPxSTMefPi47SNS1GA== X-CSE-MsgGUID: Dbb623ZiQgOqIHNvjtxlGg== X-IronPort-AV: E=McAfee;i="6800,10657,11874"; a="86320534" X-IronPort-AV: E=Sophos;i="6.25,221,1779174000"; d="scan'208,217";a="86320534" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2026 06:33:43 -0700 X-CSE-ConnectionGUID: TKw3m/QFThWBcbMvfzptag== X-CSE-MsgGUID: 3i13lLYoQfm08hTtxZa/fA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,221,1779174000"; d="scan'208,217";a="259697671" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2026 06:33:43 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 06:33:42 -0700 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 06:33:42 -0700 Received: from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.22) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 06:33:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q75mzjlZxQG9Yr7Ujgf+ajVl3nitASKWM27LLDdRvZ20lPTuOOir2W2UIqPyzk1AIMF6z6aAFF8rc4Nz7fzdcYOvP7gU9EJd5J9N4goE4akD+wiKd9mwN+fGsQj2ehC2D6Z0t2ZdxdqR/IndybTD//TgF5HxV+oBMp8eufUslbDdq8JX0jfTihdQqAObWd+U2RLnjjQe4cP1RX5RVcCRrevhg+dx9ZocAz8lUwRxd0EOet/sjlPqk7vCCzVfdLfqUCFdECRwIEKxxrTaKei4k7LpdZrfeCG1PKs5l160V+VCutdyl4ISENqj681HPF1wE8ZbYIYQO6rbmq07fNh0WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YP7au4msvyfB2g8TXJ/Yn53+W/QyWYiJp1olCHk/PU0=; b=JQYcRTnwMES2PzTONan0AdvzIrN1yowTecbYzRFS+BMSjN9xOmmC2O8c5pRI6hYXF88j3l2cgH6nt/tX+AXnH8RZv5RDFXxdBKy+XVhNhwrEwpPiVgw7qr7kPXpCg/5Zrr7OzVfDpRpJoc8lPWTMVF61SoKe6NBbnsyotIIOgMgxrbIhzCxWt349TX7du0ohD51xAvzKB5dHLri3+rxh0y6z7yyERcKxMDg+zqmwI3XDFWemqB1bfshk10CCbpDYR2WhW+Xt7DSEYby3Ox3GPM9/f5+hBzblAFqu2Bh9c6wel+z0eOTnPuH+G+hmUr4r8NbrMARuvBvhM9iu0X6pww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MN0PR11MB6207.namprd11.prod.outlook.com (2603:10b6:208:3c5::21) by LV2PR11MB6071.namprd11.prod.outlook.com (2603:10b6:408:178::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.12; Thu, 13 Aug 2026 13:33:39 +0000 Received: from MN0PR11MB6207.namprd11.prod.outlook.com ([fe80::52eb:929f:a8b2:139d]) by MN0PR11MB6207.namprd11.prod.outlook.com ([fe80::52eb:929f:a8b2:139d%5]) with mapi id 15.21.0292.024; Thu, 13 Aug 2026 13:33:39 +0000 Content-Type: multipart/alternative; boundary="------------Ingd0F4eWKn1z0adMFPgvy3C" Message-ID: <30c300a4-e743-4322-a1ab-f8edf2b81b40@intel.com> Date: Thu, 13 Aug 2026 19:03:29 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/32] drm/xe/log: Add structured SIGID error logging infrastructure To: Michal Wajdeczko , CC: Rodrigo Vivi , Riana Tauro , Stuart Summers , "Yoni Levitt" , Aravind Iddamsetty , Raag Jadav References: <20260812191450.11690-1-michal.wajdeczko@intel.com> <20260812191450.11690-3-michal.wajdeczko@intel.com> Content-Language: en-US From: "Mallesh, Koujalagi" In-Reply-To: <20260812191450.11690-3-michal.wajdeczko@intel.com> X-ClientProxiedBy: MA5P287CA0153.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:1d7::8) To MN0PR11MB6207.namprd11.prod.outlook.com (2603:10b6:208:3c5::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6207:EE_|LV2PR11MB6071:EE_ X-MS-Office365-Filtering-Correlation-Id: cbad82b3-0896-4f7d-bbfd-08def93f7ba8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|23010399003|6133799003|22082099003|18002099003|5023799004|4143699003|8096899003|11063799006|56012099006|10067099003|3023799007; X-Microsoft-Antispam-Message-Info: kLNy3sJBYHJ2GhpPimmDe8J4gArf8mfssr9mGCX2VZ4rsnDodfHRLvm93LGB4WyTnerj60GQYh7L6YKLJt4nH2Kn9QJzNN9JE5u5Te1HdhpuYG54Nu5lgbstNVw9RB4wI3y4pouMQKgMfjoruWTbcgzShUaqdk+KzbOq8RLLFxBBZbm8I/0NOMfBZUHjcFrrav9Wx/ubuD7kpdMmL+0g0UL4dVV6TZqk2El2cmHiYLtMCOiB9hi/7+2FSucfhDRe7lnwL7xQ3eGTsmyDfkZT5dtOh6E3a38HW2kEfSOke3+VJ+/M2DErU9MOw+dqdip0QTDQxOdwnucFTI3yll3WFpdJ/NHCmRvAL2wxa9gOFmShDl8rPQxsa5nc+c5bYg+Ik6qL3kT26Uajz/k8Se/VX2FNyJFvRBb3HJ7OicizcO+xfaPB8o+Dtps07iQEhVaFpg9Yzx4AGNGpAfaXlgnoDUY9NM5r+KRloDP15SqZ59aUOaHowHoAmDShwC0wwMgWHfrqOux4VUo1Fjy7PeZlTIGVoIhpYfhMLDa7XvLUVmFm7y5QXc+WYpFOFqTtj6LuDTyInDwnmBRQl54maDOT2ryXRL1SMxTltWh9IHG5DoV6Qf3cR4B+1vTPCIB0gnBANVg29c5Z26ysKJhER4dX1lWvHAmjqlHu5BPanMQfXl0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR11MB6207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(6133799003)(22082099003)(18002099003)(5023799004)(4143699003)(8096899003)(11063799006)(56012099006)(10067099003)(3023799007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnJQYy9reFBxZkF2b1VwR09oMXVDM3FJRGRvckw3NTcxUm05L2NtTmpaUmND?= =?utf-8?B?VU5pbDlBZlZqd2ZBZVFONkVaaUR5RkxndkxzNjVleGkxRUJRNHhwdlpHSk9O?= =?utf-8?B?RHlKQ0VHZnliR1FHTnh2STZFRkRNQ3MzWG9HYkZuMC9pajFXSC9na0k4SDhW?= =?utf-8?B?YVFONHk5NzZHRk9hdjYyRGNmYkdGREZHam9wS2dUN0Y3SlVIM0g4M0JrNzh6?= =?utf-8?B?S3BDK1IvSkdFNjJjaDRIVXhZNitOS3JJUjZURXc4VFZlL0xtWUFsTkY2Vnht?= =?utf-8?B?VTFMZittWjg3cTVlVTVxYzJQdCtjME1ZODhGay96Z01ZaGxjcWtCL2lMbnF0?= =?utf-8?B?L013Tk9xamY5TlJYajBXbElIcmZCUnRUMXk3dE1YRVVET3o3bU8yWjBGWjl2?= =?utf-8?B?SlVud05RSXpLWEt4cXJsd1lBcndIZ29oaFRvYU1BRE9ycDdqMjgxajBZRmxC?= =?utf-8?B?NHRuTDlYV0VHNDZISjBxNjZ4R3RRM0MwNHZlQVNxaEdhc3V5Ym1kSmx1VFNW?= =?utf-8?B?NWlTSXFLUllqZzZKNFJBdER4eGlpZTZhMk1ud0FYN2dkYWJGWGczN3BXdVBU?= =?utf-8?B?NG9kR0RmNTVOMWFSZDhra1ZOT2RyeFpyQm1DaW9qRmRMSUowclRWUE5xTUxV?= =?utf-8?B?bGlscjJRM1BaWTRYUFJDTU5FdGZFVG9KNFlRUVRFWkYzOXd3TWNrYlRLOHUr?= =?utf-8?B?WmhraFUwNFYvWTM4d1ZhZHgrbEhkdk1tTFRuWnJSandjd2VmajN2SEVNZU9h?= =?utf-8?B?b3dDNjJnVG5yUWtORlJDMjkzZEkxejlJYlZZdkJzMlRHcGVDRFhPeGk4cVJF?= =?utf-8?B?Q2UvWm9ubFIyalVPV2o4M2JkcElHTGVpVHNFaXNVbStneWt1Z2IwSVBteTZv?= =?utf-8?B?VC8xQjhlVGpuK0tEWFovTzRlMHZ2UW40RFRJbGFNZVNOcTdwSlljS2JsV283?= =?utf-8?B?RGM3RFJRb2dZVVc2RGlmZ1Ftdll2MTNrTE83bGM4VGw5WWE5QjVMMmg3dElh?= =?utf-8?B?MERtTWE1M3JsMkY1QmI2VGVLczBUeUZYMitnaERGNmQxN1lEMmJaTUxrS25M?= =?utf-8?B?cEJGUzVqV3M1eG9RVXVON3ZQY2p1S0Y2eGFRZFI4dmNuSk81YXZDSHQzUkM2?= =?utf-8?B?ZkZVNHFodjdaSnR1bUp6d0I0YXJnVUd3UVI0Vk10SFlOalJneFdXK012a1Zq?= =?utf-8?B?UDhmdlFNVEhVRGFURU9BbGZsWHlCaDlONU1yY1crbjJBaGx2cmxKdkVjdGNH?= =?utf-8?B?UXYrbG5Ld2VIdGQxWFlmWDYwY2JXbnBmQkRnaUloUWgyTHg2TzZVYW1BcXEy?= =?utf-8?B?aWRveStlb1hiTFlxOTNaTElVSVI3S1FoWTJzMHRhcVB6VmtBcnNjZXVOL3Qr?= =?utf-8?B?WjJlUWM5RFpCazRHTHBQNGEveTdqYS9OVjBFRTBFOHZyNGFRelZySS9TcmlV?= =?utf-8?B?N0lBMUl0SVUvZGxCVkpheFlhVDd5dWFUVUNZKzRmVTZsQUlLQ1ZjMTd4K01S?= =?utf-8?B?dGdoUlJRR1crRXlyQ2Ewc2tPQVc3T3ZKNlVkZjVaU2syQUVPaTZrcWw4bWVl?= =?utf-8?B?cXNPQ2NwZi9CMS8zQ1JqTzJzSGszbDBMaEhMSDVOKy8xQVpQd3NqQWxZQkdx?= =?utf-8?B?V0tIRmhld05BMzBGS3g2eDlkQnRNckhERHVDTC9JZ0paOHhtRzlWVllSNW5W?= =?utf-8?B?NnBUVUMxdTlwblMrL1VsT1NKOUJ2Y2FYRHRNNkJSaWFQS1VLOEdDK0gyUElq?= =?utf-8?B?dE1UQVRHTDJ1akM0SE5SM2o3bllxYzhWK3V0aEEyK3d5RWMxZmJlSnBXMXQv?= =?utf-8?B?UmVwZWVTY2wvUTIwYmVpclEwazY2YUQxWkFzL0FiVkNFcUJ2K2tsSFdVZVI1?= =?utf-8?B?cy9VTWcvK0NOOFRIZ1JSemxlczJ5UFBLeWJYaWtIRlZLTUxVY25IR3RFSmQr?= =?utf-8?B?aStkSTlUL1M0K2N6Z3Uzd1NTbGY3RUFNdCtkRi92Ny9YSGd4SVV1eXY0S2Zh?= =?utf-8?B?V3ROZTlzcGxqME42YlRtWDJWQi9sZmtRWDNEQURGcnk2QjV4aDNCc0U0bVlv?= =?utf-8?B?bDZyM0drV09lcjZ2ejlPUDlGb2J3UGxIZk5ISUlydEFZWFFjRUVDeW4xU0JG?= =?utf-8?B?eGpUSDVEdVdheHBBdzhwQUNPME5VS1V1bjdWcmZHbGl5b0tyMHVJY0puV1Rl?= =?utf-8?B?QWQ3OGpGSko0YVJiM3pBNmYyblRUTDY4ZSt0T1orbk1aVzhSc0M2SUtycUFF?= =?utf-8?B?cEhkdFI2SGU1VndjTW9xUEhKM2ZiaTVUbVNSN2RseXFyVWpoeWVBM0dWdTdT?= =?utf-8?B?Mmd5V3g3by9HRFBEUHVJaEhxNGJCVlBOa2x1N1kzUWsyMUNjNHRFZDBVQWxu?= =?utf-8?Q?7thVYgggmiAu2KaY=3D?= X-Exchange-RoutingPolicyChecked: dx9Gs1oxhJdZtGs7sapHP7YT8iQVzktiPh79SfJc2kKgOxOrWCNeuUyxBsxJXtzI0KBIAFj7VIad2mkGJbioIKRxiVsEatc3Wam4KH6rcaIwp7f6hZAKeq8M9F7FUO2uQwJOWMVB6Py1SKuKSpDNLSVVQxuEUpeNtUC2Sr/WqdPsSYFTrbke6cgV+WN2qKuO0I6hMXk9XvaDMzCZySxQmgHRdAI2HMjm+MXBQgDlqlx1bWNyG0AcgKhoYKc5lD47bKJC8Wy0r/AxEiikrK//fqAtCqrIiF6yl/bj+wUtQNdQZk9KTJvhKtvW7sdLe8Rh56QbBZ0IojWXujTQeU+3Ig== X-MS-Exchange-CrossTenant-Network-Message-Id: cbad82b3-0896-4f7d-bbfd-08def93f7ba8 X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2026 13:33:39.0973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aYlAucKSgMGBsSIyqpQIoB0BOsfy+BBLT8Kgxs6eR0jJIjZa1C7jwOxx7gj0VnHfdf8wlzo7JffaKXEM9s+z6YtpUpE31jSwABf9FEkSFpI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6071 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" --------------Ingd0F4eWKn1z0adMFPgvy3C Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 13-08-2026 12:44 am, Michal Wajdeczko wrote: > From: Mallesh Koujalagi > > Today the driver reports faults with ad-hoc drm_err()/xe_gt_err() > strings that have no stable shape. That is readable for a human, but it > gives fleet tooling nothing durable to match on: the wording changes > between releases, lines can be rate-limited or dropped under an error > storm, and there is no consistent way to ask "which recognised fault > just happened?". > > Introduce a signature identifier (SIGID): a small, stable integer that > names one recognised Xe fault site and serves as the primary handle for > triage. A SIGID maps, through published end-user documentation, to a > description and a recommended action; the driver only has to emit the > right SIGID next to the usual human-readable text. > > Signed-off-by: Mallesh Koujalagi > Assisted-by: Copilot:Opus-4.8 > Signed-off-by: Rodrigo Vivi > Co-developed-by: Michal Wajdeczko > Signed-off-by: Michal Wajdeczko > Cc: Riana Tauro > Cc: Stuart Summers > --- > Cc: Yoni Levitt > Cc: Aravind Iddamsetty > Cc: Raag Jadav > --- > v2: CORRECTED is still an error (Michal) > prepare to decorate dmesg with comp/loc (Michal) > v3: update SIGID DOC section (Riana/Aravind) > warn about unknown severity (Mallesh) > --- > Documentation/gpu/xe/index.rst | 1 + > Documentation/gpu/xe/xe_sigid.rst | 14 +++ > drivers/gpu/drm/xe/Makefile | 1 + > drivers/gpu/drm/xe/abi/xe_sigid_abi.h | 159 ++++++++++++++++++++++++++ > drivers/gpu/drm/xe/xe_log.c | 138 ++++++++++++++++++++++ > drivers/gpu/drm/xe/xe_log.h | 20 ++++ > 6 files changed, 333 insertions(+) > create mode 100644 Documentation/gpu/xe/xe_sigid.rst > create mode 100644 drivers/gpu/drm/xe/abi/xe_sigid_abi.h > create mode 100644 drivers/gpu/drm/xe/xe_log.c > create mode 100644 drivers/gpu/drm/xe/xe_log.h > > diff --git a/Documentation/gpu/xe/index.rst b/Documentation/gpu/xe/index.rst > index 665c0e93601c..0247a255f7e6 100644 > --- a/Documentation/gpu/xe/index.rst > +++ b/Documentation/gpu/xe/index.rst > @@ -35,3 +35,4 @@ The display, or :ref:`drm-kms`, support for drm/xe is provided by > xe-drm-usage-stats.rst > xe_configfs > xe_gt_stats > + xe_sigid > diff --git a/Documentation/gpu/xe/xe_sigid.rst b/Documentation/gpu/xe/xe_sigid.rst > new file mode 100644 > index 000000000000..45d84a62f185 > --- /dev/null > +++ b/Documentation/gpu/xe/xe_sigid.rst > @@ -0,0 +1,14 @@ > +.. SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +======== > +Xe SIGID > +======== > + > +.. kernel-doc:: drivers/gpu/drm/xe/abi/xe_sigid_abi.h > + :doc: Xe Error Signatures (SIGID) > + > +Signature Identifiers > +===================== > + > +.. kernel-doc:: drivers/gpu/drm/xe/abi/xe_sigid_abi.h > + :internal: > diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile > index 44ed055439d4..92134709d998 100644 > --- a/drivers/gpu/drm/xe/Makefile > +++ b/drivers/gpu/drm/xe/Makefile > @@ -87,6 +87,7 @@ xe-y += xe_bb.o \ > xe_hw_fence.o \ > xe_irq.o \ > xe_late_bind_fw.o \ > + xe_log.o \ > xe_lrc.o \ > xe_mem_pool.o \ > xe_migrate.o \ > diff --git a/drivers/gpu/drm/xe/abi/xe_sigid_abi.h b/drivers/gpu/drm/xe/abi/xe_sigid_abi.h > new file mode 100644 > index 000000000000..93967183ae51 > --- /dev/null > +++ b/drivers/gpu/drm/xe/abi/xe_sigid_abi.h > @@ -0,0 +1,159 @@ > +/* SPDX-License-Identifier: MIT */ > +/* > + * Copyright © 2026 Intel Corporation > + */ > + > +#ifndef _ABI_XE_SIGID_ABI_H_ > +#define _ABI_XE_SIGID_ABI_H_ > + > +/** > + * DOC: Xe Error Signatures (SIGID) > + * > + * What SIGID stands for > + * --------------------- > + * > + * SIGID is short for *Signature Identifier*. It is a small, stable integer > + * that names one of *recognised fault site* -- nothing more. It is the > + * primary handle used for triage and maps directly to specific report site. > + * > + * Numbering > + * --------- > + * > + * SIGIDs are a single flat list numbered sequentially within the assigned range, > + * in the order the fault sites were introduced. Values are stable: once assigned > + * they are only ever appended, never renumbered or reused. A retired fault site > + * SIGID value is deprecated in place, never re-purposed. > + * > + * Why this exists > + * --------------- > + * > + * Today the driver reports faults with ad-hoc ``xe_err()`` / ``xe_gt_err()`` > + * strings that have no stable shape. That is fine for a human reading dmesg, > + * but it gives fleet tooling nothing durable to match on: the wording changes > + * between releases, lines can be rate-limited or dropped under an error storm, > + * and there is no consistent way to ask "which recognised fault just happened?" > + * > + * A SIGID answers exactly that one question, identically across driver and > + * firmware versions, and (eventually) across other Intel devices in a node. > + * > + * What a SIGID is not > + * ------------------- > + * > + * SIGID deliberately does not encode the detailed reason or the outcome. Those > + * are carried alongside it:: > + * > + * SIGID -> which recognised fault site is being reported > + * severity -> how serious this instance is > + * errno -> the failing operation's error, if available, shown with %pe > + * message -> free-form human-readable context > + * > + * Severity is independent of the SIGID. The same SIGID can be reported at > + * different severities depending on the instance and the recovery taken. > + * > + * When to use SIGID logging > + * ------------------------- > + * > + * The xe_log_*() helpers are for these recognised fault sites only -- > + * important, operator-relevant faults and events. The driver's only job is to > + * emit the right SIGID next to the usual human-readable text. > + > + * They are not a replacement for ``xe_info()`` / ``xe_dbg()`` / tracing, nor > + * for one-off diagnostics; using them for ordinary logging would dilute the > + * fault stream. Not every ``xe_err()`` needs to become a SIGID report -- only > + * those that correspond to a published fault sites. > + * > + * SIGID log output (dmesg vs. the machine record) > + * ----------------------------------------------- > + * > + * The dmesg line stays close to a normal xe error message so it remains > + * readable for admins; the only stable, machine-matchable token on it is > + * ``SIGID=`` (``dmesg | grep SIGID=``). > + * > + * The full dmesg line is not an ABI: the surrounding text may change freely, > + * and lines may be dropped. The durable record for tooling is the CPER record > + * carrying the same SIGID (generation is a planned follow-up). > + * > + * How to pick a SIGID (the uniqueness rule) > + * ----------------------------------------- > + * > + * Pick per *report site*, not per incident. Each site emits the single most > + * specific recognised SIGID *for that site* -- so the question is never > + * "classify this whole failure", it is "what does this site detect?", which has + * one answer. A single underlying failure therefore > legitimately produces a + * *chain* of reports from different layers, > each with its own SIGID -- e.g. a + * GuC communication failure is > reported as %XE_SIGID_RUNTIME_FW by the firmware + * path, the failed > recovery as %XE_SIGID_GT_TDR by the reset path, and an + * aborted > bind as %XE_SIGID_PROBE by the probe path. That chain lets triage + * > follow a fault from origin to final effect; it is not a duplicate. + * > + * If a site does not match any defined SIGID, keep using the > ordinary + * ``xe_err()`` / ``xe_gt_err()`` logging rather than > forcing a SIGID: a wrong + * or over-broad classification is harder to > retire than a missing one. When a + * new report site is genuinely > worth triaging, add it to the list below. + * + * Usage of the > existing SIGID reports must reevaluated according to this section + * > after making significant changes to the site that emits this SIGID. + > * + * Scope: software vs hardware emitted signatures + * > ---------------------------------------------- + * + * Some SIGID > represents fault sites that the *driver itself* detects and + * > reports from the software POV: probe abort, wedged, survivability, > driver- + * detected firmware failures, engine TDR, memory faults and > IO/bus faults. + * These are the only values the driver assigns on its > own. + * + * Signatures that *originate* in firmware or hardware are a > different thing: + * they are produced and identified by the firmware > or the hardware itself + * (e.g. via their own records or error > counters), and the driver merely logs + * them as they are given to > us. They are deliberately enumerated separately. + * + * The two > driver-detected firmware report sites below (%XE_SIGID_RUNTIME_FW, + * > %XE_SIGID_DEVICE_FW) are software signatures: they mark that *the > driver* + * observed a firmware problem, not a signature reported by > the firmware. + */ + +/* + * Top level Intel Error Signature > Identifiers. + */ +#define INTEL_SIGID_INVALID 0 +#define > INTEL_SIGID_BATCH 100 +#define INTEL_SIGID_RANGE_START(n) ((n) * > INTEL_SIGID_BATCH) +#define INTEL_SIGID_RANGE_END(n) > (INTEL_SIGID_RANGE_START((n) + 1) - 1) + +/* SIGIDs 1xx are reserved > for Xe GPU software and 2xx for Xe GPU hardware */ +#define > INTEL_SIGID_GPU_XE_SOFTWARE_START INTEL_SIGID_RANGE_START(1) +#define > INTEL_SIGID_GPU_XE_SOFTWARE_END INTEL_SIGID_RANGE_END(1) +#define > INTEL_SIGID_GPU_XE_HARDWARE_START INTEL_SIGID_RANGE_START(2) +#define > INTEL_SIGID_GPU_XE_HARDWARE_END INTEL_SIGID_RANGE_END(2) + +/** + * > enum xe_sigid - Stable Xe Error Signature Identifiers (SIGID). + * > @XE_SIGID_SW: Software component failure. + * @XE_SIGID_PROBE: Device > probe/bind was aborted. + * @XE_SIGID_WEDGED: Device was declared > wedged and is no longer usable. + * @XE_SIGID_SURVIVABILITY: Device > entered survivability mode. + * @XE_SIGID_RUNTIME_FW: Driver-detected > runtime firmware failure, GuC/HuC/GSC. + * @XE_SIGID_DEVICE_FW: > Driver-detected device firmware failure, PCODE/sysctrl. + * > @XE_SIGID_GT_TDR: Engine hang / timeout detection and recovery > (reset). + * @XE_SIGID_MEM_FAULT: VM bind, page fault or GTT fault. + > * @XE_SIGID_IO_BUS: Runtime PCIe / IOMMU / MMIO access fault. + * + * > Each SIGID represents the report sites the driver detects and reports. > + * Values are numbered sequentially, are only ever appended, and are > never + * renumbered or reused. + * + * Firmware- and > hardware-originated signatures are not listed yet here. + */ +enum > xe_sigid { + XE_SIGID_SW = INTEL_SIGID_GPU_XE_SOFTWARE_START, + > XE_SIGID_PROBE = INTEL_SIGID_GPU_XE_SOFTWARE_START + 1, + > XE_SIGID_WEDGED = INTEL_SIGID_GPU_XE_SOFTWARE_START + 2, + > XE_SIGID_SURVIVABILITY = INTEL_SIGID_GPU_XE_SOFTWARE_START + 3, + > XE_SIGID_RUNTIME_FW = INTEL_SIGID_GPU_XE_SOFTWARE_START + 4, + > XE_SIGID_DEVICE_FW = INTEL_SIGID_GPU_XE_SOFTWARE_START + 5, + > XE_SIGID_GT_TDR = INTEL_SIGID_GPU_XE_SOFTWARE_START + 6, + > XE_SIGID_MEM_FAULT = INTEL_SIGID_GPU_XE_SOFTWARE_START + 7, + > XE_SIGID_IO_BUS = INTEL_SIGID_GPU_XE_SOFTWARE_START + 8, +}; + +#endif > diff --git a/drivers/gpu/drm/xe/xe_log.c b/drivers/gpu/drm/xe/xe_log.c > new file mode 100644 index 000000000000..ae4f6e33f5b8 --- /dev/null > +++ b/drivers/gpu/drm/xe/xe_log.c @@ -0,0 +1,138 @@ +// > SPDX-License-Identifier: MIT +/* + * Copyright © 2026 Intel > Corporation + */ + +#include "xe_log.h" > +#include "xe_printk.h" > + > +static void log_emit_cper(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid, > + u32 component, u32 location, const void *data, size_t len, > + struct va_format *vaf) > +{ > + /* TODO */ > +} > + > +static bool is_hw_sigid(enum xe_sigid sigid) > +{ > + return (int)sigid >= INTEL_SIGID_GPU_XE_HARDWARE_START; > +} > + > +static bool is_sev_error(int cper_sev) > +{ > + return cper_sev != CPER_SEV_INFORMATIONAL; > +} > + > +static const char *log_hwe_prefix(int cper_sev, enum xe_sigid sigid) > +{ > + return is_sev_error(cper_sev) && is_hw_sigid(sigid) ? HW_ERR : ""; > +} > + > +static const char *log_sev_prefix(int cper_sev) > +{ > + switch (cper_sev) { > + case CPER_SEV_FATAL: > + return "FATAL "; > + case CPER_SEV_RECOVERABLE: > + return ""; > + case CPER_SEV_CORRECTED: > + return "CORRECTED "; > + case CPER_SEV_INFORMATIONAL: > + return ""; > + default: > + WARN(IS_ENABLED(CONFIG_DRM_XE_DEBUG), "LOG: unknown severity %d\n", cper_sev); > + return ""; > + } > +} > + > +#define __LOG_DRM_PRINTK_FMT(fmt, args...) "[drm] " fmt, ##args > +#define __LOG_DRM_PRINTK_ERR_FMT(fmt, args...) __LOG_DRM_PRINTK_FMT("*ERROR* " fmt, args) > + > +static void log_dmesg_vprintk(struct pci_dev *pdev, int cper_sev, struct va_format *vaf) > +{ > + if (cper_sev == CPER_SEV_INFORMATIONAL) > + pci_info(pdev, __LOG_DRM_PRINTK_FMT("%pV", vaf)); > + else > + pci_err(pdev, __LOG_DRM_PRINTK_ERR_FMT("%pV", vaf)); > +} > + > +static void log_dmesg_printf(struct pci_dev *pdev, int cper_sev, const char *fmt, ...) > +{ > + struct va_format vaf; > + va_list args; > + > + va_start(args, fmt); > + vaf.fmt = fmt; > + vaf.va = &args; > + > + log_dmesg_vprintk(pdev, cper_sev, &vaf); > + > + va_end(args); > +} > + > +static void log_emit_dmesg(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid, > + u32 component, u32 location, const void *data, size_t len, > + struct va_format *vaf) > +{ > + const char *hwe_prefix = log_hwe_prefix(cper_sev, sigid); > + const char *sev_prefix = log_sev_prefix(cper_sev); > + > + /* TODO: add component/location details */ > + > + if (IS_ERR(data)) > + log_dmesg_printf(pdev, cper_sev, "SIGID=%u %s(%pe) %s%pV", > + sigid, sev_prefix, data, hwe_prefix, vaf); > + else if (data && len) > + log_dmesg_printf(pdev, cper_sev, "SIGID=%u %s(%*phN) %s%pV", > + sigid, sev_prefix, (int)len, data, hwe_prefix, vaf); > + else > + log_dmesg_printf(pdev, cper_sev, "SIGID=%u %s%s%pV", > + sigid, sev_prefix, hwe_prefix, vaf); > +} > + > +/** > + * xe_log_emit() - Emit a structured SIGID log entry > + * @pdev: the &pci_dev device > + * @cper_sev: CPER severity (CPER_SEV_FATAL, CPER_SEV_RECOVERABLE, ...) > + * @sigid: signature identifier, see &enum xe_sigid > + * @component: component identifer Typo "identifier" > + * @location: location details of the @component > + * @data: pointer to the additional details, or ERR_PTR, or NULL if not applicable > + * @len: length of the @data in bytes, or 0 if not applicable > + * @fmt: printf-style format string > + * @...: format arguments > + * > + * Emits a dmesg line that includes a single stable, machine-matchable token > + * ``SIGID=`` followed by the optional severity token (like ``FATAL``) and, > + * when @data pointer is set, either the error printed with %pe or a packed hex > + * dump of the @data binary blob. The dmesg line will also include printf-style > + * text message. > + * > + * Note that the full dmesg line, with the free text message, is only a debugging > + * aid, not an interface! Only the ``SIGID=`` token is stable there. > + * The durable machine record is the CPER carrying the same SIGID. > + * > + * Note: generation of the CPER record is a planned follow-up. > + * > + * Examples:: > + * > + * <3> xe 0000:03:00.0: [drm] *ERROR* SIGID=104 FATAL (-EPROTO) Invalid GuC reply Missing TAG: in this case GuC/HuC/GSC: right? > + * <3> xe 0000:03:00.0: [drm] *ERROR* SIGID=106 (-ETIMEDOUT) Engine 'rcs0' hung ditto > + * <6> xe 0000:03:00.0: [drm] SIGID=103 In survivability mode > + */ > +void xe_log_emit(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid, > + u32 component, u32 location, const void *data, size_t len, > + const char *fmt, ...) > +{ > + struct va_format vaf; > + va_list args; > + > + va_start(args, fmt); > + vaf.fmt = fmt; > + vaf.va = &args; > + > + log_emit_dmesg(pdev, cper_sev, sigid, component, location, data, len, &vaf); > + log_emit_cper(pdev, cper_sev, sigid, component, location, data, len, &vaf); > + > + va_end(args); > +} > diff --git a/drivers/gpu/drm/xe/xe_log.h b/drivers/gpu/drm/xe/xe_log.h > new file mode 100644 > index 000000000000..d475e816ee0b > --- /dev/null > +++ b/drivers/gpu/drm/xe/xe_log.h > @@ -0,0 +1,20 @@ > +/* SPDX-License-Identifier: MIT */ > +/* > + * Copyright © 2026 Intel Corporation > + */ > + > +#ifndef _XE_LOG_H_ > +#define _XE_LOG_H_ > + > +#include > + > +#include "abi/xe_sigid_abi.h" > + > +struct pci_dev; > + > +__printf(8, 9) > +void xe_log_emit(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid, > + u32 component, u32 location, const void *data, size_t len, > + const char *fmt, ...); > + > +#endif --------------Ingd0F4eWKn1z0adMFPgvy3C Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On 13-08-2026 12:44 am, Michal Wajdeczko wrote:
From: Mallesh Koujalagi &l=
t;mallesh.koujalagi@intel.com>

Today the driver reports faults with ad-hoc drm_err()/xe_gt_err()
strings that have no stable shape. That is readable for a human, but it
gives fleet tooling nothing durable to match on: the wording changes
between releases, lines can be rate-limited or dropped under an error
storm, and there is no consistent way to ask "which recognised fault
just happened?".

Introduce a signature identifier (SIGID): a small, stable integer that
names one recognised Xe fault site and serves as the primary handle for
triage. A SIGID maps, through published end-user documentation, to a
description and a recommended action; the driver only has to emit the
right SIGID next to the usual human-readable text.

Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Assisted-by: Copilot:Opus-4.8
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Co-developed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>
Cc: Stuart Summers <stuart.summers@intel.com>
---
Cc: Yoni Levitt <yoni.levitt@intel.com>
Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>
---
v2: CORRECTED is still an error (Michal)
    prepare to decorate dmesg with comp/loc (Michal)
v3: update SIGID DOC section (Riana/Aravind)
    warn about unknown severity (Mallesh)
---
 Documentation/gpu/xe/index.rst        |   1 +
 Documentation/gpu/xe/xe_sigid.rst     |  14 +++
 drivers/gpu/drm/xe/Makefile           |   1 +
 drivers/gpu/drm/xe/abi/xe_sigid_abi.h | 159 ++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_log.c           | 138 ++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_log.h           |  20 ++++
 6 files changed, 333 insertions(+)
 create mode 100644 Documentation/gpu/xe/xe_sigid.rst
 create mode 100644 drivers/gpu/drm/xe/abi/xe_sigid_abi.h
 create mode 100644 drivers/gpu/drm/xe/xe_log.c
 create mode 100644 drivers/gpu/drm/xe/xe_log.h

diff --git a/Documentation/gpu/xe/index.rst b/Documentation/gpu/xe/index.rs=
t
index 665c0e93601c..0247a255f7e6 100644
--- a/Documentation/gpu/xe/index.rst
+++ b/Documentation/gpu/xe/index.rst
@@ -35,3 +35,4 @@ The display, or :ref:`drm-kms`, support for drm/xe is pro=
vided by
    xe-drm-usage-stats.rst
    xe_configfs
    xe_gt_stats
+   xe_sigid
diff --git a/Documentation/gpu/xe/xe_sigid.rst b/Documentation/gpu/xe/xe_si=
gid.rst
new file mode 100644
index 000000000000..45d84a62f185
--- /dev/null
+++ b/Documentation/gpu/xe/xe_sigid.rst
@@ -0,0 +1,14 @@
+.. SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+=3D=3D=3D=3D=3D=3D=3D=3D
+Xe SIGID
+=3D=3D=3D=3D=3D=3D=3D=3D
+
+.. kernel-doc:: drivers/gpu/drm/xe/abi/xe_sigid_abi.h
+   :doc: Xe Error Signatures (SIGID)
+
+Signature Identifiers
+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
+
+.. kernel-doc:: drivers/gpu/drm/xe/abi/xe_sigid_abi.h
+   :internal:
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 44ed055439d4..92134709d998 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -87,6 +87,7 @@ xe-y +=3D xe_bb.o \
 	xe_hw_fence.o \
 	xe_irq.o \
 	xe_late_bind_fw.o \
+	xe_log.o \
 	xe_lrc.o \
 	xe_mem_pool.o \
 	xe_migrate.o \
diff --git a/drivers/gpu/drm/xe/abi/xe_sigid_abi.h b/drivers/gpu/drm/xe/abi=
/xe_sigid_abi.h
new file mode 100644
index 000000000000..93967183ae51
--- /dev/null
+++ b/drivers/gpu/drm/xe/abi/xe_sigid_abi.h
@@ -0,0 +1,159 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright =C2=A9 2026 Intel Corporation
+ */
+
+#ifndef _ABI_XE_SIGID_ABI_H_
+#define _ABI_XE_SIGID_ABI_H_
+
+/**
+ * DOC: Xe Error Signatures (SIGID)
+ *
+ * What SIGID stands for
+ * ---------------------
+ *
+ * SIGID is short for *Signature Identifier*. It is a small, stable intege=
r
+ * that names one of *recognised fault site* -- nothing more. It is the
+ * primary handle used for triage and maps directly to specific report sit=
e.
+ *
+ * Numbering
+ * ---------
+ *
+ * SIGIDs are a single flat list numbered sequentially within the assigned=
 range,
+ * in the order the fault sites were introduced. Values are stable: once a=
ssigned
+ * they are only ever appended, never renumbered or reused. A retired faul=
t site
+ * SIGID value is deprecated in place, never re-purposed.
+ *
+ * Why this exists
+ * ---------------
+ *
+ * Today the driver reports faults with ad-hoc ``xe_err()`` / ``xe_gt_err(=
)``
+ * strings that have no stable shape. That is fine for a human reading dme=
sg,
+ * but it gives fleet tooling nothing durable to match on: the wording cha=
nges
+ * between releases, lines can be rate-limited or dropped under an error s=
torm,
+ * and there is no consistent way to ask "which recognised fault just=
 happened?"
+ *
+ * A SIGID answers exactly that one question, identically across driver an=
d
+ * firmware versions, and (eventually) across other Intel devices in a nod=
e.
+ *
+ * What a SIGID is not
+ * -------------------
+ *
+ * SIGID deliberately does not encode the detailed reason or the outcome. =
Those
+ * are carried alongside it::
+ *
+ *   SIGID    -> which recognised fault site is being reported
+ *   severity -> how serious this instance is
+ *   errno    -> the failing operation's error, if available, shown wit=
h %pe
+ *   message  -> free-form human-readable context
+ *
+ * Severity is independent of the SIGID. The same SIGID can be reported at
+ * different severities depending on the instance and the recovery taken.
+ *
+ * When to use SIGID logging
+ * -------------------------
+ *
+ * The xe_log_*() helpers are for these recognised fault sites only --
+ * important, operator-relevant faults and events. The driver's only job i=
s to
+ * emit the right SIGID next to the usual human-readable text.
+
+ * They are not a replacement for ``xe_info()`` / ``xe_dbg()`` / tracing, =
nor
+ * for one-off diagnostics; using them for ordinary logging would dilute t=
he
+ * fault stream. Not every ``xe_err()`` needs to become a SIGID report -- =
only
+ * those that correspond to a published fault sites.
+ *
+ * SIGID log output (dmesg vs. the machine record)
+ * -----------------------------------------------
+ *
+ * The dmesg line stays close to a normal xe error message so it remains
+ * readable for admins; the only stable, machine-matchable token on it is
+ * ``SIGID=3D<n>`` (``dmesg | grep SIGID=3D``).
+ *
+ * The full dmesg line is not an ABI: the surrounding text may change free=
ly,
+ * and lines may be dropped. The durable record for tooling is the CPER re=
cord
+ * carrying the same SIGID (generation is a planned follow-up).
+ *
+ * How to pick a SIGID (the uniqueness rule)
+ * -----------------------------------------
+ *
+ * Pick per *report site*, not per incident. Each site emits the single mo=
st
+ * specific recognised SIGID *for that site* -- so the question is never
+ * "classify this whole failure", it is "what does this sit=
e detect?", which has
+ * one answer. A single underlying failure therefore legitimately produces=
 a
+ * *chain* of reports from different layers, each with its own SIGID -- e.=
g. a
+ * GuC communication failure is reported as %XE_SIGID_RUNTIME_FW by the fi=
rmware
+ * path, the failed recovery as %XE_SIGID_GT_TDR by the reset path, and an
+ * aborted bind as %XE_SIGID_PROBE by the probe path. That chain lets tria=
ge
+ * follow a fault from origin to final effect; it is not a duplicate.
+ *
+ * If a site does not match any defined SIGID, keep using the ordinary
+ * ``xe_err()`` / ``xe_gt_err()`` logging rather than forcing a SIGID: a w=
rong
+ * or over-broad classification is harder to retire than a missing one. Wh=
en a
+ * new report site is genuinely worth triaging, add it to the list below.
+ *
+ * Usage of the existing SIGID reports must reevaluated according to this =
section
+ * after making significant changes to the site that emits this SIGID.
+ *
+ * Scope: software vs hardware emitted signatures
+ * ----------------------------------------------
+ *
+ * Some SIGID represents fault sites that the *driver itself* detects and
+ * reports from the software POV: probe abort, wedged, survivability, driv=
er-
+ * detected firmware failures, engine TDR, memory faults and IO/bus faults=
.
+ * These are the only values the driver assigns on its own.
+ *
+ * Signatures that *originate* in firmware or hardware are a different thi=
ng:
+ * they are produced and identified by the firmware or the hardware itself
+ * (e.g. via their own records or error counters), and the driver merely l=
ogs
+ * them as they are given to us. They are deliberately enumerated separate=
ly.
+ *
+ * The two driver-detected firmware report sites below (%XE_SIGID_RUNTIME_=
FW,
+ * %XE_SIGID_DEVICE_FW) are software signatures: they mark that *the drive=
r*
+ * observed a firmware problem, not a signature reported by the firmware.
+ */
+
+/*
+ * Top level Intel Error Signature Identifiers.
+ */
+#define INTEL_SIGID_INVALID			0
+#define INTEL_SIGID_BATCH			100
+#define INTEL_SIGID_RANGE_START(n)		((n) * INTEL_SIGID_BATCH)
+#define INTEL_SIGID_RANGE_END(n)		(INTEL_SIGID_RANGE_START((n) + 1) - 1)
+
+/* SIGIDs 1xx are reserved for Xe GPU software and 2xx for Xe GPU hardware=
 */
+#define INTEL_SIGID_GPU_XE_SOFTWARE_START	INTEL_SIGID_RANGE_START(1)
+#define INTEL_SIGID_GPU_XE_SOFTWARE_END		INTEL_SIGID_RANGE_END(1)
+#define INTEL_SIGID_GPU_XE_HARDWARE_START	INTEL_SIGID_RANGE_START(2)
+#define INTEL_SIGID_GPU_XE_HARDWARE_END		INTEL_SIGID_RANGE_END(2)
+
+/**
+ * enum xe_sigid - Stable Xe Error Signature Identifiers (SIGID).
+ * @XE_SIGID_SW: Software component failure.
+ * @XE_SIGID_PROBE: Device probe/bind was aborted.
+ * @XE_SIGID_WEDGED: Device was declared wedged and is no longer usable.
+ * @XE_SIGID_SURVIVABILITY: Device entered survivability mode.
+ * @XE_SIGID_RUNTIME_FW: Driver-detected runtime firmware failure, GuC/HuC=
/GSC.
+ * @XE_SIGID_DEVICE_FW: Driver-detected device firmware failure, PCODE/sys=
ctrl.
+ * @XE_SIGID_GT_TDR: Engine hang / timeout detection and recovery (reset).
+ * @XE_SIGID_MEM_FAULT: VM bind, page fault or GTT fault.
+ * @XE_SIGID_IO_BUS: Runtime PCIe / IOMMU / MMIO access fault.
+ *
+ * Each SIGID represents the report sites the driver detects and reports.
+ * Values are numbered sequentially, are only ever appended, and are never
+ * renumbered or reused.
+ *
+ * Firmware- and hardware-originated signatures are not listed yet here.
+ */
+enum xe_sigid {
+	XE_SIGID_SW			=3D INTEL_SIGID_GPU_XE_SOFTWARE_START,
+	XE_SIGID_PROBE			=3D INTEL_SIGID_GPU_XE_SOFTWARE_START + 1,
+	XE_SIGID_WEDGED			=3D INTEL_SIGID_GPU_XE_SOFTWARE_START + 2,
+	XE_SIGID_SURVIVABILITY		=3D INTEL_SIGID_GPU_XE_SOFTWARE_START + 3,
+	XE_SIGID_RUNTIME_FW		=3D INTEL_SIGID_GPU_XE_SOFTWARE_START + 4,
+	XE_SIGID_DEVICE_FW		=3D INTEL_SIGID_GPU_XE_SOFTWARE_START + 5,
+	XE_SIGID_GT_TDR			=3D INTEL_SIGID_GPU_XE_SOFTWARE_START + 6,
+	XE_SIGID_MEM_FAULT		=3D INTEL_SIGID_GPU_XE_SOFTWARE_START + 7,
+	XE_SIGID_IO_BUS			=3D INTEL_SIGID_GPU_XE_SOFTWARE_START + 8,
+};
+
+#endif
diff --git a/drivers/gpu/drm/xe/xe_log.c b/drivers/gpu/drm/xe/xe_log.c
new file mode 100644
index 000000000000..ae4f6e33f5b8
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_log.c
@@ -0,0 +1,138 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright =C2=A9 2026 Intel Corporation
+ */
+
+#include "xe_log.h"
+#include "xe_printk.h"
+
+static void log_emit_cper(struct pci_dev *pdev, int cper_sev, enum xe_sigi=
d sigid,
+			  u32 component, u32 location, const void *data, size_t len,
+			  struct va_format *vaf)
+{
+	/* TODO */
+}
+
+static bool is_hw_sigid(enum xe_sigid sigid)
+{
+	return (int)sigid >=3D INTEL_SIGID_GPU_XE_HARDWARE_START;
+}
+
+static bool is_sev_error(int cper_sev)
+{
+	return cper_sev !=3D CPER_SEV_INFORMATIONAL;
+}
+
+static const char *log_hwe_prefix(int cper_sev, enum xe_sigid sigid)
+{
+	return is_sev_error(cper_sev) && is_hw_sigid(sigid) ? HW_ERR : &q=
uot;";
+}
+
+static const char *log_sev_prefix(int cper_sev)
+{
+	switch (cper_sev) {
+	case CPER_SEV_FATAL:
+		return "FATAL ";
+	case CPER_SEV_RECOVERABLE:
+		return "";
+	case CPER_SEV_CORRECTED:
+		return "CORRECTED ";
+	case CPER_SEV_INFORMATIONAL:
+		return "";
+	default:
+		WARN(IS_ENABLED(CONFIG_DRM_XE_DEBUG), "LOG: unknown severity %d\n&q=
uot;, cper_sev);
+		return "";
+	}
+}
+
+#define __LOG_DRM_PRINTK_FMT(fmt, args...)	"[drm] " fmt, ##args
+#define __LOG_DRM_PRINTK_ERR_FMT(fmt, args...)	__LOG_DRM_PRINTK_FMT("=
*ERROR* " fmt, args)
+
+static void log_dmesg_vprintk(struct pci_dev *pdev, int cper_sev, struct v=
a_format *vaf)
+{
+	if (cper_sev =3D=3D CPER_SEV_INFORMATIONAL)
+		pci_info(pdev, __LOG_DRM_PRINTK_FMT("%pV", vaf));
+	else
+		pci_err(pdev, __LOG_DRM_PRINTK_ERR_FMT("%pV", vaf));
+}
+
+static void log_dmesg_printf(struct pci_dev *pdev, int cper_sev, const cha=
r *fmt, ...)
+{
+	struct va_format vaf;
+	va_list args;
+
+	va_start(args, fmt);
+	vaf.fmt =3D fmt;
+	vaf.va =3D &args;
+
+	log_dmesg_vprintk(pdev, cper_sev, &vaf);
+
+	va_end(args);
+}
+
+static void log_emit_dmesg(struct pci_dev *pdev, int cper_sev, enum xe_sig=
id sigid,
+			   u32 component, u32 location, const void *data, size_t len,
+			   struct va_format *vaf)
+{
+	const char *hwe_prefix =3D log_hwe_prefix(cper_sev, sigid);
+	const char *sev_prefix =3D log_sev_prefix(cper_sev);
+
+	/* TODO: add component/location details */
+
+	if (IS_ERR(data))
+		log_dmesg_printf(pdev, cper_sev, "SIGID=3D%u %s(%pe) %s%pV",
+				 sigid, sev_prefix, data, hwe_prefix, vaf);
+	else if (data && len)
+		log_dmesg_printf(pdev, cper_sev, "SIGID=3D%u %s(%*phN) %s%pV",
+				 sigid, sev_prefix, (int)len, data, hwe_prefix, vaf);
+	else
+		log_dmesg_printf(pdev, cper_sev, "SIGID=3D%u %s%s%pV",
+				 sigid, sev_prefix, hwe_prefix, vaf);
+}
+
+/**
+ * xe_log_emit() - Emit a structured SIGID log entry
+ * @pdev: the &pci_dev device
+ * @cper_sev: CPER severity (CPER_SEV_FATAL, CPER_SEV_RECOVERABLE, ...)
+ * @sigid: signature identifier, see &enum xe_sigid
+ * @component: component identifer
Typo "identifier" 
+ * @location: location details of the @component
+ * @data: pointer to the additional details, or ERR_PTR, or NULL if not ap=
plicable
+ * @len: length of the @data in bytes, or 0 if not applicable
+ * @fmt: printf-style format string
+ * @...: format arguments
+ *
+ * Emits a dmesg line that includes a single stable, machine-matchable tok=
en
+ * ``SIGID=3D<n>`` followed by the optional severity token (like ``F=
ATAL``) and,
+ * when @data pointer is set, either the error printed with %pe or a packe=
d hex
+ * dump of the @data binary blob. The dmesg line will also include printf-=
style
+ * text message.
+ *
+ * Note that the full dmesg line, with the free text message, is only a de=
bugging
+ * aid, not an interface! Only the ``SIGID=3D<n>`` token is stable t=
here.
+ * The durable machine record is the CPER carrying the same SIGID.
+ *
+ * Note: generation of the CPER record is a planned follow-up.
+ *
+ * Examples::
+ *
+ *   <3> xe 0000:03:00.0: [drm] *ERROR* SIGID=3D104 FATAL (-EPROTO) =
Invalid GuC reply

Missing TAG: in this case GuC/HuC/GSC:  

right?

+ *   <3> xe 0000:03:00.0: [drm] *ERROR* SIGID=3D106 (-ETIMEDOUT) Eng=
ine 'rcs0' hung

ditto

+ *   <6> xe 0000:03:00.0: [drm] SIGID=3D103 In survivability mode
+ */
+void xe_log_emit(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid,
+		 u32 component, u32 location, const void *data, size_t len,
+		 const char *fmt, ...)
+{
+	struct va_format vaf;
+	va_list args;
+
+	va_start(args, fmt);
+	vaf.fmt =3D fmt;
+	vaf.va =3D &args;
+
+	log_emit_dmesg(pdev, cper_sev, sigid, component, location, data, len, &am=
p;vaf);
+	log_emit_cper(pdev, cper_sev, sigid, component, location, data, len, &=
;vaf);
+
+	va_end(args);
+}
diff --git a/drivers/gpu/drm/xe/xe_log.h b/drivers/gpu/drm/xe/xe_log.h
new file mode 100644
index 000000000000..d475e816ee0b
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_log.h
@@ -0,0 +1,20 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright =C2=A9 2026 Intel Corporation
+ */
+
+#ifndef _XE_LOG_H_
+#define _XE_LOG_H_
+
+#include <linux/cper.h>
+
+#include "abi/xe_sigid_abi.h"
+
+struct pci_dev;
+
+__printf(8, 9)
+void xe_log_emit(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid,
+		 u32 component, u32 location, const void *data, size_t len,
+		 const char *fmt, ...);
+
+#endif
--------------Ingd0F4eWKn1z0adMFPgvy3C--