From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BBBFCCD1A0 for ; Wed, 18 Sep 2024 11:31:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 35BDD10E589; Wed, 18 Sep 2024 11:31:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="VO0C0OHU"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id B49D510E58A; Wed, 18 Sep 2024 11:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726659071; x=1758195071; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=OJrNEhSOsy3j4Cz2hwE2E5f6GquprjhhwcVphim765M=; b=VO0C0OHU+6Supf53rq2hjr8EFA/b12sTQwdMXApxp4htcx2UxbSdQIoE IrU4BUdcfVA6a4zShp4BlZ1jcJQK7mQsJo2/WALhB04gU12O5nljgHOMG 9Un/seB0vIYWfYcC5RRydGBUv65Cfkh5DtOKKV3/tsoFYvf01sqTlTPRd 14DqLPS4x/EDJO+8QN1VjZGRisJ8umeR5OHbap39X2aU2HGaBV1l7O5IM e2rhKpxcqiwgmL51eq8Li0qMVCI+atGD7tCNsst3b6QAPe1GqMP4VaNtY 2P/AGiIJIHSvPxB6q6sl41FsoIsjgSEIs8iAKa8KDX/riZhTcvZ+rf91v w==; X-CSE-ConnectionGUID: pcv2CanGSeK8T/8Epr726Q== X-CSE-MsgGUID: zOPw7EoBQveOZYxNXjwjgA== X-IronPort-AV: E=McAfee;i="6700,10204,11198"; a="25050560" X-IronPort-AV: E=Sophos;i="6.10,238,1719903600"; d="scan'208";a="25050560" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2024 04:31:10 -0700 X-CSE-ConnectionGUID: QNoauVOSRPOCuXCOB+EF9A== X-CSE-MsgGUID: jXJGSoPdQ7uMSlaK1CbmDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,238,1719903600"; d="scan'208";a="100211240" Received: from carterle-desk.ger.corp.intel.com (HELO [10.245.245.137]) ([10.245.245.137]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2024 04:31:08 -0700 Message-ID: <30f6a93c-eb20-4f48-b006-e8e4fa2315f9@intel.com> Date: Wed, 18 Sep 2024 12:31:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] drm/i915/gem: fix bitwise and logical AND mixup To: Jani Nikula , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Anshuman Gupta , Andi Shyti , stable@vger.kernel.org References: Content-Language: en-GB From: Matthew Auld In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 18/09/2024 12:17, Jani Nikula wrote: > CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When > the wakeref is non-zero, it's either -1 or a dynamically allocated > pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that > the code works by coincidence with the bitwise AND, but with > CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the > condition evaluates to false, and intel_wakeref_auto() doesn't get > called. Switch to the intended logical AND. > > Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend") > Cc: Matthew Auld > Cc: Rodrigo Vivi > Cc: Anshuman Gupta > Cc: Andi Shyti > Cc: # v6.1+ > Signed-off-by: Jani Nikula Reviewed-by: Matthew Auld