Re: [PATCH v10 2/4] drm/doc: Document device wedged event

["André Almeida" <andrealmeid@igalia.com>]

Em 17/12/2024 05:42, Raag Jadav escreveu:
> On Thu, Dec 12, 2024 at 03:50:29PM -0300, André Almeida wrote:
>> Em 28/11/2024 12:37, Raag Jadav escreveu:
>>> Add documentation for device wedged event in a new 'Device wedging'
>>> chapter. The describes basic definitions, prerequisites and consumer
>>> expectations along with an example.
>>>
>>>    v8: Improve documentation (Christian, Rodrigo)
>>>    v9: Add prerequisites section (Christian)
>>> v10: Clarify mmap cleanup and consumer prerequisites (Christian, Aravind)
>>>
>>> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>> ---
>>>    Documentation/gpu/drm-uapi.rst | 112 ++++++++++++++++++++++++++++++++-
>>>    1 file changed, 109 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
>>> index b75cc9a70d1f..da2927cde53d 100644
>>> --- a/Documentation/gpu/drm-uapi.rst
>>> +++ b/Documentation/gpu/drm-uapi.rst
>>> @@ -371,9 +371,115 @@ Reporting causes of resets
>>
>> I think it's a good idea to add a note about "device wedged event" in the
>> section "Device reset > Kernel Mode Driver" since the idea is to explain
>> what should kernel developer add to their kernel drivers to be used when a
>> device resets.
> 
> Wouldn't that be just a repetition of below? Also, I'm not sure if it's a hard
> requirement.
> 

Right, it can get repetitive indeed, no need to apply this suggestion then.