Re: [PATCH 1/1] drm/xe/pat: Add helper to query compression enable status

["Yadav, Sanjay Kumar" <sanjay.kumar.yadav@intel.com>]

On 12-11-2025 09:45, Yadav, Sanjay Kumar wrote:
>
> On 11-11-2025 03:44, Xin Wang wrote:
>> Add xe_pat_index_get_comp_en() helper function to check whether
>> compression is enabled for a given PAT index by extracting the
>> XE2_COMP_EN bit from the PAT table entry.
>>
>> CC: Nitin Gote <nitin.r.gote@intel.com>
>> CC: Sanjay Yadav <sanjay.kumar.yadav@intel.com>
>> CC: Matt Roper <matthew.d.roper@intel.com>
>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>> Signed-off-by: Xin Wang <x.wang@intel.com>
>
> Reviewed-by: Sanjay Yadav <sanjay.kumar.yadav@intel.com>
>
> LGTM
>
>> ---
>>   drivers/gpu/drm/xe/xe_pat.c |  6 ++++++
>>   drivers/gpu/drm/xe/xe_pat.h | 10 ++++++++++
>>   2 files changed, 16 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
>> index 68171cceea18..1b4d5d3def0f 100644
>> --- a/drivers/gpu/drm/xe/xe_pat.c
>> +++ b/drivers/gpu/drm/xe/xe_pat.c
>> @@ -196,6 +196,12 @@ u16 xe_pat_index_get_coh_mode(struct xe_device 
>> *xe, u16 pat_index)
>>       return xe->pat.table[pat_index].coh_mode;
>>   }
>>   +bool xe_pat_index_get_comp_en(struct xe_device *xe, u16 pat_index)
>> +{
>> +    WARN_ON(pat_index >= xe->pat.n_entries);
>> +    return !!(xe->pat.table[pat_index].value & XE2_COMP_EN);
>> +}
>> +
>>   static void program_pat(struct xe_gt *gt, const struct 
>> xe_pat_table_entry table[],
>>               int n_entries)
>>   {
>> diff --git a/drivers/gpu/drm/xe/xe_pat.h b/drivers/gpu/drm/xe/xe_pat.h
>> index 05dae03a5f54..b8559120989e 100644
>> --- a/drivers/gpu/drm/xe/xe_pat.h
>> +++ b/drivers/gpu/drm/xe/xe_pat.h
>> @@ -58,4 +58,14 @@ int xe_pat_dump(struct xe_gt *gt, struct 
>> drm_printer *p);
>>    */
>>   u16 xe_pat_index_get_coh_mode(struct xe_device *xe, u16 pat_index);
>>   +/**
>> + * xe_pat_index_get_comp_en - Extract the compression enable flag for
>> + * the given pat_index.
>> + * @xe: xe device
>> + * @pat_index: The pat_index to query
>> + *
>> + * Return: true if compression is enabled for this pat_index, false 
>> otherwise.
>> + */
>> +bool xe_pat_index_get_comp_en(struct xe_device *xe, u16 pat_index);
>> +
>>   #endif