Re: [PATCH v17 5/7] drm/xe/guc: Move xe_lrc_snapshot to header file

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

On Tue, 2024-08-27 at 14:47 -0700, Zhanjun Dong wrote:
> Move xe_lrc_snapshot structure define to header file, GuC capture
> feature
> need to access structure fields.
> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_lrc.c       | 18 ------------------
>  drivers/gpu/drm/xe/xe_lrc_types.h | 18 +++++++++++++++++-
>  2 files changed, 17 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c
> b/drivers/gpu/drm/xe/xe_lrc.c
> index aec7db39c061..52f8d202e262 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -38,24 +38,6 @@
>  
>  #define LRC_INDIRECT_RING_STATE_SIZE           SZ_4K
>  
> -struct xe_lrc_snapshot {
> -       struct xe_bo *lrc_bo;
> -       void *lrc_snapshot;
> -       unsigned long lrc_size, lrc_offset;
> -
> -       u32 context_desc;
> -       u32 indirect_context_desc;
> -       u32 head;
> -       struct {
> -               u32 internal;
> -               u32 memory;
> -       } tail;
> -       u32 start_seqno;
> -       u32 seqno;
> -       u32 ctx_timestamp;
> -       u32 ctx_job_timestamp;
> -};
> -
>  static struct xe_device *
>  lrc_to_xe(struct xe_lrc *lrc)
>  {
> diff --git a/drivers/gpu/drm/xe/xe_lrc_types.h
> b/drivers/gpu/drm/xe/xe_lrc_types.h
> index 71ecb453f811..011d4607e585 100644
> --- a/drivers/gpu/drm/xe/xe_lrc_types.h
> +++ b/drivers/gpu/drm/xe/xe_lrc_types.h
> @@ -55,6 +55,22 @@ struct xe_lrc {
>         u32 ctx_timestamp;
>  };
>  
> -struct xe_lrc_snapshot;
> +struct xe_lrc_snapshot {
> +       struct xe_bo *lrc_bo;
> +       void *lrc_snapshot;
> +       unsigned long lrc_size, lrc_offset;
> +
> +       u32 context_desc;
> +       u32 indirect_context_desc;
> +       u32 head;
> +       struct {
> +               u32 internal;
> +               u32 memory;
> +       } tail;
> +       u32 start_seqno;
> +       u32 seqno;
> +       u32 ctx_timestamp;
> +       u32 ctx_job_timestamp;
> +};
>  
>  #endif
alan: repeating from v16: alan: i believe it's not acceptable to make
this patch changes independant of where the changes is being used.
From what i recall from our conf-call review last week, this change is
needed by patch #7. That said, i am providing a conditional rb with the
condition that this patch needs to be squashed with patch #7 (i.e. the
patch titled "drm/xe/guc: Plumb GuC-capture into dev coredump"):

Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>