From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, rodrigo.vivi@intel.com,
ville.syrjala@linux.intel.com, maarten.lankhorst@linux.intel.com,
lucas.demarchi@intel.com
Subject: [PATCH 6/6] drm/i915/display: remove the display platform enum as unnecessary
Date: Tue, 18 Jun 2024 17:22:56 +0300 [thread overview]
Message-ID: <323aa570a2cf58cede7fa0ca8bb46a273bad3395.1718719962.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1718719962.git.jani.nikula@intel.com>
The display platform enums are not really needed for anything. Remove.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_device.c | 12 +++---------
drivers/gpu/drm/i915/display/intel_display_device.h | 11 -----------
2 files changed, 3 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
index 954caea38005..6a71e7a8b686 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.c
+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
@@ -22,26 +22,22 @@ __diag_ignore_all("-Woverride-init", "Allow field initialization overrides for d
struct subplatform_desc {
struct intel_display_is is;
- enum intel_display_platform subplatform;
const char *name;
const u16 *pciidlist;
};
#define SUBPLATFORM(_platform, _subplatform) \
- .subplatform = (INTEL_DISPLAY_##_platform##_##_subplatform), \
.name = #_subplatform, \
.is._platform##_##_subplatform = 1
struct platform_desc {
struct intel_display_is is;
- enum intel_display_platform platform;
const char *name;
const struct subplatform_desc *subplatforms;
const struct intel_display_device_info *info; /* NULL for GMD ID */
};
#define PLATFORM(_platform) \
- .platform = (INTEL_DISPLAY_##_platform), \
.name = #_platform, \
.is._platform = 1
@@ -1261,7 +1257,7 @@ find_subplatform_desc(struct pci_dev *pdev, const struct platform_desc *desc)
const struct subplatform_desc *sp;
const u16 *id;
- for (sp = desc->subplatforms; sp && sp->subplatform; sp++)
+ for (sp = desc->subplatforms; sp && sp->pciidlist; sp++)
for (id = sp->pciidlist; *id; id++)
if (*id == pdev->device)
return sp;
@@ -1323,14 +1319,12 @@ void intel_display_device_probe(struct drm_i915_private *i915)
&DISPLAY_INFO(i915)->__runtime_defaults,
sizeof(*DISPLAY_RUNTIME_INFO(i915)));
- drm_WARN_ON(&i915->drm, !desc->platform || !desc->name);
- DISPLAY_RUNTIME_INFO(i915)->platform = desc->platform;
+ drm_WARN_ON(&i915->drm, !desc->name);
display->is = desc->is;
subdesc = find_subplatform_desc(pdev, desc);
if (subdesc) {
- drm_WARN_ON(&i915->drm, !subdesc->subplatform || !subdesc->name);
- DISPLAY_RUNTIME_INFO(i915)->subplatform = subdesc->subplatform;
+ drm_WARN_ON(&i915->drm, !subdesc->name);
merge_display_is(&display->is, &subdesc->is);
}
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
index 73070c8487ff..97033d26c1b3 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.h
+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
@@ -93,14 +93,6 @@ struct drm_printer;
func(DG2_G11) \
func(DG2_G12)
-#define ENUM(x) INTEL_DISPLAY_ ## x,
-
-enum intel_display_platform {
- INTEL_DISPLAY_PLATFORMS(ENUM)
-};
-
-#undef ENUM
-
#define MEMBER(name) u32 name:1;
struct intel_display_is {
@@ -207,9 +199,6 @@ struct intel_display_is {
(DISPLAY_VER(i915) >= (from) && DISPLAY_VER(i915) <= (until))
struct intel_display_runtime_info {
- enum intel_display_platform platform;
- enum intel_display_platform subplatform;
-
struct intel_display_ip_ver {
u16 ver;
u16 rel;
--
2.39.2
next prev parent reply other threads:[~2024-06-18 14:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 14:22 [PATCH 0/6] drm/i915/display: platform identification with display->is.<PLATFORM> Jani Nikula
2024-06-18 14:22 ` [PATCH 1/6] drm/i915/display: use a macro to initialize subplatforms Jani Nikula
2024-06-19 18:29 ` Rodrigo Vivi
2024-06-18 14:22 ` [PATCH 2/6] drm/i915/display: use a macro to define platform enumerations Jani Nikula
2024-06-19 18:29 ` Rodrigo Vivi
2024-06-18 14:22 ` [PATCH 3/6] drm/i915/display: join the platform and subplatform macros Jani Nikula
2024-06-19 18:30 ` Rodrigo Vivi
2024-06-18 14:22 ` [PATCH 4/6] drm/i915/display: add "display is" structure with platform members Jani Nikula
2024-06-19 18:30 ` Rodrigo Vivi
2024-06-27 17:04 ` Lucas De Marchi
2024-06-27 18:48 ` Jani Nikula
2024-06-18 14:22 ` [PATCH 5/6] drm/i915/display: add "is" member to struct intel_display Jani Nikula
2024-06-19 18:36 ` Rodrigo Vivi
2024-06-20 13:05 ` Jani Nikula
2024-06-20 16:09 ` Rodrigo Vivi
2024-06-27 17:06 ` Lucas De Marchi
2024-06-27 18:47 ` Jani Nikula
2024-06-27 21:45 ` Lucas De Marchi
2024-06-27 22:19 ` Jani Nikula
2024-06-18 14:22 ` Jani Nikula [this message]
2024-06-19 18:30 ` [PATCH 6/6] drm/i915/display: remove the display platform enum as unnecessary Rodrigo Vivi
2024-06-18 14:28 ` ✓ CI.Patch_applied: success for drm/i915/display: platform identification with display->is.<PLATFORM> Patchwork
2024-06-18 14:28 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-18 14:29 ` ✓ CI.KUnit: success " Patchwork
2024-06-18 14:41 ` ✓ CI.Build: " Patchwork
2024-06-18 14:43 ` ✗ CI.Hooks: failure " Patchwork
2024-06-18 14:44 ` ✗ CI.checksparse: warning " Patchwork
2024-06-18 15:07 ` ✓ CI.BAT: success " Patchwork
2024-06-19 4:06 ` ✓ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=323aa570a2cf58cede7fa0ca8bb46a273bad3395.1718719962.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox