From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95D63C83F03 for ; Fri, 4 Jul 2025 11:21:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 406E510E9F3; Fri, 4 Jul 2025 11:21:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="pxJFyYR4"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id C712310E9F3 for ; Fri, 4 Jul 2025 11:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gkCpOcT4QrRYj6E8BxjO5UyDY6upqYHPHk5Q+zFM0fg=; b=pxJFyYR4D9Dt9Y7rcaZOnbTRZC mSk6p0a1cXRnK8EVuxSFiswdXSYYwdQRkVSG4GsiKkCQaESXIeDBCN0AxEFIuvraaYnHZjK1GlCEj LMrDUzeZ/35IW7VSB9dqjb55gfAXbfxky70MrJADLhAoGXwKnIRHVaTUCpnGyJMqWVlFXbEWQlMa0 yfnsZfM088AlMdWK9+4tjXJMKKJIVBrNjgjc4D8/X7hqjMR1AYk3x5UIH9ClZXhEhpRQ/Mm055zVe CGNueXSn6r9n1h9kg1Zmf55YCEYOc61MiAkKo896T2Hb8c4vnS/8hELisoja3KEe5an86GT9fmkeW zK5akSSw==; Received: from [81.79.92.254] (helo=[192.168.0.101]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1uXeUI-00CPCz-T3; Fri, 04 Jul 2025 13:21:50 +0200 Message-ID: <32e154a8-4c01-47eb-8ac9-bbdb42a3eeb5@igalia.com> Date: Fri, 4 Jul 2025 12:21:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] drm/xe/gt: Drop third submission for default context To: Lucas De Marchi , intel-xe@lists.freedesktop.org Cc: Matthew Brost , Umesh Nerlige Ramappa References: <20250703-lrc-refactors-v1-0-6aa22f174041@intel.com> <20250703-lrc-refactors-v1-6-6aa22f174041@intel.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <20250703-lrc-refactors-v1-6-6aa22f174041@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 03/07/2025 23:41, Lucas De Marchi wrote: > There's no need to submit the nop job again on the first queue. Any > state needed is already saved when the first LRC is switched out. The > comment is a little misleading regarding indirect W/A: first of all > there's still no indirect W/A enabled and secondly, even after they are, > there's no need to submit this job again for having their state > propagated: the indirect W/A will actually run on every LRC switch. > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/xe/xe_gt.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c > index 67425e37c2187..439e7c703ed84 100644 > --- a/drivers/gpu/drm/xe/xe_gt.c > +++ b/drivers/gpu/drm/xe/xe_gt.c > @@ -361,14 +361,6 @@ int xe_gt_record_default_lrcs(struct xe_gt *gt) > goto put_nop_q; > } > > - /* Reload golden LRC to record the effect of any indirect W/A */ > - err = emit_nop_job(gt, q); > - if (err) { > - xe_gt_err(gt, "hwe %s: emit_nop_job failed (%pe) guc_id=%u\n", > - hwe->name, ERR_PTR(err), q->guc->id); > - goto put_nop_q; > - } > - > xe_map_memcpy_from(xe, default_lrc, > &q->lrc[0]->bo->vmap, > xe_lrc_pphwsp_offset(q->lrc[0]), > Wasn't it also racy to memcpy from q's LRC without guaranteeing context save had completed? I don't think dma_fence_wait in emit_nop_job guarantees it. If that is so this patch should actually have Fixes: added and commit message adjusted accordingly. Regards, Tvrtko