From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: "Piórkowski, Piotr" <piotr.piorkowski@intel.com>,
intel-xe@lists.freedesktop.org
Cc: Stuart Summers <stuart.summers@intel.com>,
Matthew Auld <matthew.auld@intel.com>,
Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Subject: Re: [PATCH v3 1/2] drm/xe: Use dynamic allocation for tile and device VRAM region structures
Date: Tue, 24 Jun 2025 11:46:16 +0200 [thread overview]
Message-ID: <33d3faf0-40b3-400a-be2c-7366e28b7f94@intel.com> (raw)
In-Reply-To: <20250624092213.2876711-2-piotr.piorkowski@intel.com>
On 24.06.2025 11:22, Piórkowski, Piotr wrote:
> diff --git a/drivers/gpu/drm/xe/xe_assert.h b/drivers/gpu/drm/xe/xe_assert.h
> index 68fe70ce2be3..cd63cdd2dc78 100644
> --- a/drivers/gpu/drm/xe/xe_assert.h
> +++ b/drivers/gpu/drm/xe/xe_assert.h
> @@ -145,7 +145,7 @@
> const struct xe_tile *__tile = (tile); \
> char __buf[10] __maybe_unused; \
> xe_assert_msg(tile_to_xe(__tile), condition, "tile: %u VRAM %s\n" msg, \
> - __tile->id, ({ string_get_size(__tile->mem.vram.actual_physical_size, 1, \
> + __tile->id, ({ string_get_size(__tile->mem.vram->actual_physical_size, 1, \
> STRING_UNITS_2, __buf, sizeof(__buf)); __buf; }), ## arg); \
> })
>
this assert will cause NPD on !DGFX, likely you need at least this:
__tile->mem.vram ? __tile->mem.vram->actual_physical_size : 0
next prev parent reply other threads:[~2025-06-24 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 9:22 [PATCH v3 0/2] Cleaning up code related to VRAM regions and its initialization - part 2 Piórkowski, Piotr
2025-06-24 9:22 ` [PATCH v3 1/2] drm/xe: Use dynamic allocation for tile and device VRAM region structures Piórkowski, Piotr
2025-06-24 9:46 ` Michal Wajdeczko [this message]
2025-06-25 9:00 ` Jani Nikula
2025-06-24 9:53 ` Jani Nikula
2025-06-24 9:22 ` [PATCH v3 2/2] drm/xe: Unify the initialization of VRAM regions Piórkowski, Piotr
2025-06-24 10:10 ` Matthew Auld
2025-06-24 12:27 ` ✓ CI.KUnit: success for Cleaning up code related to VRAM regions and its initialization - part 2 (rev6) Patchwork
2025-06-24 13:28 ` ✓ Xe.CI.BAT: " Patchwork
2025-06-25 1:40 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33d3faf0-40b3-400a-be2c-7366e28b7f94@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=piotr.piorkowski@intel.com \
--cc=satyanarayana.k.v.p@intel.com \
--cc=stuart.summers@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox