Re: [PATCH 01/10] drm/xe: Correct BMG VSEC header sizing

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]

On Sat, 31 May 2025, Ilpo Järvinen wrote:

> On Fri, 30 May 2025, Michael J. Ruhl wrote:
> 
> > The intel_vsec_header information for the crashlog feature
> > is incorrect.
> >
> > Update the VSEC header with correct sizing and count.
> 
> Does this warrant a Fixes tag?
>  
> > Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_vsec.c | 20 +++++---------------
> >  1 file changed, 5 insertions(+), 15 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
> > index 3e573b0b7ebd..67238fc57a4d 100644
> > --- a/drivers/gpu/drm/xe/xe_vsec.c
> > +++ b/drivers/gpu/drm/xe/xe_vsec.c
> > @@ -32,28 +32,18 @@ static struct intel_vsec_header bmg_telemetry = {
> >  	.offset = BMG_DISCOVERY_OFFSET,
> >  };
> >  
> > -static struct intel_vsec_header bmg_punit_crashlog = {
> > -	.length = 0x10,
> > +static struct intel_vsec_header bmg_crashlog = {
> > +	.length = 0x18,
> >  	.id = VSEC_ID_CRASHLOG,
> > -	.num_entries = 1,
> > -	.entry_size = 4,
> > +	.num_entries = 2,
> > +	.entry_size = 6,
> >  	.tbir = 0,
> >  	.offset = BMG_DISCOVERY_OFFSET + 0x60,
> >  };
> >  
> > -static struct intel_vsec_header bmg_oobmsm_crashlog = {
> > -	.length = 0x10,
> > -	.id = VSEC_ID_CRASHLOG,
> > -	.num_entries = 1,
> > -	.entry_size = 4,
> > -	.tbir = 0,
> > -	.offset = BMG_DISCOVERY_OFFSET + 0x78,
> > -};
> > -
> >  static struct intel_vsec_header *bmg_capabilities[] = {
> >  	&bmg_telemetry,
> > -	&bmg_punit_crashlog,
> > -	&bmg_oobmsm_crashlog,
> > +	&bmg_crashlog,
> 
> Eh, this change goes way beyond what you said in the changelog, was that 
> intentional? If yes, please describe and justify all the changes (and 
> consider if some of them belong to a separate patch as it sounds like 
> there are two or more changes mixed up into this patch).

In addition, please send the next version to all relevant parties as 
indicated by the get_maintainers.pl script.

-- 
 i.