Re: [PATCH] drm/xe/vm: Add missing pad and extensions check

[Matthew Auld <matthew.auld@intel.com>]

On 31/03/2026 17:44, Jonathan Cavitt wrote:
> Add missing pad and extensions check to xe_vm_get_property_ioctl
> 
> Fixes: 50c577eab051 ("drm/xe/xe_vm: Implement xe_vm_get_property_ioctl")
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Would it make sense to combine this with the other reserved checks?

Either way:
Reviewed-by: Matthew Auld <matthew.auld@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_vm.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 56e2db50bb36..03f129927b0f 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -4159,6 +4159,9 @@ int xe_vm_get_property_ioctl(struct drm_device *drm, void *data,
>   			      args->reserved[2])))
>   		return -EINVAL;
>   
> +	if (XE_IOCTL_DBG(xe, args->pad || args->extensions))
> +		return -EINVAL;
> +
>   	vm = xe_vm_lookup(xef, args->vm_id);
>   	if (XE_IOCTL_DBG(xe, !vm))
>   		return -ENOENT;