Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Randhawa, Jagmeet" <jagmeet.randhawa@intel.com>
To: Matthew Brost <matthew.brost@intel.com>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2 3/6] drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc fini
Date: Tue, 20 Aug 2024 11:02:24 -0700	[thread overview]
Message-ID: <3722c495-1518-4896-b434-6240925abcfb@intel.com> (raw)
In-Reply-To: <20240820172958.1095143-4-matthew.brost@intel.com>


On 8/20/2024 10:29 AM, Matthew Brost wrote:
> Not a big deal if CT is down as driver is unloading, no need to warn.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc_pc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 32e93a8127d4..def503abeed5 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -1042,7 +1042,7 @@ static void xe_guc_pc_fini_hw(void *arg)
>   		return;
>   
>   	XE_WARN_ON(xe_force_wake_get(gt_to_fw(pc_to_gt(pc)), XE_FORCEWAKE_ALL));
> -	XE_WARN_ON(xe_guc_pc_gucrc_disable(pc));
> +	xe_guc_pc_gucrc_disable(pc);
>   	XE_WARN_ON(xe_guc_pc_stop(pc));
>   
>   	/* Bind requested freq to mert_freq_cap before unload */

  reply	other threads:[~2024-08-20 18:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 17:29 [PATCH v2 0/6] Driver load failure fixes Matthew Brost
2024-08-20 17:29 ` [PATCH v2 1/6] drm/xe: Move ggtt_fini to devm managed Matthew Brost
2024-08-23 13:43   ` Lucas De Marchi
2024-08-20 17:29 ` [PATCH v2 2/6] drm/xe: Set firmware state to loadable before registering guc_fini_hw Matthew Brost
2024-08-20 21:04   ` Lucas De Marchi
2024-08-20 17:29 ` [PATCH v2 3/6] drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc fini Matthew Brost
2024-08-20 18:02   ` Randhawa, Jagmeet [this message]
2024-08-20 17:29 ` [PATCH v2 4/6] drm/xe: Move hw_engine_fini to devm managed Matthew Brost
2024-08-20 20:48   ` Lucas De Marchi
2024-08-20 17:29 ` [PATCH v2 5/6] drm/xe: Move HuC init before GuC init Matthew Brost
2024-08-20 20:42   ` Lucas De Marchi
2024-08-20 21:02     ` Matthew Brost
2024-08-20 17:29 ` [PATCH v2 6/6] drm/xe: Update xe_sa to use xe_managed_bo_create_pin_map Matthew Brost
2024-08-20 21:07   ` Lucas De Marchi
2024-08-20 19:07 ` ✓ CI.Patch_applied: success for Driver load failure fixes Patchwork
2024-08-20 19:07 ` ✓ CI.checkpatch: " Patchwork
2024-08-20 19:09 ` ✓ CI.KUnit: " Patchwork
2024-08-20 19:20 ` ✓ CI.Build: " Patchwork
2024-08-20 19:23 ` ✓ CI.Hooks: " Patchwork
2024-08-20 19:24 ` ✓ CI.checksparse: " Patchwork
2024-08-20 19:46 ` ✗ CI.BAT: failure " Patchwork
2024-08-21  2:05 ` ✗ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3722c495-1518-4896-b434-6240925abcfb@intel.com \
    --to=jagmeet.randhawa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox