Re: [PATCH 5/5] drm/xe: Normalize double-underscore include guards to single-underscore

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 30 Mar 2026, Simon Richter <Simon.Richter@hogyros.de> wrote:
> Hi,
>
>>> Six headers use __XE_<NAME>_H__ (double-underscore prefix and suffix) as
>>> their include guards. Normalize them to the single-underscore _XE_<NAME>_H_
>>> convention used by the rest of the xe codebase.
>
> Single underscore followed by capital letter are reserved identifiers in C.

Well, ackshually...

"All identifiers that begin with an underscore and either an uppercase
letter or another underscore are always reserved for any use."

Even so:

$ git grep "#define __" | wc -l
21278

$ git grep "#define _[A-Z]" | wc -l
17886

The only question here is whether to be consistent or not about the
reserved identifier usage. ;)


BR,
Jani.

-- 
Jani Nikula, Intel