Re: [PATCH v6 1/4] drm/xe: Define XE_REG_IS_VALID

["Nilawar, Badal" <badal.nilawar@intel.com>]

On 04-04-2024 15:38, Karthik Poosa wrote:
> Add macro to check if struct xe_reg has valid address.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>   drivers/gpu/drm/xe/regs/xe_reg_defs.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/regs/xe_reg_defs.h b/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> index c89ef2b79a3f..42078643be6b 100644
> --- a/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> @@ -131,4 +131,6 @@ struct xe_reg_mcr {
>   				 .__reg = XE_REG_INITIALIZER(r_,  ##__VA_ARGS__, .mcr = 1)	\
>   				 })
>   
> +#define XE_REG_IS_VALID(r)	((r.addr) ? true : false From patch 2 intention of adding this is to abstract the use of struct 
xe_reg. Since this is macro I don't think this is real abstraction. How 
about using inline function instead of macro?

inline bool xe_reg_is_valid(struct xe_reg)
{
	return (r.raw ? true : false);
}

Badal
> +
>   #endif