From: "David E. Box" <david.e.box@linux.intel.com>
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>,
platform-driver-x86@vger.kernel.org,
intel-xe@lists.freedesktop.org, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, lucas.demarchi@intel.com,
rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com,
airlied@gmail.com, simona@ffwll.ch
Subject: Re: [PATCH v3 07/11] platform/x86/intel/pmt: correct types
Date: Fri, 06 Jun 2025 14:57:27 -0700 [thread overview]
Message-ID: <3b2efd54a826d4e561803220d556619d22784cab.camel@linux.intel.com> (raw)
In-Reply-To: <20250605184444.515556-8-michael.j.ruhl@intel.com>
On Thu, 2025-06-05 at 14:44 -0400, Michael J. Ruhl wrote:
> A couple of auto variables do not match the return types of some of
> the functions.
>
> Update the mismatched types to match.
>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
> drivers/platform/x86/intel/pmt/crashlog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/crashlog.c
> b/drivers/platform/x86/intel/pmt/crashlog.c
> index aa3f57fbe018..a51923d0be72 100644
> --- a/drivers/platform/x86/intel/pmt/crashlog.c
> +++ b/drivers/platform/x86/intel/pmt/crashlog.c
> @@ -136,7 +136,7 @@ static ssize_t
> enable_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> struct intel_pmt_entry *entry = dev_get_drvdata(dev);
> - int enabled = !pmt_crashlog_disabled(entry);
> + bool enabled = !pmt_crashlog_disabled(entry);
>
> return sprintf(buf, "%d\n", enabled);
> }
> @@ -167,7 +167,7 @@ static ssize_t
> trigger_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> struct intel_pmt_entry *entry;
> - int trigger;
> + bool trigger;
>
> entry = dev_get_drvdata(dev);
> trigger = pmt_crashlog_complete(entry);
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
next prev parent reply other threads:[~2025-06-06 21:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 18:44 [PATCH v3 00/11] Crashlog Type1 Version2 support Michael J. Ruhl
2025-06-05 18:44 ` [PATCH v3 01/11] platform/x86/intel: refactor endpoint usage Michael J. Ruhl
2025-06-06 17:54 ` David E. Box
2025-06-06 19:20 ` Ruhl, Michael J
2025-06-09 17:04 ` David E. Box
2025-06-05 18:44 ` [PATCH v3 02/11] platform/x86/intel/pmt: crashlog binary file endpoint Michael J. Ruhl
2025-06-06 19:54 ` David E. Box
2025-06-05 18:44 ` [PATCH v3 03/11] drm/xe: Correct BMG VSEC header sizing Michael J. Ruhl
2025-06-06 21:12 ` David E. Box
2025-06-09 14:41 ` Ruhl, Michael J
2025-06-05 18:44 ` [PATCH v3 04/11] platform/x86/intel/pmt: white space cleanup Michael J. Ruhl
2025-06-06 21:14 ` David E. Box
2025-06-05 18:44 ` [PATCH v3 05/11] platform/x86/intel/pmt: use guard(mutex) Michael J. Ruhl
2025-06-06 21:20 ` David E. Box
2025-06-09 14:42 ` Ruhl, Michael J
2025-06-05 18:44 ` [PATCH v3 06/11] platform/x86/intel/pmt: re-order trigger logic Michael J. Ruhl
2025-06-06 21:49 ` David E. Box
2025-06-05 18:44 ` [PATCH v3 07/11] platform/x86/intel/pmt: correct types Michael J. Ruhl
2025-06-06 21:57 ` David E. Box [this message]
2025-06-05 18:44 ` [PATCH v3 08/11] platform/x86/intel/pmt: decouple sysfs and namespace Michael J. Ruhl
2025-06-05 18:44 ` [PATCH v3 09/11] platform/x86/intel/pmt: add register access helpers Michael J. Ruhl
2025-06-05 18:44 ` [PATCH v3 10/11] platform/x86/intel/pmt: use a version struct Michael J. Ruhl
2025-06-06 22:57 ` David E. Box
2025-06-09 14:43 ` Ruhl, Michael J
2025-06-05 18:44 ` [PATCH v3 11/11] platform/x86/intel/pmt: support BMG crashlog Michael J. Ruhl
2025-06-06 23:21 ` David E. Box
2025-06-09 14:45 ` Ruhl, Michael J
2025-06-05 22:36 ` ✓ CI.Patch_applied: success for Crashlog Type1 Version2 support (rev3) Patchwork
2025-06-05 22:36 ` ✓ CI.checkpatch: " Patchwork
2025-06-05 22:37 ` ✓ CI.KUnit: " Patchwork
2025-06-05 22:48 ` ✓ CI.Build: " Patchwork
2025-06-05 22:50 ` ✓ CI.Hooks: " Patchwork
2025-06-05 22:52 ` ✓ CI.checksparse: " Patchwork
2025-06-05 23:52 ` ✓ Xe.CI.BAT: " Patchwork
2025-06-07 19:17 ` ✓ Xe.CI.Full: " Patchwork
2025-06-08 4:22 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b2efd54a826d4e561803220d556619d22784cab.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=airlied@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=michael.j.ruhl@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox